From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CD9CF01806 for ; Fri, 6 Mar 2026 07:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yLXJ9HvAYLN2g57Pgnw1ZWPdSO6fo8G+ZhiS6av5Fa8=; b=GvqHW4RfLf1ORnEaZnjkxRVJWK Jr+juCcdgk2Mf7A1xfVO7WT/cJT/0+RSTyk8hbxmGxwnfyAL8wotAu3zwWRVx3Kns5WUH5wo0kNTm WWHupGtzj1j8LwaApQSGSDE4dxa6kZWj7yzZtxVzWSyebwJ7UBzSjrcLCZutWy0KTa8haWlCNezKR fz6tzKrNopWiiCTWRSTJ3xYt+sH0JGibmz6N4CByQ8/m9PPb17q/KFS6HZ8fZ8dQiLaKDQUCCC6i6 lxWOahOO9ywqMufWtKhlNVKaJLBgFnyNFw5/h5OiTtx3Jl8ZSxDM4g4CQ1FwFBVao/Pb2qGgHoUC3 9CxFOkDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyPuj-00000003AwN-2yRY; Fri, 06 Mar 2026 07:48:01 +0000 Received: from pouet.aliel.fr ([65.21.61.41] helo=courrier.aliel.fr) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyPue-00000003Avo-3l6O; Fri, 06 Mar 2026 07:47:58 +0000 Received: from [IPV6:2a02:842b:8136:1:1033:1579:e8cc:83d5] (2A02-842B-8136-0001-1033-1579-E8CC-83d5.rev.sfr.net [IPv6:2a02:842b:8136:1:1033:1579:e8cc:83d5]) by courrier.aliel.fr (Postfix) with ESMTPSA id 73C97426E9; Fri, 06 Mar 2026 07:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aliel.fr; s=courrier-s1; t=1772783271; bh=GJbk3EYD30NiOVRPHD92mUzUsX2DdDJmKW1uLLv40cM=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=X+ZZyijXUwzAj7llgamkLWbvZoAsd+G/6EU2ebWkYEr5VMpHrE7z548GvmOGpN944 rLWajxtjJ3UuALx81J7/uu/KOB3vP9ydbw7uSAf4Pm4SHrRzitOMIfSjR3nCLvVFSw Ay/G3kjnEiATTYlEGeaSaYgpzXi51cGytYFLHnSE= Message-ID: Date: Fri, 6 Mar 2026 08:47:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: Ronald Claveau Subject: Re: [PATCH 3/3] arm64: dts: amlogic: t7: Add clock controller nodes To: Jian Hu , Jerome Brunet , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Stephen Boyd , Michael Turquette , robh+dt , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: devicetree , linux-clk , linux-amlogic , linux-kernel , linux-arm-kernel References: <20260305074328.639993-1-jian.hu@amlogic.com> <20260305074328.639993-4-jian.hu@amlogic.com> Content-Language: en-US In-Reply-To: <20260305074328.639993-4-jian.hu@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260305_234757_542320_A39AF267 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/5/26 8:43 AM, Jian Hu wrote: > Add the required clock controller nodes for Amlogic T7 SoC family: > - SCMI clock controller > - PLL clock controller > - Peripheral clock controller > > Signed-off-by: Jian Hu > --- > arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 125 ++++++++++++++++++++ > 1 file changed, 125 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi > index 6510068bcff9..6ea1b583b13d 100644 > --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi > @@ -6,6 +6,9 @@ > #include > #include > #include "amlogic-t7-reset.h" > +#include > +#include > +#include > > / { > interrupt-parent = <&gic>; > @@ -201,6 +204,33 @@ pwrc: power-controller { > }; > }; > > + sram@f7042000 { > + compatible = "mmio-sram"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0xf7042000 0x100>; > + > + scmi_shmem: sram@0 { > + compatible = "arm,scmi-shmem"; > + reg = <0x0 0x100>; > + }; > + }; > + > + firmware { > + scmi: scmi { > + compatible = "arm,scmi-smc"; > + arm,smc-id = <0x820000c1>; > + shmem = <&scmi_shmem>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + scmi_clk: protocol@14 { > + reg = <0x14>; > + #clock-cells = <1>; > + }; > + }; > + }; > + > soc { > compatible = "simple-bus"; > #address-cells = <2>; > @@ -224,6 +254,42 @@ apb4: bus@fe000000 { > #size-cells = <2>; > ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; > > + clkc_periphs:clock-controller@0 { > + compatible = "amlogic,t7-peripherals-clkc"; > + reg = <0x0 0x0 0x0 0x1c8>; > + #clock-cells = <1>; > + clocks = <&xtal>, > + <&scmi_clk CLKID_SYS_CLK>, > + <&scmi_clk CLKID_FIXED_PLL>, > + <&scmi_clk CLKID_FCLK_DIV2>, > + <&scmi_clk CLKID_FCLK_DIV2P5>, > + <&scmi_clk CLKID_FCLK_DIV3>, > + <&scmi_clk CLKID_FCLK_DIV4>, > + <&scmi_clk CLKID_FCLK_DIV5>, > + <&scmi_clk CLKID_FCLK_DIV7>, > + <&hifi CLKID_HIFI_PLL>, > + <&gp0 CLKID_GP0_PLL>, > + <&gp1 CLKID_GP1_PLL>, > + <&mpll CLKID_MPLL1>, > + <&mpll CLKID_MPLL2>, > + <&mpll CLKID_MPLL3>; > + clock-names = "xtal", > + "sys", > + "fix", > + "fdiv2", > + "fdiv2p5", > + "fdiv3", > + "fdiv4", > + "fdiv5", > + "fdiv7", > + "hifi", > + "gp0", > + "gp1", > + "mpll1", > + "mpll2", > + "mpll3"; > + }; > + > reset: reset-controller@2000 { > compatible = "amlogic,t7-reset"; > reg = <0x0 0x2000 0x0 0x98>; > @@ -234,6 +300,7 @@ watchdog@2100 { > compatible = "amlogic,t7-wdt"; > reg = <0x0 0x2100 0x0 0x10>; > clocks = <&xtal>; > + > }; Did you forget to add something here for watchdog ? If not I think you can remove that blank line. > > periphs_pinctrl: pinctrl@4000 { > @@ -269,6 +336,64 @@ uart_a: serial@78000 { > status = "disabled"; > }; > > + gp0:clock-controller@8080 { > + compatible = "amlogic,t7-gp0-pll"; > + reg = <0x0 0x8080 0x0 0x20>; > + clocks = <&scmi_clk CLKID_TOP_PLL_OSC>; > + clock-names = "in0"; > + #clock-cells = <1>; > + }; > + > + gp1:clock-controller@80c0 { > + compatible = "amlogic,t7-gp1-pll"; > + reg = <0x0 0x80c0 0x0 0x14>; > + clocks = <&scmi_clk CLKID_TOP_PLL_OSC>; > + clock-names = "in0"; > + #clock-cells = <1>; > + }; > + > + hifi:clock-controller@8100 { > + compatible = "amlogic,t7-hifi-pll"; > + reg = <0x0 0x8100 0x0 0x20>; > + clocks = <&scmi_clk CLKID_TOP_PLL_OSC>; > + clock-names = "in0"; > + #clock-cells = <1>; > + }; > + > + pcie:clock-controller@8140 { > + compatible = "amlogic,t7-pcie-pll"; > + reg = <0x0 0x8140 0x0 0x1c>; > + clocks = <&scmi_clk CLKID_PCIE_OSC>; > + clock-names = "in0"; > + #clock-cells = <1>; > + }; > + > + mpll:clock-controller@8180 { > + compatible = "amlogic,t7-mpll"; > + reg = <0x0 0x8180 0x0 0x28>; > + clocks = <&scmi_clk CLKID_FIXED_PLL_DCO>; > + clock-names = "in0"; > + #clock-cells = <1>; > + }; > + > + hdmi:clock-controller@81c0 { > + compatible = "amlogic,t7-hdmi-pll"; > + reg = <0x0 0x81c0 0x0 0x20>; > + clocks = <&scmi_clk CLKID_HDMI_PLL_OSC>; > + clock-names = "in0"; > + #clock-cells = <1>; > + }; > + > + mclk:clock-controller@8300 { > + compatible = "amlogic,t7-mclk-pll"; > + reg = <0x0 0x8300 0x0 0x18>; > + clocks = <&scmi_clk CLKID_MCLK_PLL_OSC>, > + <&xtal>, > + <&scmi_clk CLKID_FCLK_50M>; > + clock-names = "in0", "in1", "in2"; > + #clock-cells = <1>; > + }; > + > sec_ao: ao-secure@10220 { > compatible = "amlogic,t7-ao-secure", > "amlogic,meson-gx-ao-secure", -- Best regards, Ronald