From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEBEC3A5A5 for ; Tue, 3 Sep 2019 07:26:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80B7822CF8 for ; Tue, 3 Sep 2019 07:26:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C8I8HNWl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="SrANXdEF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80B7822CF8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jaz4WbiwESUFeKBbBKqPAMADHZ8Yos2CtGycE2HhFL8=; b=C8I8HNWl96T7CwupLRENE7RWf sCs1AWTPPryqoyFEuaV2lEJ7uO12TbPDCoauQ462LLVVl5Jw7QsU2FycPUKczkIi+iC4N8t+I35nW bsAb5iD9nu50ivqv3Iljx3B/Si0MSSzDxNbGHS6A+VUNXjVPrENnUGtvxUWMNGxU+TcnkfxhLquOR QzotCvb7k06ctDrB/TCJIaQzOH+iv67JQVr1ax15rVCHM14bJ+9Vj0JswqiW+Lp6HZ4FnVPTAh3vv QpgkmXBvTwC5+A39oMrltTHOowYBY1kqqfUUmpzAG4nq4xItrcX8RnkFiKR4yXJqXBCHEkRXyQROO 5rJkdRhAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i53Cj-0005cJ-3T; Tue, 03 Sep 2019 07:26:17 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i53Cd-0005bo-9n for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2019 07:26:13 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x837Pus7129827; Tue, 3 Sep 2019 02:25:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1567495556; bh=DTmLVy2ziaAjBJ4cNhFcYLIyv/5BpnQYc8ZCnq8IR9Y=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=SrANXdEFr3BINBZfGGN/JCp6nYyD/6bmihj8iUe3D4ISiL5Xv9FF3xmQUg2GyEeEQ kVwPsixx/oquGIU0eTuvlE7yr22TQbOEYFfi5VhBqIQ5Bmh3vS6d3VcPISZLgqyL20 Y6aE2Qr4ttVQgfLJwYegcNktpGiNdI19RaoAZqzk= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x837Putu117512 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Sep 2019 02:25:56 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 3 Sep 2019 02:25:55 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 3 Sep 2019 02:25:55 -0500 Received: from [127.0.0.1] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x837Prlb110987; Tue, 3 Sep 2019 02:25:53 -0500 Subject: Re: [PATCHv3 01/10] dt-bindings: omap: add new binding for PRM instances To: Rob Herring References: <20190830121816.30034-1-t-kristo@ti.com> <20190830121816.30034-2-t-kristo@ti.com> <20190902042631.GA22055@bogus> From: Tero Kristo Message-ID: Date: Tue, 3 Sep 2019 10:25:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190902042631.GA22055@bogus> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_002611_472076_9B9797A7 X-CRM114-Status: GOOD ( 18.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, tony@atomide.com, p.zabel@pengutronix.de, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/09/2019 16:39, Rob Herring wrote: > On Fri, Aug 30, 2019 at 03:18:07PM +0300, Tero Kristo wrote: >> Add new binding for OMAP PRM (Power and Reset Manager) instances. Each >> of these will act as a power domain controller and potentially as a reset >> provider. >> > > Converting this to schema would be nice. Do you have documentation about schema somewhere? Basically what I need to do to fix this. > >> Signed-off-by: Tero Kristo >> --- >> .../devicetree/bindings/arm/omap/prm-inst.txt | 31 +++++++++++++++++++ > > bindings/reset/ I did not put this under reset, because this is basically a multi-purpose function. Reset just happens to be the first functionality it is going to provide. It will be followed by power domain support later on. Any thoughts? > >> 1 file changed, 31 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/omap/prm-inst.txt >> >> diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt >> new file mode 100644 >> index 000000000000..7c7527c37734 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt >> @@ -0,0 +1,31 @@ >> +OMAP PRM instance bindings >> + >> +Power and Reset Manager is an IP block on OMAP family of devices which >> +handle the power domains and their current state, and provide reset >> +handling for the domains and/or separate IP blocks under the power domain >> +hierarchy. >> + >> +Required properties: >> +- compatible: Must be one of: >> + "ti,am3-prm-inst" >> + "ti,am4-prm-inst" >> + "ti,omap4-prm-inst" >> + "ti,omap5-prm-inst" >> + "ti,dra7-prm-inst" > > '-inst' seems a bit redundant. ti,xyz-prm is already reserved by the parent node of all these. The hierarchy is basically like this (omap4 as example): prm: prm@4a306000 { compatible = "ti,omap4-prm"; ... prm_dsp: prm@400 { compatible = "ti,omap4-prm-inst"; ... }; prm_device: prm@1b00 { compatible = "ti,omap4-prm-inst"; ... }; ... }; > >> +- reg: Contains PRM instance register address range >> + (base address and length) >> + >> +Optional properties: >> +- #reset-cells: Should be 1 if the PRM instance in question supports resets. >> +- clocks: Associated clocks for the reset signals if any. Certain reset >> + signals can't be toggled properly without functional clock >> + being active for them. >> + >> +Example: >> + >> +prm_dsp2: prm@1b00 { > > reset-controller@... Well, as said, the same node is going to be also power domain provider later on... > >> + compatible = "ti,dra7-prm-inst"; >> + reg = <0x1b00 0x40>; >> + #reset-cells = <1>; >> + clocks = <&dsp2_clkctrl DRA7_DSP2_MMU0_DSP2_CLKCTRL 0>; >> +}; >> -- >> 2.17.1 >> >> -- > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel