From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 688E1C636CC for ; Tue, 7 Feb 2023 13:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xpiixtAAGv5ltnXP41xupCrb8Q9XgfMbIZg+lkbNQvI=; b=UnKa8vjkj/Pyar CU810GSpO1c4gFtUp7e0ivcwflIt6QMo7kKbpDNAY2dX7bmrJAr5NeY7r9Wicr3oAD272jtz3VugT YfvLDDubOYMxlNGpwN3mJiICXmMRJZ8GX2vev5cYhlYIoWgDIb3rLw351HhpEJqMv4v9zx1DvoCus X4gR6iaIF37FqXGjSmGryJ+XmNo2gI1ny+H8YECuKXw6w1w240TmobKa0v85rHOKAyjhJAcML0pNT U6ftKrKaKz9WTIAWTKNrCTTC3pOAYmSgV5KfFrgPZRzvSqV8AdP2W9Dy35tFe0KhjQD34lIhaJPaF DSY34zEKkwx4fv6p0fcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPO6E-00CJ5t-JW; Tue, 07 Feb 2023 13:33:31 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPO69-00CJ3J-G9 for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2023 13:33:27 +0000 Received: by mail-wr1-x432.google.com with SMTP id r2so13559637wrv.7 for ; Tue, 07 Feb 2023 05:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=4Gnj8mx6BQv+P/VZTc2ZRvZ4cPWBzn/d/g1R6N3t1SY=; b=sywB6VKP5uMO4iMwIfYWNewUXqdyUmfAHNyhyo3OrdI4w9hMA/do0JdT6XDgbayfL+ hioKOeqNB9gmBTeOJ+GEqRzkacs91bBLXr18APnsVAUBpOFSSsRR/mPgDw2PAZiSngST GHN3F7C6RRw0zyStZrcDu6HUwZTZEJW9//HKZNnFr8pbdBYO0ZeQTSQ1wJUc9qr39WDw RAZprI560qB9/D7SJ2L2mhHzMzvqn4IkElOgb3RhfyiCRKxMOqVm8can1xTMfSUuQzTl 3d/Otz4g9TJG3uwzIfUqVNKE0lVe3mXM4bFnaRqiGH/VF2JhF06rxIQG2kcu+KI3CJbC UTcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Gnj8mx6BQv+P/VZTc2ZRvZ4cPWBzn/d/g1R6N3t1SY=; b=p03ElnpfTh7JfWgBDQM5rUBgNuu1mn4/7Y4F/eFE/4OGe4QH7n+gCgVvkFtMvdP4fb i4BJkqne6lXKbhopYKiQQj1Trjojx2yL2hB4JtaAlWwH06SBqHMqSOU4JCPWoiwN/YyW 6YIORSCNxJXdPCKmHwBJev9jghwBTZKId0RGF/Ra132UhFLyZ8cT02rsueniS/Mi7fRz vnts6zRRlH64iXQ8FTk7ux0Y3WklQB4x/4QYl3465qTa3772k124nxkNKBU8qfgYOSDy TwcwNXnQpxFHM7KQFnB31BVaBIxRl9QnXrWMNpsvsVkDyNoWUod9P1kpq1Vn0qkq89/Y /4RA== X-Gm-Message-State: AO0yUKVF/oxD84nt0yailgHNeqaWedTWbz2njgXiSv4dvCmvNJF+ebwP IW9XVF5Rm6612em0dJeObKAC7g== X-Google-Smtp-Source: AK7set9tflq7m2WGhWzU48ho/FGtJPjdoU4DUvNTQOyFDfwfzYJ/cgrUGOgVxSNmGa0o1E+FD6YRHA== X-Received: by 2002:a05:6000:1b0f:b0:2c3:ea4d:3f01 with SMTP id f15-20020a0560001b0f00b002c3ea4d3f01mr2338118wrz.27.1675776801421; Tue, 07 Feb 2023 05:33:21 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:c58c:fc5c:67d6:e5f3? ([2a01:e0a:982:cbb0:c58c:fc5c:67d6:e5f3]) by smtp.gmail.com with ESMTPSA id t1-20020a5d4601000000b002bdfe3aca17sm11241983wrq.51.2023.02.07.05.33.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 05:33:21 -0800 (PST) Message-ID: Date: Tue, 7 Feb 2023 14:33:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] thermal: Remove core header inclusion from drivers Content-Language: en-US To: Daniel Lezcano , rafael.j.wysocki@intel.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Guillaume La Roque , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Miquel Raynal , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Konrad Dybcio , Thara Gopinath , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , ye xingchen , Ricardo Neri , Srinivas Pandruvada , Haowen Bai , Minghao Chi , "open list:THERMAL DRIVER FOR AMLOGIC SOCS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:ARM/QUALCOMM SUPPORT" , "open list:RENESAS R-CAR THERMAL DRIVERS" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" References: <20230206153432.1017282-1-daniel.lezcano@linaro.org> From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20230206153432.1017282-1-daniel.lezcano@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_053325_555711_100A0D5C X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/02/2023 16:34, Daniel Lezcano wrote: > As the name states "thermal_core.h" is the header file for the core > components of the thermal framework. > > Too many drivers are including it. Hopefully the recent cleanups > helped to self encapsulate the code a bit more and prevented the > drivers to need this header. > > Remove this inclusion in every place where it is possible. > > Some other drivers did a confusion with the core header and the one > exported in linux/thermal.h. They include the former instead of the > latter. The changes also fix this. > > The tegra/soctherm driver still remains as it uses an internal > function which need to be replaced. > > The Intel HFI driver uses the netlink internal framework core and > should be changed to prevent to deal with the internals. > > No functional changes > > [ Applies to thermal/linux-next or linux-pm/linux-next ] > > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/amlogic_thermal.c | 1 - > drivers/thermal/armada_thermal.c | 2 -- > drivers/thermal/broadcom/bcm2835_thermal.c | 1 - > drivers/thermal/hisi_thermal.c | 3 +-- > drivers/thermal/imx8mm_thermal.c | 1 - > drivers/thermal/imx_sc_thermal.c | 1 - > drivers/thermal/intel/intel_hfi.c | 3 ++- > drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 - > drivers/thermal/qoriq_thermal.c | 1 - > drivers/thermal/rcar_gen3_thermal.c | 1 - > drivers/thermal/samsung/exynos_tmu.c | 3 +-- > drivers/thermal/st/stm_thermal.c | 1 - > drivers/thermal/tegra/tegra30-tsensor.c | 1 - > drivers/thermal/uniphier_thermal.c | 2 -- > 14 files changed, 4 insertions(+), 18 deletions(-) > > diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c > index d30cb791e63c..9235fda4ec1e 100644 > --- a/drivers/thermal/amlogic_thermal.c > +++ b/drivers/thermal/amlogic_thermal.c > @@ -28,7 +28,6 @@ > #include > #include > > -#include "thermal_core.h" > #include "thermal_hwmon.h" > > #define TSENSOR_CFG_REG1 0x4 For Amlogic: Reviewed-by: Neil Armstrong _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel