From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Mon, 22 May 2017 15:48:30 +0100 Subject: [PATCH v3 1/3] Documentation/bindings: Document the SafeXel cryptographic engine driver In-Reply-To: <20170522143049.GD14976@kwain.lan> References: <20170424075407.19730-1-antoine.tenart@free-electrons.com> <20170424075407.19730-2-antoine.tenart@free-electrons.com> <7986721e-3a2b-23fb-61d7-7032f0d65533@arm.com> <20170522143049.GD14976@kwain.lan> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Antoine, On 22/05/17 15:30, Antoine Tenart wrote: > Hi Marc, > > On Wed, May 03, 2017 at 05:36:38PM +0100, Marc Zyngier wrote: >> On 24/04/17 08:54, Antoine Tenart wrote: >>> + >>> + crypto: crypto at 800000 { >>> + compatible = "inside-secure,safexcel-eip197"; >>> + reg = <0x800000 0x200000>; >>> + interrupts = , >> >> I'm puzzled. How can the interrupt can be both level *and* edge? That >> doesn't make any sense. > > I agree this looks odd. I took it from Russel's ICU mapping: > http://lists.infradead.org/pipermail/linux-arm-kernel/2017-February/489040.html This emails says: ICU-irq => GIC-SPI-num Enable Edge/Level ICU-group [...] 24 => 34 En Lv 0 which seems to clearly indicate Level (no Edge involved here). > The driver does not use this interrupt (yet?). I'm not sure what is this > interrupt exact configuration... Surely the TRM would indicate this, wouldn't it? > Do you want me to remove this from the documentation (and device trees)? I'd rather you clarify it, if possible. Thanks, M. -- Jazz is not dead. It just smells funny...