From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C783EB64DD for ; Thu, 29 Jun 2023 20:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OweaxdyrdWOa5qzEHK7+zIuF5aitEMJgaoiJKm5jEc0=; b=nqn8RuR9VSNZqK W0kxS/AWFsK/ZGIblaXYclq9hsye96Mt+LKk9HFHOjy0upQtRr/2JXujVpBTuN/Ih6T2HIY8quiDV X15wcSxl6fXGl2LW8YuA7vKQlaC1z5eKJUr8nkMPwS1S1RSBmANSf1Pma0QGJ4VZyoAkaIMdhrJ73 HnOHAmW6eAnSwTyp75wFIKAFFbk9gU5YrJ5CR2u2VRmKAWffmhHb7Qyx9jCEcRJa7XOqXgvD1KK+Q pUEnTODksT+hWLlITLi6wlBb2WUVmbQvDkBo3bkwIDmPi9MpqqKxrzmqxLpJRYFkkMkTIjoAe1kXf WtAOQiO0eeybX2YD66qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEyJa-0025ii-0b; Thu, 29 Jun 2023 20:32:30 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEyJX-0025hl-1q for linux-arm-kernel@lists.infradead.org; Thu, 29 Jun 2023 20:32:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=/+B1m0JF0ePzkHMXkWMYiBT0nCuOnOyD0SNxb3jEcJc=; b=DKuS/3xwGn61aSTe2Kqcp7MWSz EdnetBlhOMCeR8CwTmvNc4EUI0vlNnU1w5XG6TXbgAqYgcG07X6zg4Pn95kkt8o/Ufven/chyeOIG W0R9kx3qLE+StGFBoukgnP8dTyVdmthlQioIYluZN7AHmytF7hXsN9B7zqiy8RxPOAaU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qEyJU-000FmU-Ts; Thu, 29 Jun 2023 22:32:24 +0200 Date: Thu, 29 Jun 2023 22:32:24 +0200 From: Andrew Lunn To: Andrew Halaney Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, mcoquelin.stm32@gmail.com, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, joabreu@synopsys.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, bhupesh.sharma@linaro.org, vkoul@kernel.org, bartosz.golaszewski@linaro.org Subject: Re: [PATCH 3/3] net: stmmac: dwmac-qcom-ethqos: Log more errors in probe Message-ID: References: <20230629191725.1434142-1-ahalaney@redhat.com> <20230629191725.1434142-3-ahalaney@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230629191725.1434142-3-ahalaney@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230629_133227_604042_A6A8F680 X-CRM114-Status: UNSURE ( 7.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 29, 2023 at 02:14:18PM -0500, Andrew Halaney wrote: > These are useful to see when debugging a probe failure. Since this is used for debugging, maybe netdev_dbg(). Anybody actually doing debugging should be able to turn that on. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel