From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Oliver Upton <oliver.upton@linux.dev>, Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH 5/5] arm64/sysreg: Convert OSLAR_EL1 to automatic generation
Date: Tue, 23 May 2023 13:51:41 +0530 [thread overview]
Message-ID: <e92b10d3-27bb-e326-e7f2-d6095b756fac@arm.com> (raw)
In-Reply-To: <ZGx1jT4nQ9HEVWSE@linux.dev>
On 5/23/23 13:43, Oliver Upton wrote:
> On Mon, May 22, 2023 at 05:22:44PM +0100, Mark Brown wrote:
>> Convert OSLAR_EL1 to automatic generation as per DDI0601 2023-03. No
>> functional change.
>>
>> Signed-off-by: Mark Brown <broonie@kernel.org>
>> ---
>> arch/arm64/include/asm/sysreg.h | 3 ---
>> arch/arm64/tools/sysreg | 5 +++++
>> 2 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
>> index 09de958e79ed..3b51e532caa9 100644
>> --- a/arch/arm64/include/asm/sysreg.h
>> +++ b/arch/arm64/include/asm/sysreg.h
>> @@ -140,9 +140,6 @@
>> #define SYS_DBGWCRn_EL1(n) sys_reg(2, 0, 0, n, 7)
>> #define SYS_MDRAR_EL1 sys_reg(2, 0, 1, 0, 0)
>>
>> -#define SYS_OSLAR_EL1 sys_reg(2, 0, 1, 0, 4)
>> -#define OSLAR_EL1_OSLK BIT(0)
>> -
>> #define SYS_OSLSR_EL1 sys_reg(2, 0, 1, 1, 4)
>> #define OSLSR_EL1_OSLM_MASK (BIT(3) | BIT(0))
>> #define OSLSR_EL1_OSLM_NI 0
>
> Should the OSLSR_EL1 definitions be rolled over to the generated scheme
> as well?
Agreed, was about to ask the same question :) Any reason it got skipped ?
>
>> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
>> index a5ae0e19fc9f..84df0b7feb45 100644
>> --- a/arch/arm64/tools/sysreg
>> +++ b/arch/arm64/tools/sysreg
>> @@ -83,6 +83,11 @@ Res0 5:1
>> Field 0 SS
>> EndSysreg
>>
>> +Sysreg OSLAR_EL1 2 0 1 0 4
>> +Res0 63:1
>> +Field 0 OSLK
>> +EndSysreg
>> +
>> Sysreg ID_PFR0_EL1 3 0 0 1 0
>> Res0 63:32
>> UnsignedEnum 31:28 RAS
>>
>> --
>> 2.30.2
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-23 8:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 16:22 [PATCH 0/5] b4/sysreg: More conversions to automatic generation Mark Brown
2023-05-22 16:22 ` [PATCH 1/5] arm64/sysreg: Remove some unused sysreg definitions Mark Brown
2023-05-23 8:23 ` Anshuman Khandual
2023-05-23 11:31 ` Shaoqin Huang
2023-05-23 11:40 ` Marc Zyngier
2023-05-22 16:22 ` [PATCH 2/5] arm64/sysreg: Convert MDCCINT_EL1 to automatic register generation Mark Brown
2023-05-23 8:23 ` Anshuman Khandual
2023-05-23 11:33 ` Shaoqin Huang
2023-05-22 16:22 ` [PATCH 3/5] arm64/sysreg: Convert MDSCR_EL1 " Mark Brown
2023-05-23 11:40 ` Shaoqin Huang
2023-05-22 16:22 ` [PATCH 4/5] arm64/sysreg: Standardise naming of bitfield constants in OSL[AS]R_EL1 Mark Brown
2023-05-23 11:52 ` Shaoqin Huang
2023-05-22 16:22 ` [PATCH 5/5] arm64/sysreg: Convert OSLAR_EL1 to automatic generation Mark Brown
2023-05-23 8:13 ` Oliver Upton
2023-05-23 8:21 ` Anshuman Khandual [this message]
2023-05-23 8:39 ` Mark Brown
2023-05-23 11:53 ` Shaoqin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e92b10d3-27bb-e326-e7f2-d6095b756fac@arm.com \
--to=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).