From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B2E7C7EE2E for ; Fri, 9 Jun 2023 09:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XpJTY5DvJ7XLAidsrPLg05HD20JpgkLuq3+1N4g6GYI=; b=eqCvPcV+6oCR8t 8nw2WHoF8/0uZmH2K0dAZpigNWcsyjmNtiPoHwd4nNWVx2BMkwT6/xECtjMr0VqusA/0TwolpElM7 a3KaNyUf6ZAF7ykerxg76avsxRXuASjcEbB9Aoof7avmVs9N6SLLn7pDP2Yc1L4DMzBURUqTiO2vk Vxuo/kfqvObc3NjnHcUpItSLT7h3KpRvLoRGA+IwUj6CNiv/iYII6D5CJyW9EKrHqLgarCBOoGol2 jkZV7JFOPiVurcGujZSHbwez3AUy/pmi7qGTNTZd1hd3DXNzE/oOUyFhZLLUf7k9kEayMxSKBmcAy /B8xoGdoETFAK5tDfg6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7Y30-00CLl5-2O; Fri, 09 Jun 2023 09:04:42 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7Y2y-00CLji-0j for linux-arm-kernel@lists.infradead.org; Fri, 09 Jun 2023 09:04:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686301477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TLk6gSKtsM+p9Rtgq5+IZGVTEjc3fvT8GmlHeUGj3wU=; b=Bp2xxkoMJgqmJjf74eWqs43rtcEN0YCHR6+SbZFCacHtMQXwS+9hjxUlqgrJUt2A3dn4tB BrOlpaDRlhFRg3LLw+ENbI2BrNkavjimur+m6NAiEVGeKweKe66x6KrXHXshy1eM1sIRk1 cYVt0PKy6eJbOSz/DeLYks317X1zcy0= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-a996-FifOKSqNmZjFz_lcw-1; Fri, 09 Jun 2023 05:04:34 -0400 X-MC-Unique: a996-FifOKSqNmZjFz_lcw-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-94a356c74e0so148964266b.2 for ; Fri, 09 Jun 2023 02:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301473; x=1688893473; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TLk6gSKtsM+p9Rtgq5+IZGVTEjc3fvT8GmlHeUGj3wU=; b=TAKHXn65ReGMV//y0/yjtu+2zWcBsTwEuBjSVJ74DFFhHI6zp/vmL7qFKEXzLIPe1C TvcBvcOi0Ygiz8CXpUM6BtmDAvSkFcEJuDplbXnBFhuO88166REWLnehfgp2+58nIUNb 0mzlKVK1vNkp7Jl7vONKIfBvanGVTp1RwiPZf/mV/aIkg2JcR+0F+v5VTwAg1ELTSDun 8iB+JHK3ypGs/eDuTyyoxCspRJSodyDAec3ebVYUwm2hdzB5NydmLIW3TSw/SRCl6bpw 1QZDEedqkhMsYrExMC1OwTV3FJZLPTmmzWHnIeG0cTHknp5Up5+O2GOVK3hkI0LfS/IP yu/w== X-Gm-Message-State: AC+VfDxPtc7X6h3fy9U/k5Y2w4niew/b1pHJiivN4fG/Pdh3HSrpqPH9 COSTiDQDwF6DlrLch2bkKpPy5Qi4cVIEYrE/joURjTZQ82MsyWJcU2fF5zPB1EpWTiwVazDJM9O UwDDUGWJQM5rU9hTuHvfYYuEYuFE0us1ob/g= X-Received: by 2002:a17:907:c15:b0:94e:1764:b09b with SMTP id ga21-20020a1709070c1500b0094e1764b09bmr1027452ejc.45.1686301472968; Fri, 09 Jun 2023 02:04:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4KrasOi5l6sCNShc9kV8qfG1eq+fRbvkSLL3UxeHKWwdsKczbSQdc/+63BzxHLxAbWxA2H7A== X-Received: by 2002:a17:907:c15:b0:94e:1764:b09b with SMTP id ga21-20020a1709070c1500b0094e1764b09bmr1027414ejc.45.1686301472616; Fri, 09 Jun 2023 02:04:32 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id v5-20020a170906858500b0096f72424e00sm1013932ejx.131.2023.06.09.02.04.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 02:04:32 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 11:04:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young() To: Jason Gunthorpe , Yu Zhao Cc: Andrew Morton , Alistair Popple , Anup Patel , Ben Gardon , Borislav Petkov , Catalin Marinas , Chao Peng , Christophe Leroy , Dave Hansen , Fabiano Rosas , Gaosheng Cui , Gavin Shan , "H. Peter Anvin" , Ingo Molnar , James Morse , "Jason A. Donenfeld" , Jonathan Corbet , Marc Zyngier , Masami Hiramatsu , Michael Ellerman , Michael Larabel , Mike Rapoport , Nicholas Piggin , Oliver Upton , Paul Mackerras , Peter Xu , Sean Christopherson , Steven Rostedt , Suzuki K Poulose , Thomas Gleixner , Thomas Huth , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, linux-mm@google.com References: <20230526234435.662652-1-yuzhao@google.com> <20230526234435.662652-2-yuzhao@google.com> From: Paolo Bonzini In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_020440_339557_483513F8 X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/31/23 21:17, Jason Gunthorpe wrote: >> + int (*test_clear_young)(struct mmu_notifier *mn, struct mm_struct *mm, >> + unsigned long start, unsigned long end, >> + bool clear, unsigned long *bitmap); >> + > Why leave clear_young behind? Just make a NULL bitmap mean > clear_young? It goes away in patch 2, together with: @@ -437,7 +412,7 @@ static inline int mmu_notifier_clear_young(struct mm_struct *mm, unsigned long end) { if (mm_has_notifiers(mm)) - return __mmu_notifier_clear_young(mm, start, end); + return __mmu_notifier_test_clear_young(mm, start, end, true, NULL); return 0; } @@ -445,7 +420,7 @@ static inline int mmu_notifier_test_young(struct mm_struct *mm, unsigned long address) { if (mm_has_notifiers(mm)) - return __mmu_notifier_test_young(mm, address); + return __mmu_notifier_test_clear_young(mm, address, address + 1, false, NULL); return 0; } Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel