From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA6F0C5479D for ; Mon, 9 Jan 2023 18:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I3DpIZPPvndqTKRHNmbiTXZsncBocqDy+agFMRO1MVU=; b=32h+qgPP743ovA 3f1gbrl8bT45PVj1HoO14u1IrQGT8A/ueyDMa6gxPikwWVY7TzCFSx40L9sf87JTO+DcnVunlWsH5 aBw6GdzF48eOvRLzHk9o6XTSI/g6hNQv3EPPXcsr9UnGwCE1Kgje6AMv2KACCuzKz7ex7RsDO0hLh 0fUO8QXiaHVvOlKSsxVCijHMM5AwRNvo6hVNREmx0Z8rVSb6K5lJK5y9iJEKhBxp+ytJEcF0FKeoZ JShBwa8htVqOlTN41aXbp8GM3RdN8syFwy4niNU7ZsNOcd5JclXbwVzn2G+sH03cyLkgiEkLuNgfO Ul2mWLUWLcJaMP2SdFjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEwv4-003J4K-Mu; Mon, 09 Jan 2023 18:30:51 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEwmf-003F50-Ih for linux-arm-kernel@lists.infradead.org; Mon, 09 Jan 2023 18:22:11 +0000 Received: by mail-wr1-x436.google.com with SMTP id d17so9117828wrs.2 for ; Mon, 09 Jan 2023 10:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jvYugD5smOlPeb8yw4a3uYKIpMLS5cDQVS3icNcFMKA=; b=Z6PyaEpVm6gQZPhyOA+umXIzP1gj2ivonb832kvaPK2LHBAyLgqzEzWs+trmEE0Jln khMmlms5Uv6PhL4q8PhFwsygO3DHLGc4l5gyw4ZBVAMxJaFNOTa/D+37v6hQEgNUi6HJ MwrpiJXqxUpvHZ/jLL+pwFgBfNyRIeOFG6BE2kS+7uUlUG3H6z1r5xzHXB+rv1s49c7Z /cxqXGU2xlMj3qBcL9i+f7FQf/GhDu4ibCR+/YuG/aUITAgdMLmIeG9x8sQ8tEVru5a6 NNDcVLsWYktntSaFMN0HlSbfAEBeUesEeaNrLaNMlba8+UyRhbCP48f1qqKf5QYGnay+ VoIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jvYugD5smOlPeb8yw4a3uYKIpMLS5cDQVS3icNcFMKA=; b=IQZQ1k57ExeuGGSSzUai4lMz/aQqgD6SYXf/+5mDdKVFm1uDv/iDoy6vwPJMZAWYz3 BBbNV05InBBSoMTympYbVgyfYij7deaSPnpWq+5/v1j5fZd2d3SMtZa+KhnGGlPtp+U5 XDbNVl0KzhI6wRt06MxIl9hpKHlWzC5RTlemHl6L5HiOOFJu5Y2O6FMv2BuVy8r6u1t5 jGmtrJ9kz4SlgtJ8z9wD1WmPNcoeghuK9SLiCYc0ZijWJbVcdQR8AFv2DGS0mf065ARq cZX7RiA0ucGScb4nlw2HlxN8cYooZ4UnFI87vcucw0XY9U3VUTWfZG6CXmzbMVB3IOpT n0hA== X-Gm-Message-State: AFqh2koEhq8ZGT+PM7l9JBsW0qpbetlTczhlF7oVBqL21W904YseclFs jqYhhaSANUW2a/jKDuz1/n2CXA== X-Google-Smtp-Source: AMrXdXvjfzGBA2k+30sjPaP84E+50hgotZRZMLKqmz8cAfThUKaz2IKhBGPXhX7+mGfJd+LOudPNGg== X-Received: by 2002:a5d:5544:0:b0:26d:2af7:420 with SMTP id g4-20020a5d5544000000b0026d2af70420mr40676769wrw.33.1673288528036; Mon, 09 Jan 2023 10:22:08 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o15-20020a5d62cf000000b002bbedd60a9asm3589168wrv.77.2023.01.09.10.22.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 10:22:07 -0800 (PST) Message-ID: Date: Mon, 9 Jan 2023 19:22:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 07/18] interconnect: qcom: add a driver for sa8775p Content-Language: en-US To: Bartosz Golaszewski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Georgi Djakov , Will Deacon , Robin Murphy , Joerg Roedel , Manivannan Sadhasivam , Jassi Brar , Linus Walleij , Catalin Marinas , Richard Cochran , Srinivas Kandagatla , Vinod Koul , Alex Elder Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Shazad Hussain , Bartosz Golaszewski References: <20230109174511.1740856-1-brgl@bgdev.pl> <20230109174511.1740856-8-brgl@bgdev.pl> From: Krzysztof Kozlowski In-Reply-To: <20230109174511.1740856-8-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230109_102209_674390_0CEB26F8 X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/01/2023 18:45, Bartosz Golaszewski wrote: > From: Shazad Hussain > > Introduce QTI SA8775P-specific interconnect driver. > > + > +static struct qcom_icc_desc sa8775p_pcie_anoc = { > + .nodes = pcie_anoc_nodes, > + .num_nodes = ARRAY_SIZE(pcie_anoc_nodes), > + .bcms = pcie_anoc_bcms, > + .num_bcms = ARRAY_SIZE(pcie_anoc_bcms), > +}; > + > +static struct qcom_icc_bcm *system_noc_bcms[] = { > + &bcm_sn0, > + &bcm_sn1, > + &bcm_sn3, > + &bcm_sn4, > + &bcm_sn9, > +}; > + > +static struct qcom_icc_node *system_noc_nodes[] = { > + [MASTER_GIC_AHB] = &qhm_gic, > + [MASTER_A1NOC_SNOC] = &qnm_aggre1_noc, > + [MASTER_A2NOC_SNOC] = &qnm_aggre2_noc, > + [MASTER_LPASS_ANOC] = &qnm_lpass_noc, > + [MASTER_SNOC_CFG] = &qnm_snoc_cfg, > + [MASTER_PIMEM] = &qxm_pimem, > + [MASTER_GIC] = &xm_gic, > + [SLAVE_SNOC_GEM_NOC_GC] = &qns_gemnoc_gc, > + [SLAVE_SNOC_GEM_NOC_SF] = &qns_gemnoc_sf, > + [SLAVE_SERVICE_SNOC] = &srvc_snoc, > +}; > + > +static struct qcom_icc_desc sa8775p_system_noc = { This and several others are const, which means you started entire work on some old code. It's quite a waste of your effort as now you have to get all the patches we did for cleanups. Much better to start off from a newest file. If you based work on downstream code, then this definitely needs many fixes... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel