From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C39A4C433C1 for ; Mon, 22 Mar 2021 22:51:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58A0D619A3 for ; Mon, 22 Mar 2021 22:51:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58A0D619A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8tOpP2u3GsqpBTpa78NjE8xSYs3uBUHYM2pwhR6e6pI=; b=pXjtk8wvwmEZPgKkMhvjWJ99D vj9FsVpk/ueOl7q9ucE+Zb4iaCn4KE5jhlmN4YQqI4FsOnr/sBHhBFgmeLH/FfrjHC9WK98Z9y+RD F/xhX4w/dmZ+Znd0bDyC34PAmWeHyyT3XTZhnoFARnSVgxnPBF8uoc06xDSquTCcdSiXIw4aGU1OM Xmkm++TkIm4uUVrlz+1t0ydzJCA8NIgy6BVz5jpQ3Lf11XnSsKftCJqERvJU+3PAZ3HbWn2vbVR4r Q5FCaG4cfPCj9Mbg8aHh2ByOfb5VhqxGkW0kgRFBGBQm4jaP7w4n2NDWJIpUz2texj/EXjIu7Kfpe SCLLApP7g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOTMp-00CkQa-2H; Mon, 22 Mar 2021 22:49:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOTMk-00CkPg-0m for linux-arm-kernel@lists.infradead.org; Mon, 22 Mar 2021 22:49:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 401841042; Mon, 22 Mar 2021 15:49:37 -0700 (PDT) Received: from [10.57.55.187] (unknown [10.57.55.187]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 034DD3F792; Mon, 22 Mar 2021 15:49:35 -0700 (PDT) Subject: Re: [PATCH v4 15/19] dts: bindings: Document device tree bindings for ETE To: Rob Herring Cc: linux-arm-kernel , "linux-kernel@vger.kernel.org" , Mathieu Poirier , Mike Leach , Anshuman Khandual , Leo Yan , devicetree@vger.kernel.org References: <20210225193543.2920532-1-suzuki.poulose@arm.com> <20210225193543.2920532-16-suzuki.poulose@arm.com> <20210306210627.GA1207387@robh.at.kernel.org> From: Suzuki K Poulose Message-ID: Date: Mon, 22 Mar 2021 22:49:34 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_224943_156339_C94F15F4 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/03/2021 17:28, Rob Herring wrote: > On Mon, Mar 22, 2021 at 10:53 AM Suzuki K Poulose > wrote: >> >> Hi Rob >> >> On 06/03/2021 21:06, Rob Herring wrote: >>> On Thu, Feb 25, 2021 at 07:35:39PM +0000, Suzuki K Poulose wrote: >>>> Document the device tree bindings for Embedded Trace Extensions. >>>> ETE can be connected to legacy coresight components and thus >>>> could optionally contain a connection graph as described by >>>> the CoreSight bindings. >>>> >>>> Cc: devicetree@vger.kernel.org >>>> Cc: Mathieu Poirier >>>> Cc: Mike Leach >>>> Cc: Rob Herring >>>> Signed-off-by: Suzuki K Poulose >>>> --- >>>> + out-ports: >>>> + description: | >>>> + Output connections from the ETE to legacy CoreSight trace bus. >>>> + $ref: /schemas/graph.yaml#/properties/port >>> >>> s/port/ports/ >> >> Ok. >> >>> >>> And then you need: >>> >>> properties: >>> port: >>> description: what this port is >>> $ref: /schemas/graph.yaml#/properties/port >> >> Isn't this already covered by the definition of ports ? There are no >> fixed connections for ETE. It is optional and could be connected to >> any legacy CoreSight component. i.e, a "ports" object can have port >> objects inside. > > 'properties/ports' only defines that you have 'port' nodes within it. > >> Given we have defined out-ports as an object "confirming to the ports" >> do we need to describe the individual port nodes ? > > Yes, you have to define what the 'port' nodes are. A port is a data > stream and you should know what your hardware has. What the data > stream is connected to is outside the scope of the binding. Ok, I have included the above changes for the next version. Thanks Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel