From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97926C7618A for ; Mon, 20 Mar 2023 12:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nyac5J+4Vj6rRoJEu/8DGwAX+lOrKuncp+Dils4raIg=; b=HWahjFRsYP9VfM yCJdjXPTzB2b2KlViRqkkHzl7GrBcVo6XkhIK7pNLrGUSSQChfjc8IkgIE5L52yWcKfcYB7ebKKrL hVS1MsDjJGCV/0mPEZS5vEbtx5Rw3eDZZs+dKyYZpJJP0ST5/Fbq2ziDZH76rbOceJHi6+VKF1HJ4 EvTfhBy2M0Fmu6Bxpxk2UyuXlqzv5a3FljYbdePLPkfyqiI+0S+HoAfi2S8pF9DsNV6ocmYimsJQV ikQ33v6NJVW8Evl9v8X2JO6EaUo2IxJpCvRobsxwj5gtGoKVqWpHOGDBVUvE0bq9GSGwNeACgGJNZ 3xZ2bwN17Eu0myMpBdHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peEGk-008vgr-2j; Mon, 20 Mar 2023 12:05:42 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peEGh-008vfm-37 for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 12:05:41 +0000 Received: by mail-ed1-x52d.google.com with SMTP id r11so45749908edd.5 for ; Mon, 20 Mar 2023 05:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679313935; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fedWdOIXJsNBKS4RtVOA7U0PbI5IbSCYkI9M2Yv/QEg=; b=Ei7LNCBt7McN/imVovbkYW70ZdaAZlmUX8ZXfNVOiyuG80+m+jPF+4TTKyLfGbGxPp 8KDJrFMHjzGQKXFKnQMAtFSMWyVAZyKydtmXHp+FUa/SuXAvLz4GtwUW1wGEWxf5QgL1 X5Sse5ymSooYAKa5IHVye7AgsKjR2sTzNzuiYem0c4qANN6L0z8VJPKcHFLJzzd4xA4n ghFsMCMu8x1oKFxXELHIjUPk6cyQxLre3HZeSjJtwK1IJUWhsFNGS7BxLV3A/Q5CYfvh n5OHJt+xLZQdZuAGzxYt/I3J7kdwB39ZW2bZqYwDXQd2ihwWQu7dq7MJHcDqpLWa5P8R qOgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679313935; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fedWdOIXJsNBKS4RtVOA7U0PbI5IbSCYkI9M2Yv/QEg=; b=hNAd4LgB3svym9j2evVDIYJgU8xIW6ezvJVYwjZph9pMxCHdu1Mld+r4Y0pLZHWHi1 3OakyWJ/vznCQsrJS/riaEFD0i+09Sn0VafoeC+52i9p5iwAGnLJp4sbnKKwOAcanRVK w47sMR4zNarrotNRXsvEqrozo4hQnd+/n1K44rap0OnjF+YUkTLgQrWsGGzSONQIxdDH WQt0oBzEv1MavJ6y6rkfSeFcH4eE0J3MDrQ/TEfnlONG1knmvUaPePjPG7sDPM/Aazrc a/KcbA9J5cEbc3HvxNZpQjc21+nYqIdmGXolirf6Jray8v5TxGXoLinAcasOVElIfuJ5 Px3Q== X-Gm-Message-State: AO0yUKVC/frIshNfSxERzuBiibMN9/uUdNQsKApKXrfDTCSi86yoAYsH fn+Am+scKdMCSgbu0nXxmSbzxQ== X-Google-Smtp-Source: AK7set9+EEqEhfmet3QUBcm61u82chev994J+/ophV6+5EzW4nCrCF0i2u8CUkU7H7xrhP9w+C8hRA== X-Received: by 2002:a05:6402:1353:b0:4fa:ba31:6c66 with SMTP id y19-20020a056402135300b004faba316c66mr12438314edw.42.1679313934876; Mon, 20 Mar 2023 05:05:34 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:458e:64e7:8cf1:78b0? ([2a02:810d:15c0:828:458e:64e7:8cf1:78b0]) by smtp.gmail.com with ESMTPSA id u2-20020a50a402000000b004c4eed3fe20sm4825654edb.5.2023.03.20.05.05.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 05:05:34 -0700 (PDT) Message-ID: Date: Mon, 20 Mar 2023 13:05:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct i.MX8MQ support Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , Xu Yang Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jun Li References: <20230320020714.955800-1-peng.fan@oss.nxp.com> <8efe78d3-ff50-1970-3a90-28bab4992bad@linaro.org> <355d5dde-cc86-018c-85d5-51cf59bdb36a@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_050540_030245_30490E06 X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/03/2023 12:44, Peng Fan wrote: >> Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct >> i.MX8MQ support >> >> On 20/03/2023 12:02, Peng Fan wrote: >>>> Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct >>>> i.MX8MQ support >>>> >>>> On 20/03/2023 03:07, Peng Fan (OSS) wrote: >>>>> From: Peng Fan >>>>> >>>>> The previous i.MX8MQ support breaks rockchip,dwc3 support, so use >>>>> select to restrict i.MX8MQ support and avoid break others. >>>>> >>>>> Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ") >>>>> Signed-off-by: Peng Fan >>>>> --- >>>>> .../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++------- >>>>> 1 file changed, 14 insertions(+), 7 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>>>> b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>>>> index 16c7d06c9172..6347a6769ee3 100644 >>>>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>>>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>>>> @@ -28,15 +28,22 @@ allOf: >>>>> else: >>>>> $ref: usb-xhci.yaml# >>>>> >>>>> +select: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + enum: >>>>> + - fsl,imx8mq-dwc3 >>>> >>>> And what about all snps,dwc3 devices there (without specific compatible)? >>>> Previously they were selected and now they are not... so you just >>>> disabled schema for all of them. >>> [Peng Fan] >>> >>> I am not sure how to address: >>> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore >>> .kernel.org%2Fall%2FCAL_Jsq%2BnrqTX5ND3%3D%2BkFUmStx- >> %2Bb%3DqpE_WsL_Le >>> -YX8c285- >> 5A%40mail.gmail.com%2F&data=05%7C01%7Cpeng.fan%40nxp.com%7C1e >>> >> 67df79692243f058fa08db2937befd%7C686ea1d3bc2b4c6fa92cd99c5c30163 >> 5%7C0% >>> >> 7C0%7C638149091586933618%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC >> 4wLjAwMDAiL >>> >> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&s >> data=r1 >>> fesB1c%2B3YxohCGM36xySFucVU25WVYIMlpgGkdoWk%3D&reserved=0 >>> >>> Rob suggested use select, but I am not sure how to use it here. Use an >>> extra yaml file with select or else. >>> >>>> >>>>> + required: >>>>> + - compatible >>>>> + >>>>> properties: >>>>> compatible: >>>>> - oneOf: >>>>> - - items: >>>>> - - const: fsl,imx8mq-dwc3 >>>> >>>> I don't understand why you remove your compatible. >>> [Peng Fan] >>> >>> My last change drops 'contains' by mistake, and breaks >> >> This I understand. >> >>> rockchip,dwc3, so just bring back the original content >> >> This is not a reason to make your compatible undocumented. You basically >> revert your patch. It does not make any sense to me. > [Peng Fan] > > ok, let me think more. Honestly not have good idea (: > If you have any guidance, that would be helpful. You should only need a select, however most likely selecting also snps,dwc3 (without specific compatible). Anyway this binding - including how it is referenced by others - is getting unmanagable. I think I commented about this on some other occasion. The point is that no one refactors it thus it grows and grows leading to more of such tricky scenarios. How it should be refactored? Probably just like all other with re-usable components: common part and device specific bindings including it. While snps,dwc3 alone should not be allowed anymore. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel