From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B239C4338F for ; Thu, 19 Aug 2021 03:25:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA7186103A for ; Thu, 19 Aug 2021 03:25:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EA7186103A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=t0uvcW7bCLo9NOXrOBvAuAomMwWbm1jCS9IB81iYfaM=; b=3qUlfI4UgbNym7FBgrVbVNgsPd am1ewc15XMF4N8ME+6bKVnOexa8IDsDUaTTAtUVODlNXupAQKJKP7i6zO7Br6CGPcbLYn7vaR748h OWfx8l4c4LZXPDN8w3NnJIXAVWpGLNn4IZFpt6ZctUV1fHDUITZynVYyGxPRI/iFas/+KKpwYQq4Y +2G/kJ6SUdKjyn7/erjoSQKjBrsgzrxlwAKaU4fAfhBBuJZSMZmuf9kcfCYTBdrZYMlGFyS4hFxsp ePIpR9u0OEXfNHz/VCsCz1VKZLfF5dGFkcVO/IxgKUL2xPKuAW8FTOqM1K69CVY/TsZWM32mOHYY4 ufpTqTdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGYdv-007Aaa-Go; Thu, 19 Aug 2021 03:22:59 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGYdp-007AaB-JZ for linux-arm-kernel@lists.infradead.org; Thu, 19 Aug 2021 03:22:58 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 64445580E09; Wed, 18 Aug 2021 23:22:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 18 Aug 2021 23:22:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=J 0hKvQPS8dExpxRPdMBJPpKCELXT/DpiSuWLnUrwnKk=; b=XmDbbMMi0IPdHkIga /Dr8Tcd3+4kKG99+hsVFpZ8PWkmKP7DRNGI5dYUHBL7geWxnR5eqtQQCk70p+lcI kYxoJKhIGg4qFXAMqVLpIRfMHpyBO1QGSBaVJEiBensGTSGrF6Lgqsh2sgL7fosk sCT4n5+3donYmJJUbihq5V58gqOXigNjdmwXo9SCH6FuVSs9ganQASdjl8ubk5mq FWm9c3tTNwejfXAryN/vLWsc7FTh3nCbShvd8kzMhaUrCeGCLCcb8yzjLSpmPY9Q xafPqIPPqI+jU2Lp5e0ka4iNH9jBwyT6f7lM5gz33tFY63pxE7N7u+yuoPqS0t/0 b3l3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=J0hKvQPS8dExpxRPdMBJPpKCELXT/DpiSuWLnUrwn Kk=; b=ngovGQUngFRyRuClX8be3K6k1jC+4uCvbnmVt54Wfz/yB+pA/HPNQsYqu 2lp+npdjHgOyoy/smMOFrZsyKXw1JEnV1ZnmXelrh6siqyYX6IujJErtRUNcm4zo 9di1i9pxHWaZKLdp7cbL+Y0ynvNIzr0oZgOkzVlRx31gtxZ2xtJDti8ZvY7zb8ju SgtaQOIyUw+FoRJftCJWQtVqDVPCFcExVxZWLNfkJ6w1EjxRjt8xRR73w28hgMZ0 GT05EC3zUU1S72cLGcMXx1aHMXEt/9ISfET3RCnwr1u0vedcHqI90Kv4B6LpEHCP yDom5UmUlVj35Ru58naO43kz0T7gw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleeigdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpefgveffteelheffjeeukedvkedviedtheevgeefkeehueeiieeuteeu gfettdeggeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Aug 2021 23:22:49 -0400 (EDT) Subject: Re: [PATCH 08/17] pinctrl: sunxi: add support for R329 R-PIO pin controller To: Icenowy Zheng , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Ulf Hansson , Linus Walleij , Alexandre Belloni , Andre Przywara Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210802062212.73220-1-icenowy@sipeed.com> <20210802062212.73220-9-icenowy@sipeed.com> From: Samuel Holland Message-ID: Date: Wed, 18 Aug 2021 22:22:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20210802062212.73220-9-icenowy@sipeed.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_202253_779962_0DAEE3D8 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/2/21 1:22 AM, Icenowy Zheng wrote: > Allwinner R320 SoC has a pin controller in the CPUS power domain. > > Add support for it. > > Signed-off-by: Icenowy Zheng > --- > drivers/pinctrl/sunxi/Kconfig | 5 + > drivers/pinctrl/sunxi/Makefile | 1 + > drivers/pinctrl/sunxi/pinctrl-sun50i-r329-r.c | 292 ++++++++++++++++++ > 3 files changed, 298 insertions(+) > create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun50i-r329-r.c > > diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig > index c662e8b1b351..abd60ff8daec 100644 > --- a/drivers/pinctrl/sunxi/Kconfig > +++ b/drivers/pinctrl/sunxi/Kconfig > @@ -134,4 +134,9 @@ config PINCTRL_SUN50I_R329 > default ARM64 && ARCH_SUNXI > select PINCTRL_SUNXI > > +config PINCTRL_SUN50I_R329_R > + bool "Support for the Allwinner R329 R-PIO" > + default ARM64 && ARCH_SUNXI > + select PINCTRL_SUNXI > + > endif > diff --git a/drivers/pinctrl/sunxi/Makefile b/drivers/pinctrl/sunxi/Makefile > index e33f7c5f1ff9..245840a7959e 100644 > --- a/drivers/pinctrl/sunxi/Makefile > +++ b/drivers/pinctrl/sunxi/Makefile > @@ -26,5 +26,6 @@ obj-$(CONFIG_PINCTRL_SUN50I_H6_R) += pinctrl-sun50i-h6-r.o > obj-$(CONFIG_PINCTRL_SUN50I_H616) += pinctrl-sun50i-h616.o > obj-$(CONFIG_PINCTRL_SUN50I_H616_R) += pinctrl-sun50i-h616-r.o > obj-$(CONFIG_PINCTRL_SUN50I_R329) += pinctrl-sun50i-r329.o > +obj-$(CONFIG_PINCTRL_SUN50I_R329_R) += pinctrl-sun50i-r329-r.o > obj-$(CONFIG_PINCTRL_SUN9I_A80) += pinctrl-sun9i-a80.o > obj-$(CONFIG_PINCTRL_SUN9I_A80_R) += pinctrl-sun9i-a80-r.o > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun50i-r329-r.c b/drivers/pinctrl/sunxi/pinctrl-sun50i-r329-r.c > new file mode 100644 > index 000000000000..dc4792c685ba > --- /dev/null > +++ b/drivers/pinctrl/sunxi/pinctrl-sun50i-r329-r.c > @@ -0,0 +1,292 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Allwinner H616 R_PIO pin controller driver This needs to be updated. > + * > + * Copyright (C) 2020 Arm Ltd. > + * Based on former work, which is: > + * Copyright (C) 2017 Icenowy Zheng > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "pinctrl-sunxi.h" > + > +static const struct sunxi_desc_pin sun50i_r329_r_pins[] = { > + SUNXI_PIN(SUNXI_PINCTRL_PIN(L, 0), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x2, "s_i2s"), /* LRCK */ "s_i2s0" for these would match existing drivers (and the manual). Everything else matches the manual. Regards, Samuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel