From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4206AC433EF for ; Wed, 11 May 2022 06:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5jisADnOVjP5wQ0ar2dIuTgD+rBEXUbMBbMDvoncmWA=; b=FmoSnvHSSCUPg2 KPy7okr6mdYs4KGlR92vmbnjzfe+WUphrdWGOeFjN/TyrVyB32rzqi8Zbp7/HQRsKkYPi9SxaqALG fBaPA/DrVgY1JlzR6hYke2pC2ZRuONy1S5gygXJSEqvHS+epCkxA7wtkHtdI6u3qr2IE0YlVevEK/ 9aIzcWmDz4nhZSv1X1hGKTMb8ZYniC5OXM/VlNDJSzoXoMBBbEAcyMI612/jmGpIcQ0KSmSXjsaX2 YzeIHt6d5HgVokpmpGttINHYM2r/HvGEX0y7bPBZcVyHTq3MMZLKto31epwZV81ePtU3n1wgt9pFT TZRB4CH4ADKdl2BL5QDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nogCC-005ZPf-3F; Wed, 11 May 2022 06:51:40 +0000 Received: from mail-wr1-f53.google.com ([209.85.221.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nogBs-005ZDx-Hc for linux-arm-kernel@lists.infradead.org; Wed, 11 May 2022 06:51:21 +0000 Received: by mail-wr1-f53.google.com with SMTP id s15so226848wrb.7 for ; Tue, 10 May 2022 23:51:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1wEl4hKP70nqNM7+s33aDLROWITXXzeuUXQCyFgNxKQ=; b=QO/baLR3O0YVlAVG97UI+z0m0VJqD9wqqdmYvfYiwprKoHDKEpF0Ypr17CYv4fAD9x iJIOl6gzAfL1SDBQKVggFEvStm7h1VvRSI5xAwoJ/ESpU9RzUEXiI8pl/5zZakWx/WTb DEm+KmoDu08agtmE9LCiigsAtEI7uOvEXGLvAdg1FieTH3rOzzyhsYUY99AUH2ZkAmZ+ PhRZgEgjMHTRIac+dBlbqFqXNXETTg7UyDTxqb+KZcMednW6JPGmfVYAri9QcFTn/MpS 9j6yKHz79w2FVsP8fp4B/5ncVszJOs1bWTFX8z4utLDoEm/ShLKyEsMR9pt+6gxqFmVF 3fwg== X-Gm-Message-State: AOAM532+s8N4cLH9LuyK5gBXDabuZvtncfujAfdpehX43ESXMrv6/hb2 e6Y8j1mpNDcIGZ/jvA2fDqY= X-Google-Smtp-Source: ABdhPJzvSiFXK+Pkx1A+5Jgez3pwE0NnwYeWyDPJFd2IMdUv3cDPSfUbrL34eucFRES0Ji7AeRNSEg== X-Received: by 2002:a05:6000:144a:b0:20c:6b73:804 with SMTP id v10-20020a056000144a00b0020c6b730804mr21963700wrx.88.1652251877878; Tue, 10 May 2022 23:51:17 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id r5-20020a05600c424500b003942a244f3asm4242899wmm.19.2022.05.10.23.51.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 23:51:17 -0700 (PDT) Message-ID: Date: Wed, 11 May 2022 08:51:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver Content-Language: en-US To: Hitomi Hasegawa , linux-arm-kernel@lists.infradead.org, soc@kernel.org, linux-serial@vger.kernel.org, sumit.garg@linaro.org Cc: arnd@arndb.de, olof@lixom.net, catalin.marinas@arm.com, will@kernel.org, gregkh@linuxfoundation.org, jason.wessel@windriver.com, daniel.thompson@linaro.org, dianders@chromium.org, linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, peterz@infradead.org References: <20220511062113.2645747-1-hasegawa-hitomi@fujitsu.com> <20220511062113.2645747-2-hasegawa-hitomi@fujitsu.com> From: Jiri Slaby In-Reply-To: <20220511062113.2645747-2-hasegawa-hitomi@fujitsu.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_235120_656292_099B9A99 X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11. 05. 22, 8:21, Hitomi Hasegawa wrote: > --- /dev/null > +++ b/drivers/soc/fujitsu/a64fx-diag.c > @@ -0,0 +1,155 @@ ... > +#define BMC_DIAG_INTERRUPT_STATUS_OFFSET (0x0044) > +#define BMC_DIAG_INTERRUPT_ENABLE_OFFSET (0x0040) And I noticed here, I would: * remove unneeded parentheses * drop the "_OFFSET" suffix * just write 8bit values (0x40, 0x44), given they fit * order them numerically, 0x40 goes first thanks, -- js suse labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel