From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 937FFCFC52C for ; Mon, 14 Oct 2024 09:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tPxfM3/+LHt+EmVnzhLr9Fip6ZGfwtZ5p/tUW2SXXpI=; b=ftX1aqe7kVcxnczaehq68UdqOC OeFLjtJDtAZsmMR25RzQn6igx/EqUsu3CwvCRBlSx5CkX15S06sECso6dxj8i+wvxYLFkKXNNDUgN K1/CqtNP8lcwI44/o3ClMJD8IceBvA7J+QHQin/EX4S6bOWLXbctKhmhEJKaE8j+zwqnCGtf+LUqW qBtd8fj5xPvlpOoYxHuHDRrgWHDKFZYVfV582mVk1FLUKccVKFLYNPrHcI3l6OctAhJqYrWqBCyDn DXBd23t5WnjG4kmtUyIUdJfWXnQ+pF2at9l4eM8Sz6I2yuWuExUGAzW2DjwNwb4hy4TkisNPL1zZV 9e74ZI9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0Hjw-00000004bVf-0aF8; Mon, 14 Oct 2024 09:51:48 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0HPu-00000004Wzz-3Emp for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2024 09:31:08 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4305724c12eso30452545e9.1 for ; Mon, 14 Oct 2024 02:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728898265; x=1729503065; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tPxfM3/+LHt+EmVnzhLr9Fip6ZGfwtZ5p/tUW2SXXpI=; b=RNI5fWaSZAsVCxsXgDcDbPsTX2Ivm46B9BQepdRsVhBpwYlVO/j2HaAvmWgSZSAPAG qikpVVG5tPfnd9RJBultt9Gd5gi4VqDvR6xvhinnNyMFlhQGFOTfxUwvX/leWwh2V0Uk FqkZBlVUU+TKsKgTcYmMnVar2uVXD4R1w/KYJIkZJWzxqKAP1J9Zg2vQAdhtzXqAqO7s pD8lKANwfrx15HPY6CcRl8xkPj+7feOFtLN7eT17QC9pAwiLDqDWIUvMZw8BNZUfbn77 i8N9Dr+kbxutlMEjVS4RF+Vt5S+p2GegQUyexfkaYWxo+4MphicQMItx43qinZ2MLrX0 FBbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728898265; x=1729503065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tPxfM3/+LHt+EmVnzhLr9Fip6ZGfwtZ5p/tUW2SXXpI=; b=SGO6hu6mh02dMfB6Pue7Z1x45lVN0Ri/ORNKPnbXyqGqzkcQv2xn12EfUBjYWMKkPF xw/1ksPHNfyqLjWBfkp+dZDDduWEH6c5n4kcBuo/j8FKQhrnu2HRKFiARH991y2G8Dbi q1bAuZoUOcE2D+xPjfDrhBR/uI6Xn+hyr/JsGyajJ1J6oXc+2cUi25LA5c7JmvyZE57Q OGMpkDaGdfr+XJlopzmeYErCL697YW+dQGUUuzvSYHaW89HDSmyrE/CSOFmhwOmJ515R qMcvRf/u3a95XxII2uig+ttwC2PLoKV3ZFwYMZSfaitDEaq9xhIRsEgz6hA68wRR7Liz kM9w== X-Forwarded-Encrypted: i=1; AJvYcCVSHV6P/aMh+EL3NP2pwIfP8QUPsZTMExSgSaLJk4hGn3fxq8t2JX7kEJlj1zF3IsZpLNQJ2U+EW3SA+4VHg53M@lists.infradead.org X-Gm-Message-State: AOJu0Ywm++cKwXGklDboldbzyLIhuZdg2A85JXCH5WeFHv+N6DjNdker HOYALeD2K0U2EqVPnN74zDabCmXiopi75Uadbxwpf/JbR2q7iwOA/mYDMTJqApk= X-Google-Smtp-Source: AGHT+IGJAZ2abLY3A+ePxucwhIPOIPVNEZwYUtaSndGiYueX+Z9ySXWSN9wDAthowcyl1n/MoONv3w== X-Received: by 2002:a05:600c:190f:b0:430:53f8:38bc with SMTP id 5b1f17b1804b1-431255dcb76mr61160315e9.12.1728898264921; Mon, 14 Oct 2024 02:31:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43127a6ae71sm63892235e9.47.2024.10.14.02.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 02:31:04 -0700 (PDT) Date: Mon, 14 Oct 2024 12:31:00 +0300 From: Dan Carpenter To: Javier Carrasco Cc: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Umang Jain , Laurent Pinchart , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node Message-ID: References: <20241014-vchiq_arm-of_node_put-v2-0-cafe0a4c2666@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014-vchiq_arm-of_node_put-v2-0-cafe0a4c2666@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_023106_842576_878199B2 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 14, 2024 at 10:56:35AM +0200, Javier Carrasco wrote: > This series refactors some useless goto instructions as a preparation > for the fix of a missing of_node_put() by means of the cleanup > attribute. > > Signed-off-by: Javier Carrasco > --- > Changes in v2: > - Refactor vchiq_probe() to remove goto instructions. > - Declare and initialize the node right before its first usage. > - Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com > Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter