From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B3D6C61DA3 for ; Fri, 24 Feb 2023 12:30:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6jb1//t36CvFFfyO4XHVko1SGE/Nse0L9ov4+s5VlpY=; b=du1UV2ETdi0IEy bNHoSBxr0whEaJfZxHoO8Pg/g3HyKf+EehFT0gZEtJO94CVQzewsjHn2gdyAVWn3u68QRGPaMVknT /HqUC2EOyAKmB79oiJzXzpV4zBzm4InL2B/R5g0MGE6LF6fotDwz87QiUDnIm41bJ0sQaimD7lREk i9KJM9PAH/K/aLhIPhkSYIwMEe/jDvD43SCs4NwAhRqX03rfzmARcTI/toSoEE3/WhAbFYmY3HAuk KwMILaJlIxCzKlH79UZVRioTUCFBXUernXyU/PQBIlQpCGUC/8sv/axkW6XO3kr7CusSyUrBTC2fB 8BJP/WPoqZD1F+EMaz9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVXCR-002OHw-EO; Fri, 24 Feb 2023 12:29:19 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVXCN-002OGX-SO for linux-arm-kernel@lists.infradead.org; Fri, 24 Feb 2023 12:29:17 +0000 Received: by mail-pj1-x1036.google.com with SMTP id q31-20020a17090a17a200b0023750b69614so2510581pja.5 for ; Fri, 24 Feb 2023 04:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677241753; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bJXP4s/YvViKiDkI4nbGZvqqhmXqSAWSFntwmLVwg+s=; b=g/og4gQoLJEhDfgQMl/nTu6Z7ZqHM77eC/InWYgcK7eH6hy8t0GGKi3GWmrHSSRrCZ cd2HAYa6bukqJStBOCR3ZlHOo7IK0frC6vZnxTvMApy6wl6Bkzjh2IfIMSyB1lL7VQWh d0GbY0JPrYrq11eb/pXPHr9AGuLXs8mnJb2MOx1AQGmsSIY0Kg6EqUkYFJ2Q/7efF2gP +juMHFkQyA2uxpSwU8cbtJDRyPkmzWCHXXB1SlH7dPj7okLu60uhjJVvtNYB7Evj4VBr 3Ge7YKI29lUOz8oxnyC88+D0CV/FAB3GXN8nakMaxtB/vAy7U9FF0dTNydf0BwwhcD8I EHIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677241753; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bJXP4s/YvViKiDkI4nbGZvqqhmXqSAWSFntwmLVwg+s=; b=i8YQg9e2va1vvmU1ipj6TwWu9Cr6xsTvzVj6CS/bg9dzj5ttGSAv5uO+vk3/xDwBXV KvYV9FKlkUUj+UIDTTR++seoY+KviHp5WIM2vLKAAzyM8KtsUMQHRKwVFyq6SbPjwV6u B4i9pmkEfi5YtogLHnBGRmhIuJf7HkYjhRk4CCfPHBmMsylAAZ9lkT1AKEMVp2Me0eOd 5ootI5Mb/iMWF0SJyIFVbT94ha9tI6yLa8vXM9slPJmjFeoKl5fkt5xxULSqCWaLvcQk AhzDv8GdEw6Mipng+UCcASkDh60pcpOcsLnPhpB0ce7QfO/L8kXAmH1Wrk/Ediz72TYk pxWg== X-Gm-Message-State: AO0yUKUKhNyt/mPYSCqDyI+gIMFlxu6c10oqSs6mQo2fMP1GAakOWUBC 3N7Y4Bk6hzO3bFs/5EWa0qU= X-Google-Smtp-Source: AK7set/hA+rvXQ6woDP6nwf2/FlLoD/HcKPhyeCLfGyVUihMSsMpe4oIBBYBfP3tKzW93nmPOmNARQ== X-Received: by 2002:a05:6a20:a004:b0:cc:ca9:4fde with SMTP id p4-20020a056a20a00400b000cc0ca94fdemr7457370pzj.33.1677241752862; Fri, 24 Feb 2023 04:29:12 -0800 (PST) Received: from [192.168.1.39] (M014008005000.v4.enabler.ne.jp. [14.8.5.0]) by smtp.gmail.com with ESMTPSA id i13-20020aa787cd000000b005abbfa874d9sm8015852pfo.88.2023.02.24.04.29.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 04:29:12 -0800 (PST) Message-ID: Date: Fri, 24 Feb 2023 21:28:47 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] ARM: dts: mvebu: add device tree for IIJ SA-W2 appliance To: Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, arnd@arndb.de, olof@lixom.net, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230223132502.2045-1-musashino.open@gmail.com> <20230223132502.2045-2-musashino.open@gmail.com> <76395d89-1c56-12b2-b6f7-e77603019b70@linaro.org> Content-Language: en-US From: INAGAKI Hiroshi In-Reply-To: <76395d89-1c56-12b2-b6f7-e77603019b70@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230224_042915_971357_C8A30FB2 X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, thank you for the comment. On 2023/02/23 23:17, Krzysztof Kozlowski wrote: > On 23/02/2023 14:25, INAGAKI Hiroshi wrote: >> Add device tree for Internet Initiative Japan Inc. (IIJ) SA-W2 appliance. >> >> Specification: >> >> - SoC : Marvell Armada 380 88F6810 >> - RAM : DDR3 256 MiB >> - Flash : SPI-NOR 32 MiB >> - WLAN : 2x Mini PCI-E slots >> - 2.4 GHz : Atheros AR9287 >> - 5 GHz : Qualcomm Atheros QCA9880 >> - Ethernet : 5x 10/100/1000 Mbps >> - Switch : Marvell 88E6172 >> - LEDs : 12x >> - Buttons : 1x >> - Serial : "CONSOLE" port (RJ-45, RS-232C level) >> - port : ttyS0 >> - settings : 115200 8n1 >> - assignment: 1:NC , 2:NC , 3:TXD, 4:GND, >> 5:GND, 6:RXD, 7:NC , 8:NC >> - USB : 2x USB 2.0 Type-A >> - Hub : SMCC USB2514B >> - Power : DC Input or PoE Input >> - DC : 12 VDC, 3 A >> - PoE : 802.3f >> - module : Silvertel Ag9712-2BR >> - Bootloader : PMON2000 based >> - Stock OS : NetBSD based >> >> Image header for stock bootloader: >> >> 0x00 - 0x07: Identifier , ascii, "SEIL2015" >> 0x08 - 0x57: Copyright , ascii >> 0x58 - 0x5b: Checksum (CRC32), hex >> 0x5c - 0x5f: Version Format , hex , 0x00000001 >> 0x60 - 0x63: Major Version , hex >> 0x64 - 0x67: Minor Version , hex >> 0x68 - 0x87: Release Version , ascii >> 0x88 - 0x8b: Xor Key? , hex , 0x00000000 (if not encoded) >> 0x8c - 0x8f: Data Length , hex >> >> example: >> >> Identifier : "SEIL2015" >> Copyright : "ARM OpenWrt Linux-5.15.94" >> Checksum : 0xd575759f (calculated from kernel data) >> Version Format : 0x00000001 >> Major Version : 0x00000009 >> Minor Version : 0x00000063 >> Release Version: "r22151-318ed84c8d" >> Xor Key? : 0x00000000 >> Data Length : 0x35312d33 (length of kernel data) >> >> Signed-off-by: INAGAKI Hiroshi >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/armada-380-iij-sa-w2.dts | 391 +++++++++++++++++++++ >> 2 files changed, 392 insertions(+) >> create mode 100644 arch/arm/boot/dts/armada-380-iij-sa-w2.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index efe4152e5846..19119a3f4f1e 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -1523,6 +1523,7 @@ dtb-$(CONFIG_MACH_ARMADA_370) += \ >> dtb-$(CONFIG_MACH_ARMADA_375) += \ >> armada-375-db.dtb >> dtb-$(CONFIG_MACH_ARMADA_38X) += \ >> + armada-380-iij-sa-w2.dtb \ >> armada-381-netgear-gs110emx.dtb \ >> armada-382-rd-ac3x-48g4x2xl.dtb \ >> armada-385-atl-x530.dtb\ >> diff --git a/arch/arm/boot/dts/armada-380-iij-sa-w2.dts b/arch/arm/boot/dts/armada-380-iij-sa-w2.dts >> new file mode 100644 >> index 000000000000..beeecbb0f5f8 >> --- /dev/null >> +++ b/arch/arm/boot/dts/armada-380-iij-sa-w2.dts >> @@ -0,0 +1,391 @@ >> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT >> +/* >> + * Device Tree file for Internet Initiative Japan Inc. SA-W2 Appliance >> + * >> + * Copyright (c) 2023, INAGAKI Hiroshi >> + */ >> + >> +/dts-v1/; >> + >> +#include >> +#include >> +#include >> +#include "armada-380.dtsi" >> + >> +/ { >> + model = "IIJ SA-W2"; >> + compatible = "iij,sa-w2", "marvell,armada380"; > It would be nice to start documenting the board compatibles, at least > for new boards. So...how do I do that? > > Best regards, > Krzysztof > Regards, Hiroshi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel