From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DF0AC433EF for ; Thu, 5 May 2022 09:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F+z4el7aC32z0XCr2/GdQeeOxOi/NpOO3aoc6N0+LZY=; b=W3giwS7IW5qRke y+WMrgaggLdyFxOilNo4HmcElUiYtdQC6qRbH8wE0SfrgOh7p2k6yCtAq8UL2ELGbs0yUSYGBQqV8 KokTAnc56EOePrKwaivZHwv9TKSoDLE5QW43Tn4k2964dYcKOrYl6Muu4hHBs2cNBLR+YOl+0ZzbO CHV4tzBSNRu3+/Dy2nxXy9P4hHtAowT0FJgWOBIkYRjqryeVr7CS0ikScYYhnx2swZ9Vn/lhX/XCF 3qwiqjFtGNNEbsYeHCGDZX5JA9B5iggsxbYTXn5RUP+8Ljuvq9OdenAR5yVercVYS45s4+46XrNxM 44QfayH8Dxdrew3X8lUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmXi0-00F0Pn-MM; Thu, 05 May 2022 09:23:40 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmXgn-00Ezf2-0m for linux-arm-kernel@lists.infradead.org; Thu, 05 May 2022 09:22:26 +0000 Received: by mail-wr1-x430.google.com with SMTP id k2so5257443wrd.5 for ; Thu, 05 May 2022 02:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YZkhX8VdSbRZKmQIOzgkSfpmToAIJcyGhKGvONZeKPM=; b=wgm3Tdzap7kkOBihTP6T0IhnT9G6Oc8Ge/5nUNlrSnTPInQoGJ98CKanFTwb6sMccZ 9d4KCxdg9LCYphRKvE9rvwU1++xkoof4loKmHyCYfxAY0gBFhMA3oPXw7NTjEqqxyHfC cNwAxA8oRijMoUjff4ROoa9YilWt5ieCB4F7ZaDx7bZ5NBlRq1XEjDizZ9ItDHbBrDJw rdCoDCQ1En6Y5bGPfqpHlZRcg2m4vS6Y/g4KRAX51Favpx55TneHi7u6O0EF4FPDa2B0 NZ6FEyOLhsL2fcnruWZj5H0x5LOeT1KGIGqo+XJU4paF90d6jjbgSv1wgUCBUHYfU45r HmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YZkhX8VdSbRZKmQIOzgkSfpmToAIJcyGhKGvONZeKPM=; b=68Ozyex2FVpI0SptWc1CG3HFhQBV+5D8WbeF4mR6CSEhDGQYX3mvD3TbyOD4+MVqVN hnXmoiIS6sDraMjRvRbbNnFkAnfk1SxaWvemQsD/PO7nMTlngDOxL4LICFlRqaEyC4tM AA7fdZZe7Inu0xW5ZZrNf87CNnkdWKvgpopUYfj5M6ZbWfTCn/0o4xd+dpxoVdBglNDk ve6n1NnFYUaSbxqnSt7+haZRhq421W9HV3T0UZR5jhNGUgXhPxircwaNYzHSy5fYyBvI mF9aIazckwRBVfNAvwZm9pA6BlDjeAY0ZsDqcndyS6apr41qGS2/XQkg7eX8LbQixyiZ INDg== X-Gm-Message-State: AOAM531wrxKqp4ewnbQ0berfncPZVSKA07vZ2mXOxJscd18HzpKBbIJn Xt7gr8QXf/ZZyiqNwNOkLeL+Dg== X-Google-Smtp-Source: ABdhPJwfam1b9VUuK2KiSROtjJ68KFyfCyHnaJU4kSRx96x9vSh8DG8UHpeSy1pcGwoX3pIR2XLwyg== X-Received: by 2002:a05:6000:1110:b0:20a:e113:8221 with SMTP id z16-20020a056000111000b0020ae1138221mr19276809wrw.271.1651742541836; Thu, 05 May 2022 02:22:21 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id o9-20020a5d4089000000b0020c5253d8d2sm779379wrp.30.2022.05.05.02.22.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 02:22:21 -0700 (PDT) Message-ID: Date: Thu, 5 May 2022 11:22:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board Content-Language: en-US To: frank-w@public-files.de, Vladimir Oltean Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Matthias Brugger , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20220430130347.15190-1-linux@fw-web.de> <20220430130347.15190-5-linux@fw-web.de> <20220504152450.cs2afa4hwkqp5b5m@skbuf> <20220504154720.62cwrz7frjkjbb7u@skbuf> <313a5b2e-c571-a13f-3447-b1cd7200f4c9@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_022225_160339_E610D5B8 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/05/2022 11:06, Frank Wunderlich wrote: >> You can make it "(ethernet-)?ports" as well. My comment was purely to >> make it simpler, for bindings (goes into properties, not >> patternProperties) and for us. If you prefer to keep it like DSA core, >> also fine. > > Ok, i'm also thinking, the dsa-definition will be the right way (pattern-properties with optional "ethernet-") in binding. > > Should i use "ethernet-ports" instead of "ports" here? Current dts with mt7530/mt7531 switches using "ports" so i would use it here too. If dsa prefer ethernet-ports now it should be changed in other files too. I think bindings allow both, so choose something consistent with existing DTS sources. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel