From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B7C0C433F5 for ; Tue, 22 Mar 2022 17:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vDfTcnMcWvsUxHKVZ3yHPibysWS+vtJzBjMaT/O/lIo=; b=O4NGPN0Wb1DqF7 nikAH/xSe8hhYrQ6IhSAY2dkYcB6vfaUVHPHaXwDbeILn/JLEQlTOIBkqD3/dWn/f2t/uo4YE1XDz YcwoW8TyEjR3XZK8+BVMfWK7HkzF0VUVr8mZI7xdFErDKVreYobQ48G9nOeCi5NunRSbGHA3LEUHL ZYhbFzU4QF2fRSg+rwgVhKSpignDFOCXfcWbiQa5XHaWIhbuV+hMXeyLmHuJ5MjzW5KkWhqzYSmzU i1wATKWCIcOS4t5szZKYLlC7EJRd+Lw3K4DXbSunYlpYOsESkrKpRPcx8lt9NrQP3leE6CGy+TS+I EvKGLtEbVJQR00jtbYZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWiVX-00Bl2f-HJ; Tue, 22 Mar 2022 17:41:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWiVU-00Bl0a-Fo; Tue, 22 Mar 2022 17:41:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 12D631042; Tue, 22 Mar 2022 10:41:18 -0700 (PDT) Received: from [10.57.43.230] (unknown [10.57.43.230]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CE0043F66F; Tue, 22 Mar 2022 10:41:15 -0700 (PDT) Message-ID: Date: Tue, 22 Mar 2022 17:41:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 5/9] soc: apple: Add RTKit IPC library Content-Language: en-GB To: Arnd Bergmann , Sven Peter Cc: Hector Martin , Alyssa Rosenzweig , Rob Herring , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Marc Zyngier , DTML , Linux ARM , Linux Kernel Mailing List , linux-nvme@lists.infradead.org References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-6-sven@svenpeter.dev> From: Robin Murphy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_104120_603998_692EDBEC X-CRM114-Status: UNSURE ( 8.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-03-22 13:13, Arnd Bergmann wrote: >> +#define rtk_err(format, arg...) dev_err(rtk->dev, "RTKit: " format, ##arg) >> +#define rtk_warn(format, arg...) dev_warn(rtk->dev, "RTKit: " format, ##arg) >> +#define rtk_info(format, arg...) dev_info(rtk->dev, "RTKit: " format, ##arg) >> +#define rtk_dbg(format, arg...) dev_dbg(rtk->dev, "RTKit: " format, ##arg) > > I generally don't like the custom printing macros, please just open-code > the prints where they are used, that makes it easier for other kernel > developers to see exactly what is being printed More to the point, implicitly depending on having something named "rtk" in scope is pretty much inexcusable, and the only thing left after fixing that is what we have pr_fmt for ;) Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel