From: hkallweit1@gmail.com (Heiner Kallweit)
To: linux-arm-kernel@lists.infradead.org
Subject: Small issue with 3fde2999fac5 "arm64: cpufeature: Don't dump useless backtrace on CPU_OUT_OF_SPEC"
Date: Mon, 5 Jun 2017 11:37:35 +0200 [thread overview]
Message-ID: <e9f35f1c-fe40-2c08-f47b-e4275b6cbcaf@gmail.com> (raw)
In-Reply-To: <20170605092438.GE4650@leverpostej>
Am 05.06.2017 um 11:24 schrieb Mark Rutland:
> On Mon, Jun 05, 2017 at 11:20:53AM +0200, Heiner Kallweit wrote:
>> Am 05.06.2017 um 10:48 schrieb Mark Rutland:
>>> Hi,
>>>
>>> On Sun, Jun 04, 2017 at 02:53:36PM +0200, Heiner Kallweit wrote:
>>>> The warning is printed unconditionally. An "if (taint)" seems to be
>>>> missing.
>>>
>>> I'm not sure I follow. We're using pr_warn_once(), which should only
>>> print the message once, regardless of how many times it is called.
>>>
>> Before we had WARN_TAINT_ONCE(taint, ..), so the warning is
>> triggered by taint != 0.
>> Now the warning is printed (just once but) even if taint == 0.
>
> Ah, I see.
>
> Thanks for the report; I'll put together a fix shortly.
>
> Do you mind if I add:
>
> Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
>
Fine with me.
Rgds, Heiner
> ... to that patch?
>
> Thanks,
> Mark.
>
next prev parent reply other threads:[~2017-06-05 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7f8ade0a-c4ab-3e2e-d21e-8eab4df07cac@gmail.com>
[not found] ` <20170605084840.GB4650@leverpostej>
2017-06-05 9:20 ` Small issue with 3fde2999fac5 "arm64: cpufeature: Don't dump useless backtrace on CPU_OUT_OF_SPEC" Heiner Kallweit
2017-06-05 9:24 ` Mark Rutland
2017-06-05 9:37 ` Heiner Kallweit [this message]
2017-06-05 10:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f35f1c-fe40-2c08-f47b-e4275b6cbcaf@gmail.com \
--to=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).