From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B562CD37B4 for ; Tue, 19 Sep 2023 03:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L0vM5zcvRVwgIEAGf7E7kWKibqWg/Xa64EnTLBJS65g=; b=a/ik2+tQqmJu5G wbZKF7EbodGbDF0hWcIDTcbqErzKG2Z6LpY+M3xOezEwKKWhB6gFW/ckLwEeQ4+JJhrw8pHZtX7Tu O73/a9zLKXpU7tCDL45FcwOUISA7PWUcskp4ZRqRGotKgOnlG5Z3c9rOAhaKRelzPGEVkQTFSrwon 3JGsFHinaxv2/gUWGm8K2va+rog9BZVRK9t+RuHwt7PXePwx89rB35gDFnvl0A/cYuO2nCg/Ah1jn Mz84x8z6DUoINaLFqTgruVhcJut53bQ/lJ6d28L6WfTgaDGktx/gkBtStGq63cZucByuzoKygi598 hCHL0JwMrtMksnd1RCNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiRoR-00GqiK-1V; Tue, 19 Sep 2023 03:54:11 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiRoO-00Gqfd-1Y for linux-arm-kernel@lists.infradead.org; Tue, 19 Sep 2023 03:54:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695095647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=opGMZb4zVfpw4j3bwF+zyk+VH4LC+VDK5rPEHS4VpxU=; b=izEHEpmnn7a0TpROM4XLYPJ0B984kOdJq/2W15A+l1aQrPYrNDzvX+rJekFNuOn8m+nFnM CvO/li9oaeGlUNKcsyUWO+YjZRrJ6PVqk5O00NThV8VUcpQNv2NSf5Louct+0b7jlxjhy+ qeazz8Zyr0DLnRm0yJQCs4QzKt9TxgI= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-tfVqCKcYOMKHogi066fsxA-1; Mon, 18 Sep 2023 23:54:04 -0400 X-MC-Unique: tfVqCKcYOMKHogi066fsxA-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3adb6858aaaso5983659b6e.2 for ; Mon, 18 Sep 2023 20:54:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695095644; x=1695700444; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opGMZb4zVfpw4j3bwF+zyk+VH4LC+VDK5rPEHS4VpxU=; b=QxpyIkjy1ZKpp3bwf66TH3rC8rVDyC9+7UhcQuB1LVRwjYaYh2XzcuhUDKaC3Fa4xW AfB5g/ITVJrqvoPSlxMQTZHokFSjK2d9kOR73r2wvvggFz9z2L97JjaJtksy43GBs38b i16hjnJMVL6235LnkNmAW+ryKU47WtQSzmm8AyJsxQjJQ/A6mtzJmRqHFjwfP1h7WGF7 jqIaGEDp8AYYqMlbfobu/CANLLPVKYxVJOCo7VO3kWe7TR2sk9cdJrIBqVxQusbJ1v8x uUi+bGzUfCg0WERJb1dtsOByhZMPHbHZBqqpuZnpG/Xwqu9nio53dkyo7iWp18zi65Aj tlAg== X-Gm-Message-State: AOJu0YzoTMFLKofX6suhwy7GJ7WQwItscVcKuI1YOZjKCm2rmW3EthyW 2L8gYM/EHn4NDkZgUqADl7KCZHW9IDbYpb6BhwKU00JdqwJgk8LpsGtKHg2zTzTpEKqi5NIEXBK NoUQIgyAxzWAGM0419ZPbNEkMEhZYtruHNg0= X-Received: by 2002:a54:4504:0:b0:3a3:76c6:a46f with SMTP id l4-20020a544504000000b003a376c6a46fmr12922331oil.38.1695095644171; Mon, 18 Sep 2023 20:54:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGYlj7TJDnGHj/RWXEc2C+lTOzyiwCCuIn5mHVU8DsjC6vooAlJ9Xs3Gr3phqs2j6qI73HUw== X-Received: by 2002:a54:4504:0:b0:3a3:76c6:a46f with SMTP id l4-20020a544504000000b003a376c6a46fmr12922314oil.38.1695095643929; Mon, 18 Sep 2023 20:54:03 -0700 (PDT) Received: from ?IPV6:2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5? ([2001:8003:e5b0:9f00:dbbc:1945:6e65:ec5]) by smtp.gmail.com with ESMTPSA id s5-20020a17090a948500b0026b3f76a063sm7639370pjo.44.2023.09.18.20.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 20:54:03 -0700 (PDT) Message-ID: Date: Tue, 19 Sep 2023 13:53:56 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH v2 30/35] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs To: "Russell King (Oracle)" , James Morse Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com References: <20230913163823.7880-1-james.morse@arm.com> <20230913163823.7880-31-james.morse@arm.com> From: Gavin Shan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_205408_588701_7D6A421F X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/14/23 18:10, Russell King (Oracle) wrote: > On Wed, Sep 13, 2023 at 04:38:18PM +0000, James Morse wrote: >> static inline bool acpi_gicc_is_usable(struct acpi_madt_generic_interrupt *gicc) >> { >> - return (gicc->flags & ACPI_MADT_ENABLED); >> + return ((gicc->flags & ACPI_MADT_ENABLED || >> + gicc->flags & ACPI_MADT_GICC_CPU_CAPABLE)); > > ... and this starts getting silly with the number of parens. > > return gicc->flags & ACPI_MADT_ENABLED || > gicc->flags & ACPI_MADT_GICC_CPU_CAPABLE; > > is entirely sufficient. Also: > > return gicc->flags & (ACPI_MADT_ENABLED | ACPI_MADT_GICC_CPU_CAPABLE); > > also works. > vote for the second one, which is: gicc->flags & (ACPI_MADT_ENABLED | ACPI_MADT_GICC_CPU_CAPABLE) Thanks, Gavin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel