From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: Jianfeng Liu <liujianfeng1994@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de,
iommu@lists.linux.dev, jgg@ziepe.ca, joro@8bytes.org,
kernel@collabora.com, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, mchehab@kernel.org,
nicolas.dufresne@collabora.com, p.zabel@pengutronix.de,
robh@kernel.org, robin.murphy@arm.com
Subject: Re: [PATCH v9 3/7] iommu: Add verisilicon IOMMU driver
Date: Fri, 12 Dec 2025 09:51:50 +0100 [thread overview]
Message-ID: <ea3241f1-14a4-44a0-9d85-3fa2a2f6f1ae@collabora.com> (raw)
In-Reply-To: <20251212033157.3036182-1-liujianfeng1994@gmail.com>
Le 12/12/2025 à 04:31, Jianfeng Liu a écrit :
> Hi,
>
> On Thu, 11 Sep 2025 17:57:13 +0200, Benjamin Gaignard wrote:
>> +#ifdef CONFIG_VSI_IOMMU
>> +void vsi_iommu_restore_ctx(struct iommu_domain *domain);
>> +#else
>> +static inline void vsi_iommu_restore_ctx(struct iommu_domain *domain) {}
>> +#endif
> After applying this patch to v6.18, I get error when building this driver
> as module:
>
> drivers/iommu/vsi-iommu.c:541:6: error: redefinition of 'vsi_iommu_restore_ctx'
> 541 | void vsi_iommu_restore_ctx(struct iommu_domain *domain)
> | ^~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/iommu/vsi-iommu.c:31:
> ./include/linux/vsi-iommu.h:18:20: note: previous definition of 'vsi_iommu_restore_ctx' with type 'void(struct iommu_domain *)'
> 18 | static inline void vsi_iommu_restore_ctx(struct iommu_domain *domain) {}
> | ^~~~~~~~~~~~~~~~~~~~~
>
> I have to use:
> #if IS_ENABLED(CONFIG_VSI_IOMMU)
> instead.
I have fix in my internal v10 branch:
https://gitlab.collabora.com/linux/for-upstream/-/commits/verisilicon_mmu_v10
I don't plan to send this update because that will change nothing about code duplication remarks.
Thanks for the report.
Regards,
Benjamin
> Best regards,
> Jianfeng
>
next prev parent reply other threads:[~2025-12-12 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 15:57 [PATCH v9 0/7] Add support for Verisilicon IOMMU used by media codec blocks Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 1/7] dt-bindings: vendor-prefixes: Add Verisilicon Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 2/7] dt-bindings: iommu: verisilicon: Add binding for VSI IOMMU Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 3/7] iommu: Add verisilicon IOMMU driver Benjamin Gaignard
2025-09-12 11:47 ` Jörg Rödel
2025-09-12 12:33 ` Benjamin Gaignard
2025-09-12 17:37 ` Nicolas Dufresne
2025-09-12 18:32 ` Jason Gunthorpe
2025-09-13 5:58 ` Jörg Rödel
2025-09-15 22:58 ` Jason Gunthorpe
2025-09-16 8:48 ` Will Deacon
2025-09-16 9:30 ` Benjamin Gaignard
2025-09-16 13:02 ` Jason Gunthorpe
2025-12-12 3:31 ` Jianfeng Liu
2025-12-12 8:51 ` Benjamin Gaignard [this message]
2025-09-11 15:57 ` [PATCH v9 4/7] MAINTAINERS: Add entry for Verisilicon " Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 5/7] media: verisilicon: AV1: Restore IOMMU context before decoding a frame Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 6/7] arm64: dts: rockchip: Add verisilicon IOMMU node on RK3588 Benjamin Gaignard
2025-09-11 15:57 ` [PATCH v9 7/7] arm64: defconfig: enable Verisilicon IOMMU for Rockchip RK3588 Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3241f1-14a4-44a0-9d85-3fa2a2f6f1ae@collabora.com \
--to=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=liujianfeng1994@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox