From: ezequiel@collabora.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler
Date: Wed, 26 Sep 2018 19:31:22 +0200 [thread overview]
Message-ID: <ea4d539ecbaf229bef8c0810c6a11cf824339b4b.camel@collabora.com> (raw)
In-Reply-To: <20180925112930.u5kftmo3vhmdxji4@8bytes.org>
On Tue, 2018-09-25 at 13:29 +0200, Joerg Roedel wrote:
> On Thu, Aug 30, 2018 at 07:28:32PM -0300, Ezequiel Garcia wrote:
> > Printing verbosely via WARN macros and friends in interrupt handlers
> > is strongly discouraged. Drop them and use proper ratelimited
> > prints.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> > drivers/iommu/rockchip-iommu.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
>
> This doesn't apply cleanly to v4.19-rc5, can you please base the patch
> on that tag, add the Reviewed-by and re-send?
>
Well, after looking at the latest code, now I'm wondering why Marc
changed the WARN_ON with a WARN_ON_ONCE, instead of a less verbose
ratelimited print.
next prev parent reply other threads:[~2018-09-26 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 22:28 [PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler Ezequiel Garcia
2018-09-10 14:14 ` Heiko Stuebner
2018-09-25 11:29 ` Joerg Roedel
2018-09-26 17:31 ` Ezequiel Garcia [this message]
2018-09-27 8:10 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea4d539ecbaf229bef8c0810c6a11cf824339b4b.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).