From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1643C43331 for ; Mon, 11 Nov 2019 14:14:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B81E72196E for ; Mon, 11 Nov 2019 14:14:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t3Cb1Iic" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B81E72196E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xMUsTrVMP25EGrY51/MLt3/MSOinorFHxtn43TtUL6w=; b=t3Cb1IicZguzXtjUWt500dBiB Vzi9elYcuSq4bfxCENX8+Z3N+mjLxRpCeo9eIkzK/YEkp96njdWySVJzHopxxXl1MefX3ccHCV5gq zsAiYsO2nMatZ6PXUO1ZfM+sJkFIi3hj43v3ZQgSKRLH1LqDi68gUxY2Cj3mj/zrBs1pPY4gaiIpK aqVLCVnG1Y3ury586UE+KiNsM8PPwKpssyQaqlOFe5wh2HjKjQh1VPwXMB6hIuMG4DnkKUgfydXHh pmZiDg7aR2uUnP8u9zR4704UVucDgTmWQf/JcxlVmDz8IIrng8vHgk5WAJyaT0BsXNfpX0/TedKG0 p2I2Ps++A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUASu-00057c-D0; Mon, 11 Nov 2019 14:14:48 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUASr-00056Y-A1 for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 14:14:46 +0000 Received: from lhreml708-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 36B1291DAC2EB7F3BE6C; Mon, 11 Nov 2019 14:14:43 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by lhreml708-cah.china.huawei.com (10.201.108.49) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 11 Nov 2019 14:14:42 +0000 Received: from [127.0.0.1] (10.202.226.46) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 Nov 2019 14:14:42 +0000 Subject: Re: [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE To: Anders Roxell , References: <20191111085956.6158-1-anders.roxell@linaro.org> From: John Garry Message-ID: Date: Mon, 11 Nov 2019 14:14:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191111085956.6158-1-anders.roxell@linaro.org> Content-Language: en-US X-Originating-IP: [10.202.226.46] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_061445_493976_5EC2FC2E X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/11/2019 08:59, Anders Roxell wrote: > When building allmodconfig KCONFIG_ALLCONFIG=$(pwd)/arch/arm64/configs/defconfig > CONFIG_CMDLINE_FORCE gets enabled. Which forces the user to pass the > full cmdline to CONFIG_CMDLINE="...". > > Rework so that CONFIG_CMDLINE_FORCE gets set only if CONFIG_CMDLINE is > set to something except an empty string. > > Suggested-by: John Garry > Signed-off-by: Anders Roxell > --- This looks ok. Were you also going to propose a patch to introduce a LITTLE ENDIAN config option? For me, this would mean that ACPI module is built for allmodconfig, which is a good thing. Thanks, john > arch/arm64/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 50df79d4aa3b..64764ca92fca 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1629,6 +1629,7 @@ config CMDLINE > > config CMDLINE_FORCE > bool "Always use the default kernel command string" > + depends on CMDLINE != "" > help > Always use the default kernel command string, even if the boot > loader passes other arguments to the kernel. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel