From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05676C2D0A3 for ; Fri, 30 Oct 2020 00:24:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 752A820709 for ; Fri, 30 Oct 2020 00:24:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DFfOEN40"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CivX32qk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 752A820709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0gz1Zh4CGNSIwiR73hpqvBGnoXPSs6RKLzArbEkhYE8=; b=DFfOEN40ft8haKcXScrFWooHO KPv+nUjRIyJXlUVnE8jj6k7o+012f7fS+bDnq4Eu7sLAEFIzuAUjSceI48Qf+4a7flmgJQkDB3hr9 7dDaZpgws1JQZsG2xjGdZBsgyoEPFRi6wSVkFZUOwL9xVSpK/mlTqH60F5uFSehf28YmMcBAPyRAU 196MIHKeaAdHFS9rpt5/TDC1UerSKLvvrrOOm9a6h6U9JgU1akklmjGHUdZjxK3fP6ttyjSkZVE7S DmzqWOaBHfwSTCyqXKU22fByfU5BVg0PPD6s0FqRFuNoRp7URluTea6aVW8zrMf1FFqvYqbHFMWsx qSF+AJBnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYIDC-0004FU-Qs; Fri, 30 Oct 2020 00:24:10 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYID9-0004F1-Vf for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2020 00:24:09 +0000 Received: by mail-wm1-x344.google.com with SMTP id c18so1410417wme.2 for ; Thu, 29 Oct 2020 17:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version; bh=YNnS/YJ8N68iSv5kAg6sby1XsShG2der/Nd+Gj+mfF0=; b=CivX32qk/16ZNURBt9IvEAJLVp9ocD0cjIraI1IgqtCBnHKrETuEE8b9z7FHllGN9G NruVN9SHRF9SqsFLGbngQe0IEMgx8SfxLNxI9nzrpnWgxUdNR5VrvvspsTMEcTxDdraQ MCvF/naKu9joUTeuzSF8JKWNcrOrY6uy2n7J/RPgrdIEo2IJJpHtWVSSQ2ofmCXRvGOY lRMZI202tB+v6siUol3ikZUkGmSccEslkB6POspQy31FzdYrHNQpn/ftMPZ0gGFqVthc pAw8PZrq35nWJmh8DdoZudLQ9fmdK4rG9yavTuYbRmQ3Z+0MuCDNRgYKU2NGxfLTryDa fDBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=YNnS/YJ8N68iSv5kAg6sby1XsShG2der/Nd+Gj+mfF0=; b=MaT8OApfWDC9YzWK6Z4qiHwWhsSk+r4JjFz3UrHgeLe63dgsVKDEjco8WKbJWXcwm9 SmlReq/NwQxsQc4lbfL4WsYbmI+g7OwlJ4YZLnPMYqOrDERkzn6LTgIAkbQH22fDSbyV /rFj3QMJ0u9tQMlwlQ6msZM/TF+WhztqvByf3iNgRWkWYTbcsbaW3rkTlkn6WcurjBMM 4VcMvIpyJlK6FJjSSM30qy3U2zidi3xOEJTePHiGb2/MfiUX4+cBrbZgrau5ia0gFSXf l2rdA75WkLPwY8vQ7zvBc72iC4jySpJnkYbddZ/2FjRekAecKldmYKXw3fCiNWEVPVTL uaKw== X-Gm-Message-State: AOAM5338EwfLCMcd3dm3/bSHybfjsM3tRKt5kFCo2NmvkE66ahRCtlNc CeDL1UsC5gX7MZBOF5ufxwc= X-Google-Smtp-Source: ABdhPJykU410uCBLhAxx/6xgrGbuEhezzDnikW1Bqxhhpj8F9LTDf/kRfmfW+bINtbHZjCBSq1hpnQ== X-Received: by 2002:a7b:c055:: with SMTP id u21mr1871895wmc.27.1604017446878; Thu, 29 Oct 2020 17:24:06 -0700 (PDT) Received: from matteo-xps-15-9560.lan ([2a01:4b00:a40c:9900::14e]) by smtp.gmail.com with ESMTPSA id p4sm8423149wrf.67.2020.10.29.17.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 17:24:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings From: Matteo Scordino To: Icenowy Zheng , Maxime Ripard Date: Fri, 30 Oct 2020 00:24:04 +0000 In-Reply-To: <92612D42-FF4C-450C-ADB1-A220B94838CB@aosc.io> References: <20201029022000.601913-1-matteo.scordino@gmail.com> <20201029022000.601913-5-matteo.scordino@gmail.com> <20201029101304.yja4m747pc62re34@gilmour.lan> <92612D42-FF4C-450C-ADB1-A220B94838CB@aosc.io> User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_202408_217551_DFDC3F35 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Kocialkowski , wens@csie.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1626184617202743409==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1626184617202743409== Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-evPyYgMHR665r73TzY1g" --=-evPyYgMHR665r73TzY1g Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, thank you both for reviewing. I didn't realise the file was kept in alphabetical order, I will fix that. And I agree that board/som + "sochip,s3, allwinner,sun8i-v3" makes sense, I will resubmit the patch with those (and sync them with the dt bindings fi= le). Should I submit a patch to update the pinecube to use "sochip,s3, allwinner,sun8i-v3", too? --=20 Matteo Scordino On Thu, 2020-10-29 at 18:24 +0800, Icenowy Zheng wrote: >=20 > =E4=BA=8E 2020=E5=B9=B410=E6=9C=8829=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D= =886:13:04, Maxime Ripard =E5=86=99=E5=88=B0: > > Hi, > >=20 > > On Thu, Oct 29, 2020 at 02:19:59AM +0000, Matteo Scordino wrote: > > > Document board compatible names for Elimo Engineering Impetus and > > Initium > > > Signed-off-by: Matteo Scordino > > > --- > > > Documentation/devicetree/bindings/arm/sunxi.yaml | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml > > b/Documentation/devicetree/bindings/arm/sunxi.yaml > > > index 0f23133672a3..55405809ec91 100644 > > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > > @@ -898,3 +898,13 @@ properties: > > > items: > > > - const: xunlong,orangepi-zero-plus2-h3 > > > - const: allwinner,sun8i-h3 > > > + > > > + - description: Elimo Engineering Impetus SoM > > > + items: > > > + - const: elimo,impetus > > > + - const: allwinner,sun8i-s3 > > > + > > > + - description: Elimo Engineering Initium > > > + items: > > > + - const: elimo,initium > > > + - const: allwinner,sun8i-s3 > >=20 > > This should be ordered alphabetically, and most importantly, must match > > the ones you have in the DT. > >=20 > > Here, we have kind of a mess already: the Lichee Zero+ uses > > ,sipeed,lichee-zero-plus, sochip,s3, allwinner,sun8i-v3, while the > > pinecube uses pine64,pinecube, allwinner,sun8i-s3 > >=20 > > IIRC the S3 and V3 are pretty much the same SoCs, so the first one > > seems > > to make more sense to me, but then we should fix the pinecube. >=20 > I agree with this. >=20 > PineCube is originally designed for S3L (which is branded under Allwinner= ) > but switch to S3 finally, so I may made error when adapting. >=20 > > Maxime --=-evPyYgMHR665r73TzY1g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEzO0zAuXCENUlBKYqFH4A68XNhRoFAl+bXSQACgkQFH4A68XN hRpM5Q//UJnI+IjrtmbNAAyPAySRteRqbEWgk/NBsrxGZdwPpvPmhlKfDYYj3H4X 96z1CiSbWqiiQtCWOvfySYMAi4wjsmqiGMX9d2Ip/TWXtGUSQEciyrbnEY73tuo5 yWsNK1xWkjpnGS4YB/ZTRxW+f7XKene6HJkLzDojtAnGTac05QRcMV3Irzu4fT7c zvnBr0Ezikv+//UC7hx6y7wQjBZr/PbMwzm+RySEAwHkTcUh8Wg+jY0Mow++rh1Z foj776Zylu1lUYWDKHEBqbOLLLq+yA8668guRB07YTF5niewS7OIQT3FNwfL89A1 0ci56X/iC6Kh+zRrIlqEcNZEPQGUj/Rw04qMeCAVRwjd+4ouXUh66G5B97kBcINJ rzHHpotOXjyBMzwllPtF2K0OUHrwGVagH4QdWn/axO94LpztHsoJjoz2y1qteLkP bmkb/o17YrjkXen/9xmLn4MX7Xisvb2VdCAiRknThHSCQC7rHWBVnkISQZ18nBvf t0r3ZT8FQY801XT4sDea1FKPe9xsZSUn0Wfyh+VP3w/vFTCNoAWYsHvVMskXwHL3 alKyS+9LX0EGyvuGVxP0SXvvQUP7tXQijFbUHmv/cMOTboloC3S8kJFnULeOhjH4 NDZls4IfI9SskgahlBNr0jWHg4OOuWUy1VmMnluEmAET0HrLTLU= =LOmK -----END PGP SIGNATURE----- --=-evPyYgMHR665r73TzY1g-- --===============1626184617202743409== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1626184617202743409==--