From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC5AAC433FE for ; Tue, 18 Oct 2022 22:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0UDhwG/rqTKWpuF7SnfmHQ0QJRSCPVTEHG/5WNMxRR8=; b=0zQwizF+sOAwO+ AR6rY20EbJzDrtzi6HS2kTtSmBz/26x20nlnEPaRAavvm+nWqJitmdEK/bEPfbrlYSot7nWU/xhp/ WjB70TMbDiJv4SY34HoxmLAaNkBOeA8857yZfcwEDd6gXXNbghvNCoKP1hwC8bKsnZFDFoa1FZH1z BkbG3wwTj5rn+EjmWchVbY3fsOWemPwffedKt3Woah1fhuyGkg4Zwx628eB4S3zYLdLFSYCDpbn+g BrFzGMUQDh3xf9sVyAl2I84xTk/ixp/+1ISpVQhxVSgRkk7f9AD9bQ4pZkT9l31gchqiDZ9tiJfiT 5HwYBARD68yEun9ENopg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okvNv-00Amz2-8X; Tue, 18 Oct 2022 22:48:31 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okvNr-00Amwy-9H for linux-arm-kernel@lists.infradead.org; Tue, 18 Oct 2022 22:48:28 +0000 Received: by mail-qk1-x72f.google.com with SMTP id x13so9657453qkg.11 for ; Tue, 18 Oct 2022 15:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r716SRHBKmkP3qcelLf9VHB+ss3pbVtG1Zz1sth3Kz4=; b=FKlbYirZbdggfPnP1oGaG/KAerGXG4jpPPd6+bR/4Sg8R0i/VUFh6x/+7+qbvvRwcH 8sq9scVVtUSgRyGmmYHVX6gHDCIvCLWjzV9q+Lnd76UhPn2G/2F8Dct4pmSl1NATbbPh fN1FEbT4wc0l55Ull6zAaDXUJhvirI5EWmvpKqjShm5OQSAgXO4dqoiBldgDATvDnhXX hjm2v4pFXrqrQw+53K+PBQApgr8xUSl5e8Avh3aZ0s+/12vXPS6Ii+f0NUvmUbKeyt6K oeohkn/guD+EW5GQM9EGQJMlPij5BByt5Xws81PqeuOIX1LmuP0k9RkPkk2utG/WDHgG TpmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r716SRHBKmkP3qcelLf9VHB+ss3pbVtG1Zz1sth3Kz4=; b=vQFr/uXdAhtpFkm8v2qdvZu09zDt/TIE5XstoS1XGZXpUcuddNRlXR421Sd4vCK3yX affPh4XZ5htRkUy8DzH336XgR2KbZtcIkwBxia/yz6ORnTdlg8eBo3/q7F7DvuHa9AoR ETg8cndSatG65/of+dSJPcaaX4O8jW9YYfObsBscklMbMPFNam1fkZKasyJQ2OE8xlzo A+OmierjJ0refeL8PjTsfjdhJbMFYDmXDjzI+NqcDacKmchDIVfwiVVIHOBErHFQaKK7 6hFwjUJDFkhwV6/UZ2ac503C9ZdPO8Tf8qJP1dEqgtq3kx7vIbyKI7lizrI7bmclM+L/ QPQQ== X-Gm-Message-State: ACrzQf1weTwVAzQeaq6kz8LEcwE8Gj1OkBVFlNU9KZAwSOdz6flu8efd +L6oPntW9FMu2XDBDKEXEx/i1w== X-Google-Smtp-Source: AMsMyM7GWOAh/usAUDi3Z/NxhkUOWMFRb8/IJfQOZj9WHUhN+rG07rZbx6jhEt3kknrGcFTcf+vLyQ== X-Received: by 2002:a05:620a:4449:b0:6ce:d824:d2e2 with SMTP id w9-20020a05620a444900b006ced824d2e2mr3548607qkp.183.1666133303238; Tue, 18 Oct 2022 15:48:23 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id z15-20020a05622a124f00b0039a08c0a594sm2731895qtx.82.2022.10.18.15.48.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Oct 2022 15:48:22 -0700 (PDT) Message-ID: Date: Tue, 18 Oct 2022 18:48:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] arm64: dts: k3-j72*: correct compatible for syscon entries Content-Language: en-US To: Matt Ranostay Cc: vigneshr@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20221012180052.89840-1-mranostay@ti.com> <0118faac-7d50-ddb2-2914-0610b83efe6c@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_154827_381883_2C14B72B X-CRM114-Status: GOOD ( 16.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/10/2022 04:09, Matt Ranostay wrote: > On Thu, Oct 13, 2022 at 09:05:11AM -0400, Krzysztof Kozlowski wrote: >> On 12/10/2022 14:00, Matt Ranostay wrote: >>> Add missing ti,j721e-system-controller to bus defines in mcu/wakeup >>> domains to avoid the following similar warnings from dt-schema checks: >>> >>> arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short' >>> >>> Signed-off-by: Matt Ranostay >>> --- >>> arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- >>> arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +- >>> arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- >>> 3 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi >>> index e5be78a58682..b5c666f98ba4 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi >>> @@ -35,7 +35,7 @@ k3_reset: reset-controller { >>> }; >>> >>> mcu_conf: syscon@40f00000 { >>> - compatible = "syscon", "simple-mfd"; >>> + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; >> >> That's a different SoC, so probably you should use dedicated compatible >> here. > > Since there isn't any notable difference between these platforms for the simple-mfd > controller I'm thinking it maybe makes sense to have a ti,generic-system-controller > compatible. Thoughts? Compatibles should be specific unless you and TI guarantee that chosen one compatible will cover all future hardware from now till 100 years... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel