RE: [PATCH 2/4] ARM: dts: imx6ull-dhcom: Add DH electronics DHCOM i.MX6ULL SoM and PDK2 board

[Christoph Niedermaier <cniedermaier@dh-electronics.com>]

From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
Sent: Thursday, November 17, 2022 3:39 PM
> On 17/11/2022 15:11, Christoph Niedermaier wrote:
>>>> +&fec2 { /* DHCOM ETH2 */
>>>> +     phy-handle = <&mdio2_phy1>;
>>>> +     phy-mode = "rmii";
>>>> +     pinctrl-0 = <&pinctrl_fec2>;
>>>> +     pinctrl-names = "default";
>>>> +     status = "okay";
>>>> +
>>>> +     mdio {
>>>> +             #address-cells = <1>;
>>>> +             #size-cells = <0>;
>>>> +
>>>> +             mdio2_phy0: ethernet-phy@0 { /* SMSC LAN8710Ai */
>>>> +                     clock-names = "rmii-ref";
>>>> +                     clocks = <&clks IMX6UL_CLK_ENET_REF>;
>>>> +                     compatible = "ethernet-phy-id0007.c0f0",
>>>> +                                  "ethernet-phy-ieee802.3-c22";
>>>> +                     interrupt-parent = <&gpio5>;
>>>> +                     interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
>>>> +                     pinctrl-0 = <&pinctrl_fec1_phy &pinctrl_snvs_fec1_phy>;
>>>> +                     pinctrl-names = "default";
>>>> +                     reg = <0>;
>>>
>>> compatible first, reg second, then the rest of properties. Same in other
>>> places.
>>
>> Sorry, I have sorted it alphabetically.
>> Should the status property be sorted at the end or also alphabetically?
> 
> You do not have status here. For the cases where it is present, depends
> on the preferences of subarch maintainer. Usually it also goes to the
> end, but not always.

Thanks for the clarification.


Regards
Christoph
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel