From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90AC4C25B77 for ; Wed, 15 May 2024 16:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wAO+YbN9JK3a5Ws8270IDSCRAWEQgaTqx2G/7x8Sb08=; b=E0WouQbS9Nvbwb fy+iPpk8nVB0QEC9cwjOEO1R/JOWRok/4AEfE4hYg5E3rFStRZZhT/FdfzAjeI9sbh+lV9ldSZHcy eXaj3inGlrUChtlSn6CuBn4Lf9A/BP9NBJ0n8OyWIwjCqdhydwOPkVGc+Rb6C1pSThhfNPN0W3NMr BhybNINNiF0YtT7p/YgPVWaIrFV8i67Cz6DIAL4vODZG5eSUn6JDJldm/kMYskfMllsElibwgQ0ka cSm4shetNITGhMD7kB7Pv2r7B7r4PA3csBSnjlFUyZ92UlhwCuBd1AxSI0PzCBGHx5gFxj61Nxp6l 4bxzHvuAtWSqEIIRVF8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7Ha3-0000000285U-1BOa; Wed, 15 May 2024 16:34:15 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7HZz-00000002831-0Tja for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2024 16:34:12 +0000 Received: from [10.137.186.190] (unknown [131.107.159.62]) by linux.microsoft.com (Postfix) with ESMTPSA id 9CFD120BE54C; Wed, 15 May 2024 09:34:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9CFD120BE54C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1715790849; bh=LgGoEoCHc+tmuUHwV72O4w5DS5evewRoGKEngQZTkQw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HFuwoPQ5g1K3tnZKOH9/B5XNG9OpwxZJVSOTlMoZAY3YUVwYJWDUpZLViiDQtOLXM RF50tZekXZrLHIHIcY3x4azhgGO118LAatJ0iiSe91sxtFWwtf5g5PwaaOCZq6vrle 74Dv+Hu/xVGAnFlpZ8lOpSayuYNe/006pxfc5wM8= Message-ID: Date: Wed, 15 May 2024 09:34:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] drivers/pci/hyperv/arm64: vPCI MSI IRQ domain from DT To: Saurabh Singh Sengar Cc: arnd@arndb.de, bhelgaas@google.com, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, decui@microsoft.com, haiyangz@microsoft.com, hpa@zytor.com, kw@linux.com, kys@microsoft.com, lenb@kernel.org, lpieralisi@kernel.org, mingo@redhat.com, mhklinux@outlook.com, rafael@kernel.org, robh@kernel.org, tglx@linutronix.de, wei.liu@kernel.org, will@kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, ssengar@microsoft.com, sunilmut@microsoft.com, vdso@hexbites.dev References: <20240514224508.212318-1-romank@linux.microsoft.com> <20240514224508.212318-7-romank@linux.microsoft.com> <20240515094820.GB22844@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Language: en-US From: Roman Kisel In-Reply-To: <20240515094820.GB22844@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240515_093411_390582_1EE263CE X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/15/2024 2:48 AM, Saurabh Singh Sengar wrote: > On Tue, May 14, 2024 at 03:43:53PM -0700, Roman Kisel wrote: >> The hyperv-pci driver uses ACPI for MSI IRQ domain configuration >> on arm64 thereby it won't be able to do that in the VTL mode where >> only DeviceTree can be used. >> >> Update the hyperv-pci driver to discover interrupt configuration >> via DeviceTree. > > Subject prefix should be "PCI: hv:" > Thanks! >> >> Signed-off-by: Roman Kisel >> --- >> drivers/pci/controller/pci-hyperv.c | 13 ++++++++++--- >> include/linux/acpi.h | 9 +++++++++ >> 2 files changed, 19 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c >> index 1eaffff40b8d..ccc2b54206f4 100644 >> --- a/drivers/pci/controller/pci-hyperv.c >> +++ b/drivers/pci/controller/pci-hyperv.c >> @@ -906,9 +906,16 @@ static int hv_pci_irqchip_init(void) >> * way to ensure that all the corresponding devices are also gone and >> * no interrupts will be generated. >> */ >> - hv_msi_gic_irq_domain = acpi_irq_create_hierarchy(0, HV_PCI_MSI_SPI_NR, >> - fn, &hv_pci_domain_ops, >> - chip_data); >> + if (acpi_disabled) >> + hv_msi_gic_irq_domain = irq_domain_create_hierarchy( >> + irq_find_matching_fwnode(fn, DOMAIN_BUS_ANY), >> + 0, HV_PCI_MSI_SPI_NR, >> + fn, &hv_pci_domain_ops, >> + chip_data); >> + else >> + hv_msi_gic_irq_domain = acpi_irq_create_hierarchy(0, HV_PCI_MSI_SPI_NR, >> + fn, &hv_pci_domain_ops, >> + chip_data); > > Upto 100 characters per line are supported now, we can have less > line breaks. > Fewer line breaks would make this look nicer, let me know if you had any particular style in mind. >> >> if (!hv_msi_gic_irq_domain) { >> pr_err("Failed to create Hyper-V arm64 vPCI MSI IRQ domain\n"); >> diff --git a/include/linux/acpi.h b/include/linux/acpi.h >> index b7165e52b3c6..498cbb2c40a1 100644 >> --- a/include/linux/acpi.h >> +++ b/include/linux/acpi.h >> @@ -1077,6 +1077,15 @@ static inline bool acpi_sleep_state_supported(u8 sleep_state) >> return false; >> } >> >> +static inline struct irq_domain *acpi_irq_create_hierarchy(unsigned int flags, >> + unsigned int size, >> + struct fwnode_handle *fwnode, >> + const struct irq_domain_ops *ops, >> + void *host_data) >> +{ >> + return NULL; >> +} >> + >> #endif /* !CONFIG_ACPI */ >> >> extern void arch_post_acpi_subsys_init(void); >> -- >> 2.45.0 >> -- Thank you, Roman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel