From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1F9EC4345F for ; Tue, 30 Apr 2024 04:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=//3pBmHWwmLcStBJecDfulBA1eTx51Bex98uHM4FPD0=; b=LDd0nMbs9JyYZW TwN7ySuizXIMIXZ58BldsUcmnmsgv1GPVAkaJhpAV1Ac6A7gurGtvhYZ0dJD260f0KsvnBb6j+S6l T1m4kfCYI764PTKfZlKJlga3Dc8DjcmnEXomLULhzarb5MCXho+6h7bbt+LxEvU4Im9g5093coyt3 ASSb0gP3esfna2i7tTYNikS9/EttmRw2cugvYL45qh0d9NRhuj8jT/roAbPIMXy5AB+Jf4x+NH56C Zwwqw0uzIyiA2q1SpfHXLfTa+wjm2B+cVY2JKZn0OoEBKOFEzgxdNT8TyVKb2lVLRscF+jBcVIU9B tIHj9RXxkxmxd/G9fOdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1f7S-0000000526a-1wvs; Tue, 30 Apr 2024 04:29:30 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1f7O-0000000525t-39xY for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 04:29:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714451365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D1/gI69YXA+wRBrAlMSJILQJim8W89y0vmUYfYeJ+kM=; b=LsBRgvgJg0DJY9hLiSKX3mvTo/b104JH3f1iJlOX1uHWgDdrtMwHIzQeZ+T2qFy/Agbbh2 TxnJg+My2fVPPSh5M4MVqXMGeK15gkg973HL1K6bsPY/2yQgO8YfQWb7Z/k1Vf09+FsauN z9z6I5nqua/z+eatWEGYxG+Ifpch6j8= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-p_EnxwODP6ujuOgBQ_Xm5Q-1; Tue, 30 Apr 2024 00:29:24 -0400 X-MC-Unique: p_EnxwODP6ujuOgBQ_Xm5Q-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3c5ed191fe3so7622723b6e.3 for ; Mon, 29 Apr 2024 21:29:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714451363; x=1715056163; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D1/gI69YXA+wRBrAlMSJILQJim8W89y0vmUYfYeJ+kM=; b=Wdb3Q/JwmxLQxKonCN975dNGH/ai1HNWLpJErJa/SJNwU35Q2cnaMeKh3CKXLIXavZ p89MYoG67qjv9nRql4fgIHEgz2lm/sm388GZCLK4y9SZo2C9Y2gy9bRX+OvNUgDdD0W5 iiBluNywC15HUX9void0fG5RXPhN5d2W/9DM3ybMEOEFMlxsesMmoZ5j1lNigDCSb+oz oI0dYFd3x6abaikOv5sqU23m//aAuFfwO+c3D0ihO/y//ZtGPt3czeBW9ryoITAHi62I Pgv5HSXOdzajFX54z5ORvxV7pC5Us7VM1a/5iB1j3lp3TSBQbp4FdwhttJfHsNDH2NTF 0QDg== X-Forwarded-Encrypted: i=1; AJvYcCX2VRTpm6UB5i4yXMaMyyc67w1tHrniM79SVpQgNshh8BaXSZ5pZaacSsgUyVuN7YQ80+w23iXjmEl+c8LLIHEDBUxGD07fsN46xB15Y1JimPdxQew= X-Gm-Message-State: AOJu0YzTMmMLsb08qiD+P+rpGPH2HEhPM4vjosZ3Mcg6KEx3v8ztcF6n ZivqFoNvv+o/6SRhqweM9NujnDGqeZ3gMzuSrvw4OqtLtGOk7Lge4AGD9lT79oUf1yjtjRKmEF9 lNkv4DNMCyA1tqTZc4vBINKeeD2+c6/h7ilVnnOUjo6wN5ThFNKE7tsdxlHv6npAsIeYYLnpq X-Received: by 2002:a05:6808:1b21:b0:3c8:42f1:40b2 with SMTP id bx33-20020a0568081b2100b003c842f140b2mr14918955oib.9.1714451363414; Mon, 29 Apr 2024 21:29:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEma/8noQWxcMSK7hzaRRVetUMUXvHfjFYfu5UCMsY0GiHyeLt76asSKvhJFyxiVUNt5H/EkA== X-Received: by 2002:a05:6808:1b21:b0:3c8:42f1:40b2 with SMTP id bx33-20020a0568081b2100b003c842f140b2mr14918939oib.9.1714451363109; Mon, 29 Apr 2024 21:29:23 -0700 (PDT) Received: from [192.168.68.50] ([43.252.112.88]) by smtp.gmail.com with ESMTPSA id b16-20020a63d810000000b005e438fe702dsm19772604pgh.65.2024.04.29.21.29.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 21:29:22 -0700 (PDT) Message-ID: Date: Tue, 30 Apr 2024 14:29:11 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 12/16] arm64: psci: Ignore DENIED CPUs To: Jonathan Cameron , Thomas Gleixner , Peter Zijlstra , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, Russell King , "Rafael J . Wysocki" , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , Marc Zyngier , Hanjun Guo Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , linuxarm@huawei.com, justin.he@arm.com, jianyong.wu@arm.com, Lorenzo Pieralisi , Sudeep Holla References: <20240426135126.12802-1-Jonathan.Cameron@huawei.com> <20240426135126.12802-13-Jonathan.Cameron@huawei.com> From: Gavin Shan In-Reply-To: <20240426135126.12802-13-Jonathan.Cameron@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_212926_904999_B3B34174 X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/26/24 23:51, Jonathan Cameron wrote: > From: Jean-Philippe Brucker > > When a CPU is marked as disabled, but online capable in the MADT, PSCI > applies some firmware policy to control when it can be brought online. > PSCI returns DENIED to a CPU_ON request if this is not currently > permitted. The OS can learn the current policy from the _STA enabled bit. > > Handle the PSCI DENIED return code gracefully instead of printing an > error. > > Note the alternatives to the PSCI cpu_boot() callback do not > return -EPERM so the change in smp.c has no affect. > > See https://developer.arm.com/documentation/den0022/f/?lang=en page 58. > > Signed-off-by: Jean-Philippe Brucker > [ morse: Rewrote commit message ] > Signed-off-by: James Morse > Tested-by: Miguel Luis > Tested-by: Vishnu Pajjuri > Tested-by: Jianyong Wu > Reviewed-by: Jonathan Cameron > Signed-off-by: Russell King (Oracle) > Signed-off-by: Jonathan Cameron > --- > v8: Note in commit message that the -EPERM guard on the error print > only affects PSCI as other options never use this error code. > Should they do so in future, that may well indicate that they > now support similar refusal to boot. > --- > arch/arm64/kernel/psci.c | 2 +- > arch/arm64/kernel/smp.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > Thanks for the check and clarification that -EPERM is only sensible to PSCI. With the clarification: Reviewed-by: Gavin Shan Thanks, Gavin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel