From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDD68C433FE for ; Sun, 23 Oct 2022 12:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V5jk9o8xOnnNYtAQiwYWo0WPWXX7A7Q7Ow/Cek/HLq8=; b=ssmy/h1cdnDhGX FSRM6NcfhsvxyzboCutbXbk0muZtEhzA7CO0eOMLTUxt9qsp8gQ/pLZt58DfTRztfa/JJCQ8KpD+i z0U7JffnuoaHwiyeMyBEevYMy9XjTNlHtiZ0roQPefvwDK03zF3k/Ijorj2yfSOg8GKx59o3t3OvB IIpPzDKJ4NJ0CSCQZ942QDq9ao19e66UE4f6Y1yn0d+rCoV6lhdz0QJoxhHpSXbPw0fi7W1bkXjmJ 5cvR0Qvjd6PWo1UZg+sNlsnTRfVYJdPRoqbhZGNsuu6OlEXM7M8St87VXKvowd6mBDdAfchenu3Wa LmHLyvyQ4M+a+M2iSxaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omaGV-00FA1F-M9; Sun, 23 Oct 2022 12:39:43 +0000 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omaGR-00F9zN-NW for linux-arm-kernel@lists.infradead.org; Sun, 23 Oct 2022 12:39:41 +0000 Received: by mail-qt1-x832.google.com with SMTP id l28so4329736qtv.4 for ; Sun, 23 Oct 2022 05:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WtMX72KLBH/oqLRTjw6ZoQ9HphAQ86EWlsGtUM1biLY=; b=rR/rt3NVFszMvYLvpbh47uWTrABK35J57rG52zoILjoYOQHkbtYIQh00iQYClie0y3 sCYb3qtKGZKKMRBPmgZo7I11CTY9vQzNiVCsddF+NJZOCexBdZTDuaF8C6m6MeDWGz2O 84EyKhN+R+tiDg6ry5Zdvs1k+t+MXLVaym1rOFvDqXWrcWGnmUJq66oAo/+lFVTGDDMF spjhWPgr0OSF5/bsWCOb6rye4DPS2NfoUmaAx1gMD9nI4erOCP2ngTq0bCkfJk765ytn Iewy/sCoyf6ANJUcQL/6zxpYlfx24FeRknl5AUVm3MfO92mZ/01G0gFEuI71TSFYPAqw rVKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WtMX72KLBH/oqLRTjw6ZoQ9HphAQ86EWlsGtUM1biLY=; b=B1rYao+16Rc6moiCHUD6Da7Qq0B0HudmBRo3ZP/iy+zy/FDFjzvOVHjq8Jq3Q8yoFE xIydfT7fIUEIV2B8/u9yyM/qUJIH6cmSoWlky01pHR80uDZD9vAHLHpHduiPyCwr9Zi9 rMOj1asCz0N7stl8JrIK9mQsF3TPsImEakWyJtmm0ENDkgJI8RjjjE3hTINyNzrEG/K2 tKAqxsjQ2rRrx1+fGE8/8x/mtL/F28emna8SnWRm/jFzTyJLGduspCzXP+dIUMVjptoI cMPar9iaPPloMQMklL3wBOsFBgq8pz3kZt/gHkgsJM5KJKzFa9xRuaYNMOg9/yXxH/75 vF2A== X-Gm-Message-State: ACrzQf2R243YmehO1pe/cHXIjT7aFyyi5bxvgTQtGYlI5PNlowRX23+M SLxrAGgxbfLfMBRiL6bCtlTq/Q== X-Google-Smtp-Source: AMsMyM5ARqNAYBYplnOqSjtUrbcf4MWsV3uP/gieV6dYA025Qv5ID/SBR6x37ttDQse4hV7lX8FXIg== X-Received: by 2002:a05:622a:138b:b0:39c:eb5a:5c33 with SMTP id o11-20020a05622a138b00b0039ceb5a5c33mr24003935qtk.412.1666528776446; Sun, 23 Oct 2022 05:39:36 -0700 (PDT) Received: from [192.168.1.8] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id u30-20020a37ab1e000000b006ef0350db8asm7299556qke.128.2022.10.23.05.39.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Oct 2022 05:39:35 -0700 (PDT) Message-ID: Date: Sun, 23 Oct 2022 08:39:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/2] dt-bindings: pwm: mediatek: Add compatible string for MT7986 To: Daniel Golle Cc: Rob Herring , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Matthias Brugger , linux-arm-kernel@lists.infradead.org References: <20221021222338.GA565200-robh@kernel.org> <5182e3c4-9e5e-2c36-408b-9029c65c8803@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221023_053939_873979_D600B323 X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/10/2022 08:24, Daniel Golle wrote: > Hi Krzysztof, > > On Sat, Oct 22, 2022 at 12:35:25PM -0400, Krzysztof Kozlowski wrote: >> On 21/10/2022 18:58, Daniel Golle wrote: >>> On Fri, Oct 21, 2022 at 05:23:38PM -0500, Rob Herring wrote: >>>> On Fri, Oct 21, 2022 at 04:25:18PM +0100, Daniel Golle wrote: >>>>> Add new compatible string for MT7986 PWM. >>>>> >>>>> Signed-off-by: Daniel Golle >>>>> --- >>>>> Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt >>>>> index 554c96b6d0c3e0..6f4e60c9e18b81 100644 >>>>> --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt >>>>> +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt >>>>> @@ -8,6 +8,7 @@ Required properties: >>>>> - "mediatek,mt7623-pwm": found on mt7623 SoC. >>>>> - "mediatek,mt7628-pwm": found on mt7628 SoC. >>>>> - "mediatek,mt7629-pwm": found on mt7629 SoC. >>>>> + - "mediatek,mt7986-pwm": found on mt7986 SoC. >>>> >>>> This version of the PWM h/w is not compatible with any of the existing >>>> chips? If it is, it should have a fallback compatible. >>> >>> No, it is unique because it comes with just 2 PWM channels. >>> Otherwise the driver behaves just like for MT8183 (4 channels) or >>> MT8365 (3 channels) which also got distinct compatible strings. >> >> Then something would be here compatible. E.g. If you bound MT8183 with >> mt7986-pwm compatible, would you get working device with two channels? > > Yes, but I'd see another 2 channels which do not work, accessing them > may even cause problems (I haven't tried that) as it means accessing > an undocumented memory range of the SoC which we in general we > shouldn't be messing around with. Why on MT8183 there would be undocumented memory? Where is undocumented memory? > > Also note that this case is the same as MT8183 vs. MT8365, they got > distinct compatible strings and also for those two the only difference > is the number of channels. So why they are not made compatible? > >> >> If so, they are compatible. > > By that definition you should remove the additional compatible for > MT8365 or rather, it should have been rejected for the same argument. > > I'm talking about > commit fe00faee8060402a3d85aed95775e16838a6dad2 > commit 394b517585da9fbb2eea2f2103ff47d37321e976 This is a pattern spreading in several Mediatek bindings and we already commented on new patches. I don't know why people working on Mediatek do not mark pieces compatible. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel