From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0777C71135 for ; Fri, 13 Jun 2025 23:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tVIgyEp369YGSVHAgR24zVsOgiLYMbHVkjFj8orXwT0=; b=p4uC4f9/sZytUtFH4jCzjf/g2a XLsz0Wv6DRVp4wDIKwbnmsEEP2UBxwhUMlJ2GbiRNoURtXKCS4QWbgKVK79UENUgOmz67RR+TADo8 /Gzjl0blT2fZzr62Kdbc4ahMADmvm+2RPXe8ndEkaXTw/iVpnqpKZ7yrPKirZJfdwdAOr5uO1w0sg EJlu3ReFmXmBnLhNSVDgaXtys/hg+C9Fpfp2lWEZ6ZIan2xacwK7+Eu2b+t3cCsxrKirvQTNE1M+M cMuWApAaUcxtYoSTVfA0XV/xDpfj4bjIUAywAFt7w8Y8EpqGTaa1mkbgIaUXzL2saNXtVHgk3UMpC OS1uV7FA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQDrA-00000000Jjo-3y1W; Fri, 13 Jun 2025 23:30:44 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uQDoz-00000000JMd-1xQa for linux-arm-kernel@lists.infradead.org; Fri, 13 Jun 2025 23:28:31 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-23636167afeso26786445ad.3 for ; Fri, 13 Jun 2025 16:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1749857309; x=1750462109; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=tVIgyEp369YGSVHAgR24zVsOgiLYMbHVkjFj8orXwT0=; b=L1E3MBpEFtJROWHnEjpdYGdPkFbaz7NieUAJRaLHyVAvU1B0+oZjAJCRvI/cMrc4QG 6sFq8KlVwdhR7VE0pBULGIGKCGl0Q8CjQVGVUN3EYxPP2ZYAqH5EzePx5ywoy9g2F0kh t9XUoLuVrHFPMcH9n4a1yCtntTtPMJRvXzrUo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749857309; x=1750462109; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tVIgyEp369YGSVHAgR24zVsOgiLYMbHVkjFj8orXwT0=; b=TujqXDaLl30FCpm8r7rUZ9h5YNwR8NHyZhYfFtAsbtmtfxBOJt1PodnLtV/6acAmDw SSIxazad+ZIEYGPtcfs5mpuIjfYO88nZyGk//jZiFQVCuRdaSbXMerfwtR1C0XGIPbz5 qux6KVUyA8BCHjlelBfv2BRTLlneAZMuYui5iMxrxhpYSua66ZU0EJGdsIjfn0DN1AiV J60aaILdFaA+dkMc/QBws+96gEApz+sEF7e3Y4fsJIN3XcLVB5yOs3nvRRMXKSnyz95W bri4dUhvJ3i0YCzWnKkfGK58/1bdLiGWuNxGcnUMg2T6V4qcdtwmbFOzns5Pk8r/Bo5P N6rg== X-Forwarded-Encrypted: i=1; AJvYcCXvP6naBJov+IyTU80MftQAO9fOG/Mnfjm30/A/2ogbsqdK/Sl5TTpMYJT8emPwnEy/Sdl0+u4p9BE+Y6txvsh1@lists.infradead.org X-Gm-Message-State: AOJu0YywPXdLavVEmYmnfoRkXeYfVSOlS8mzYKvp+fiSffaech7PPMVF 3ueFxSLocPGgdgcHuo5wCVyZc1VzkTFxo9SxWPpLcL8Xm8znRh8yAJR966oSoZ1VGg== X-Gm-Gg: ASbGncus3blfjwbeGCspOwtYZeMR/tYyZxgdvCLnoyljIVLcsBrnpzx94jc7pDE2hhJ 2U6EgLsv6nizFOsF1CA08DbZvZEdIpdNnZY4bTyrYr4ByDpZR5n0Vv5OFV6NpSketjWBslHxDVQ FW4nq0ahoWZ/5o+tsc/LYI2/mvpQz5QJpfD7K8ZL6a5WESf7VXIFXORd3MrLTg/IP+kAZN8arNB SSyu8cbowwO4GsnoFMhn2VOvP3MoLF81UPuwZp8Gtk/yiM4PNjNikzwY+CuvrLa5S5AJ91TdQbp eMGjv+F7Lc/Sox3bkT8mS3Lk/eK6ggDGMhRff9QrCm2wbucfaoK2QhXg233EfmZcNcz763PSQ+A zTWLNp/dS3giUlU9orHgY95YhHg== X-Google-Smtp-Source: AGHT+IFRMv4pLDDHZkU3igLGyfy5y+yaEPSSBvXVtQJ9pTX4uJU4gfxC9bWCYgV8MTIXuT7DWuR7ng== X-Received: by 2002:a17:902:d543:b0:234:db06:ad1 with SMTP id d9443c01a7336-2366b16cd2dmr19148195ad.0.1749857308692; Fri, 13 Jun 2025 16:28:28 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365deaaa15sm20255465ad.173.2025.06.13.16.28.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 16:28:27 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 16:28:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] PCI: brcmstb: Add panic/die handler to driver To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20250613220843.698227-1-james.quinlan@broadcom.com> <20250613220843.698227-3-james.quinlan@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250613220843.698227-3-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250613_162829_507005_5D2B1CB3 X-CRM114-Status: GOOD ( 10.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/13/25 15:08, Jim Quinlan wrote: > Whereas most PCIe HW returns 0xffffffff on illegal accesses and the like, > by default Broadcom's STB PCIe controller effects an abort. Some SoCs -- > 7216 and its descendants -- have new HW that identifies error details. > > This simple handler determines if the PCIe controller was the cause of the > abort and if so, prints out diagnostic info. Unfortunately, an abort still > occurs. > > Care is taken to read the error registers only when the PCIe bridge is > active and the PCIe registers are acceptable. Otherwise, a "die" event > caused by something other than the PCIe could cause an abort if the PCIe > "die" handler tried to access registers when the bridge is off. > > Example error output: > brcm-pcie 8b20000.pcie: Error: Mem Acc: 32bit, Read, @0x38000000 > brcm-pcie 8b20000.pcie: Type: TO=0 Abt=0 UnspReq=1 AccDsble=0 BadAddr=0 > > Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli -- Florian