From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E7AC282CE for ; Tue, 9 Apr 2019 17:33:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3B1A20857 for ; Tue, 9 Apr 2019 17:33:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="frK1XYqM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3B1A20857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ebfxxLkDh2ZMLLSXw9wmZYLx0Lo+aj5eZQlBtm+bubQ=; b=frK1XYqMLVxjmO3o4rU+69RxO IF6is3BLnRxpH/JLSiNDvPpkhwEkPu/mhThEYD3kmhwZAomQsxnDnqAFpov0CkyVfHK13yEsVJG7K v57Z/3Bc3ty5U1PUFW34FzD82H6Yy3VLExZO8nYq56wzKZB3zG8559VS+oy8Qzn3UEblvf4N87OCM zP3maP6a1lFNEdhqeJ5PJRDsok5rDBH/ABHot1/kmb3uDp+QegWZbsv/V/4Zy620m3YBshjuShUTP HcR/0XVldPRcF1LD4SH6lZnoFjg9QU/sIkpMG/SosY7mwBLM557WTboPglmdftCe4qpjAbkBYWMxR R5x7kCAfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDucq-0007kb-SI; Tue, 09 Apr 2019 17:33:36 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDucn-0007k9-T5 for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 17:33:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F164215BE; Tue, 9 Apr 2019 10:33:32 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 98C3F3F59C; Tue, 9 Apr 2019 10:33:31 -0700 (PDT) Subject: Re: [PATCH 07/21] dma-iommu: move the arm64 wrappers to common code To: Christoph Hellwig References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-8-hch@lst.de> <67573dd3-72c7-692d-bc1a-7edb49ff9551@arm.com> <20190409172309.GD14679@lst.de> From: Robin Murphy Message-ID: Date: Tue, 9 Apr 2019 18:33:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409172309.GD14679@lst.de> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_103333_944156_1F28CBF9 X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Lendacky , Catalin Marinas , Joerg Roedel , Will Deacon , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/04/2019 18:23, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 04:07:02PM +0100, Robin Murphy wrote: >>> -static inline int iommu_dma_init(void) >>> +static inline void iommu_setup_dma_ops(struct device *dev, u64 dma_base, >>> + u64 size, const struct iommu_ops *ops) >>> { >>> - return 0; >>> } >> >> I don't think it makes sense to have a stub for that - AFAICS it should >> only ever be called form arch code with an inherent "select IOMMU_DMA" >> (much like the stuff which isn't stubbed currently). >> >> Otherwise, I'm about 97% sure the rest of the move looks OK - thanks for >> splitting things up. > > arm64 only selects IOMMU_DMA if IOMMU_SUPPORT is selected, which can > be disabled. So to keep some (unusual) arm64 configs compiling we'll need > the stub.. Urgh, right, it worked out before because arm64 stubbed its own caller of iommu_dma_init_domain() internally... Oh well - I guess there's no nicer alternative, and we have always treated arch_setup_dma_ops() that way. Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel