[PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[Sherry Sun]

Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
deleted the "gpio_active_high" flag in pci-imx6 driver, so currently
the imx6 PCIe driver doesn't support "reset-gpio-active-high" property.

Let's remove this deprecated property in imx6* dts and the
corresponding dt-binding.

Sherry Sun (3):
  ARM: dts: imx6q-apalis: Remove the deprecated "reset-gpio-active-high"
    property
  ARM: dts: imx6sx-softing-vining-2000: Remove the deprecated
    "reset-gpio-active-high" property
  dt-bindings: PCI: fsl,imx6q-pcie: Remove the deprecated
    "reset-gpio-active-high" property

 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ------
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtsi          | 1 -
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts     | 1 -
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora.dts          | 1 -
 arch/arm/boot/dts/nxp/imx/imx6sx-softing-vining-2000.dts  | 1 -
 5 files changed, 10 deletions(-)

-- 
2.37.1

[PATCH 1/3] ARM: dts: imx6q-apalis: Remove the deprecated "reset-gpio-active-high" property

[Sherry Sun]

Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
deleted the "gpio_active_high" flag in pci-imx6 driver, so currently
the imx6 PCIe driver doesn't support "reset-gpio-active-high" property.
Let's remove this deprecated property in imx6q-apalis dts.

Fixes: 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtsi      | 1 -
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts | 1 -
 arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora.dts      | 1 -
 3 files changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtsi
index b6c45ad3f430..a5f3273e03e6 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-eval.dtsi
@@ -56,7 +56,6 @@ &pcie {
 	pinctrl-0 = <&pinctrl_reset_moci>;
 	/* active-high meaning opposite of regular PERST# active-low polarity */
 	reset-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
-	reset-gpio-active-high;
 };
 
 &pwm1 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
index 3ac7a4501620..f70351479995 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora-v1.2.dts
@@ -147,7 +147,6 @@ &pcie {
 	pinctrl-0 = <&pinctrl_reset_moci>;
 	/* active-high meaning opposite of regular PERST# active-low polarity */
 	reset-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
-	reset-gpio-active-high;
 	status = "okay";
 };
 
diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora.dts b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora.dts
index f338be435277..4fac26e26a4d 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-apalis-ixora.dts
@@ -94,7 +94,6 @@ &pcie {
 	pinctrl-0 = <&pinctrl_reset_moci>;
 	/* active-high meaning opposite of regular PERST# active-low polarity */
 	reset-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
-	reset-gpio-active-high;
 	status = "okay";
 };
 
-- 
2.37.1

[PATCH 2/3] ARM: dts: imx6sx-softing-vining-2000: Remove the deprecated "reset-gpio-active-high" property

[Sherry Sun]

Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
deleted the "gpio_active_high" flag in pci-imx6 driver, so currently
the imx6 PCIe driver doesn't support "reset-gpio-active-high" property.
Let's remove this deprecated property in imx6q-apalis dts.

Fixes: 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6sx-softing-vining-2000.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx-softing-vining-2000.dts b/arch/arm/boot/dts/nxp/imx/imx6sx-softing-vining-2000.dts
index 2ffbe2df4776..fc2747c38e20 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sx-softing-vining-2000.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6sx-softing-vining-2000.dts
@@ -500,7 +500,6 @@ &pcie {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>;
-	reset-gpio-active-high;
 	status = "okay";
 };
 
-- 
2.37.1

[PATCH 3/3] dt-bindings: PCI: fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[Sherry Sun]

Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
deleted the support of "reset-gpio-active-high" property in imx6 PCIe
driver. This deprecated preoperty is no longer used in any DTS file,
let's also remove this in dt-binding.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 12a01f7a5744..6b18264afecf 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -63,12 +63,6 @@ properties:
       reset signal. It's not polarity aware and defaults to active-low reset
       sequence (L=reset state, H=operation state) (optional required).
 
-  reset-gpio-active-high:
-    description: If present then the reset sequence using the GPIO
-      specified in the "reset-gpio" property is reversed (H=reset state,
-      L=operation state) (optional required).
-    type: boolean
-
 required:
   - compatible
   - reg
-- 
2.37.1

Re: [PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[Francesco Dolcini]

On Thu, Jan 15, 2026 at 03:18:13PM +0800, Sherry Sun wrote:
> Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
> deleted the "gpio_active_high" flag in pci-imx6 driver, so currently
> the imx6 PCIe driver doesn't support "reset-gpio-active-high" property.
> 
> Let's remove this deprecated property in imx6* dts and the
> corresponding dt-binding.

Are you sure this is not breaking anything?
DT files from the Linux repository are not used just in Linux.

And , the property is still handled, see commit b8b80348c57b
("gpiolib: of: add polarity quirk for Freescale PCIe controller"), the
DT compatibility was not broken as you seem to imply in this series.

Francesco

Re: [PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[Andy Shevchenko]

On Thu, Jan 15, 2026 at 08:34:18AM +0100, Francesco Dolcini wrote:
> On Thu, Jan 15, 2026 at 03:18:13PM +0800, Sherry Sun wrote:

...

> And , the property is still handled, see commit b8b80348c57b
> ("gpiolib: of: add polarity quirk for Freescale PCIe controller"), the
> DT compatibility was not broken as you seem to imply in this series.

This is a quirk and not a 1st class support. There must be no such property
in new DTs, it's only present for the backward compatibility.

For the old ones, indeed the property is needed. The problem of reuse of Linux
DTs somewhere else is orthogonal to the Linux kernel. If this is a real problem
the DTs should have been maintained outside of Linux kernel and, if needed, be
synchronised from time to time.

TL;DR: we must discourage people to use deprecated and (historically) wrong
properties.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[Francesco Dolcini]

On Thu, Jan 15, 2026 at 10:08:47AM +0200, Andy Shevchenko wrote:
> On Thu, Jan 15, 2026 at 08:34:18AM +0100, Francesco Dolcini wrote:
> > On Thu, Jan 15, 2026 at 03:18:13PM +0800, Sherry Sun wrote:
> 
> ...
> 
> > And , the property is still handled, see commit b8b80348c57b
> > ("gpiolib: of: add polarity quirk for Freescale PCIe controller"), the
> > DT compatibility was not broken as you seem to imply in this series.
> 
> This is a quirk and not a 1st class support. There must be no such property
> in new DTs, it's only present for the backward compatibility.
> 
> For the old ones, indeed the property is needed.

Ack, we just agree here.

Francesco

RE: [PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[Sherry Sun]

> -----Original Message-----
> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Thursday, January 15, 2026 4:11 PM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; Sherry Sun
> <sherry.sun@nxp.com>; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> festevam@gmail.com; kwilczynski@kernel.org; mani@kernel.org;
> bhelgaas@google.com; Hongxing Zhu <hongxing.zhu@nxp.com>; Frank Li
> <frank.li@nxp.com>; l.stach@pengutronix.de; lpieralisi@kernel.org;
> kernel@pengutronix.de; devicetree@vger.kernel.org; imx@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 0/3] fsl,imx6q-pcie: Remove the deprecated "reset-gpio-
> active-high" property
> 
> On Thu, Jan 15, 2026 at 10:08:47AM +0200, Andy Shevchenko wrote:
> > On Thu, Jan 15, 2026 at 08:34:18AM +0100, Francesco Dolcini wrote:
> > > On Thu, Jan 15, 2026 at 03:18:13PM +0800, Sherry Sun wrote:
> >
> > ...
> >
> > > And , the property is still handled, see commit b8b80348c57b
> > > ("gpiolib: of: add polarity quirk for Freescale PCIe controller"),
> > > the DT compatibility was not broken as you seem to imply in this series.
> >
> > This is a quirk and not a 1st class support. There must be no such
> > property in new DTs, it's only present for the backward compatibility.
> >
> > For the old ones, indeed the property is needed.
> 
> Ack, we just agree here.

Sorry, my bad, I didn't notice there is a hack for this property in gpiolib,
Not sure the history for adding this, but anyway, we should not break the old boards.
Maybe we can simply mark this property as deprecated.

Best Regards
Sherry

Re: [PATCH 3/3] dt-bindings: PCI: fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[Krzysztof Kozlowski]

On 15/01/2026 08:18, Sherry Sun wrote:
> Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
> deleted the support of "reset-gpio-active-high" property in imx6 PCIe
> driver. This deprecated preoperty is no longer used in any DTS file,
> let's also remove this in dt-binding.
> 
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 12a01f7a5744..6b18264afecf 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -63,12 +63,6 @@ properties:
>        reset signal. It's not polarity aware and defaults to active-low reset
>        sequence (L=reset state, H=operation state) (optional required).
>  
> -  reset-gpio-active-high:
> -    description: If present then the reset sequence using the GPIO
> -      specified in the "reset-gpio" property is reversed (H=reset state,
> -      L=operation state) (optional required).

You had one command to run before preparing such patch:

git grep reset-gpio-active-high

so now you made this ABI undocumented.

Best regards,
Krzysztof

RE: [PATCH 3/3] dt-bindings: PCI: fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

[Sherry Sun]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Thursday, January 15, 2026 5:08 PM
> To: Sherry Sun <sherry.sun@nxp.com>; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; festevam@gmail.com; kwilczynski@kernel.org;
> mani@kernel.org; andriy.shevchenko@linux.intel.com;
> bhelgaas@google.com; Hongxing Zhu <hongxing.zhu@nxp.com>; Frank Li
> <frank.li@nxp.com>; l.stach@pengutronix.de; lpieralisi@kernel.org
> Cc: kernel@pengutronix.de; devicetree@vger.kernel.org; imx@lists.linux.dev;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 3/3] dt-bindings: PCI: fsl,imx6q-pcie: Remove the
> deprecated "reset-gpio-active-high" property
> 
> On 15/01/2026 08:18, Sherry Sun wrote:
> > Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
> > deleted the support of "reset-gpio-active-high" property in imx6 PCIe
> > driver. This deprecated preoperty is no longer used in any DTS file,
> > let's also remove this in dt-binding.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > index 12a01f7a5744..6b18264afecf 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > @@ -63,12 +63,6 @@ properties:
> >        reset signal. It's not polarity aware and defaults to active-low reset
> >        sequence (L=reset state, H=operation state) (optional required).
> >
> > -  reset-gpio-active-high:
> > -    description: If present then the reset sequence using the GPIO
> > -      specified in the "reset-gpio" property is reversed (H=reset state,
> > -      L=operation state) (optional required).
> 
> You had one command to run before preparing such patch:
> 
> git grep reset-gpio-active-high
> 
> so now you made this ABI undocumented.
> 
Hi Krzysztof,
Yes, Francesco also reminded me for this, thanks for the catch, will be more careful next time.

Best Regards
Sherry