From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9C0BC27C53 for ; Wed, 12 Jun 2024 05:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JewhlvjW0n+mhwRmJq2Gb9g5vdkIgvekjqQ0bR6SFok=; b=GdrPfAEEzPlGB3DZU7k5CDt5Fg IMShd6rAuzOaJ1ZdaT9urojW56Y0AcLZZInyQcbrKV81qBsUf8jxzhGQZln7yLoCay5hrM1OPBW1f DBpA/OoatByF1FaPqm3JYtiFa1Dc57ZNPsAk2Nh7A2HhR53Q1W94+ky9ZFEXt+qccpkRNBi60mQNB HyCVmvdzNXxiadER36MedoH+P0QwpCbCAxZx1c7XE8ftgf33Caxcc4FOB7gJYfMCd6YdFZUN2ucWC 3Sqb7S5QcnHrL+RM/gsNalQ3JGFBwMs8hON6+PKF3ps57vqObpDenZj1V5FV4TF+7sq258Z+sKb+b PnVZdxZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHGLS-0000000B7wi-3OKb; Wed, 12 Jun 2024 05:16:27 +0000 Received: from mout.gmx.net ([212.227.15.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHGLN-0000000B7wI-0BbN for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2024 05:16:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1718169377; x=1718774177; i=wahrenst@gmx.net; bh=JewhlvjW0n+mhwRmJq2Gb9g5vdkIgvekjqQ0bR6SFok=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=HfInmwarExiPOjXuBzNEQvrJFLJMpNwgE6k6/ZpRdcUPIzekTCsxHOvEdDGaiRvi tfmuy9CMO+ib+S97MAHXbOT99PK1E77AgLtJMfgfwi5Sau5d55HaJEoSrZbmC9KPR v31QJFt9uQlGPPJZonez6jO+bby9oPKdXPU2HMhpSZ+KjUl5pgVxYI0qY4H3Ndcy/ a4fQXk8k8u+PPhX+wQL9izHf860FmJ+qRiBWWrTEQgxheujFcOR5TcqVZKItBBiEH Ib2k2NQ3IHQxMfQTrrJTLTjy1d2WqiFNKwC0FR5ELSQI7hUZ2ZHDgjethMJlAAkvn N1wRDS7PVoxRuooXJA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.127] ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mt75H-1sWaGu17yj-0154rg; Wed, 12 Jun 2024 07:16:17 +0200 Message-ID: Date: Wed, 12 Jun 2024 07:16:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 07/10] staging: vchiq_arm: Reduce indentation of service_callback To: Laurent Pinchart , Dan Carpenter Cc: Greg Kroah-Hartman , Florian Fainelli , Umang Jain , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20240610210220.95524-1-wahrenst@gmx.net> <20240610210220.95524-8-wahrenst@gmx.net> <01190bf2-c698-423a-b587-c80ce5d92bb8@moroto.mountain> <20240611212347.GG10397@pendragon.ideasonboard.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: <20240611212347.GG10397@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hFZozqts5tJACvR49E62qIG3Zo25XuaVN+5HPZxPbt17nWuyx5S yC0lWU42jU7uxZuFgtTeVMAUB6fkj2c12mnaHlWlnn2h86N0WSZEppZeEGpUvETwhEWC+JU PCiVx8rV6qY8Y6nVwHeVXPQfX3L/M+FAD6GgMtlGh/vOS8vG94klpKvtU6jHpv4TRAvw1Dv 0fVlZAq40M42/aTCNIJtQ== UI-OutboundReport: notjunk:1;M01:P0:7YQeRvAJwjQ=;gYvH8x6wmqdLXRPnef6xF07d78m 7SaFNmsyzqsLF663VemsRQ6IFIHWDIQxU8I71Bc/nYknubdBekzPR1E9GV5Sw+jVp2z5n1e/4 /9ACNr0lLMTOyHIuSjHl3Hvd5hcqkRdsBJWejZkDQEAXjzW4cnPWryEqbpYMjTrLc8kj3dECp ppbdH83A4bON+VhRj/NK4Yw5kcGaX0Wg5GDPA46008rlN0E7PSUXteYA5WbRHFWEb20n4gnSR DbmbCo7tnM0yFY9dt7R5bCFa0FwYSrLmqvRtw4WDby3C6fdac6ZDntW9zm0Aw6M/ukLNJZHra EqwMZqti46SJO+F3S9EgfCg/oG0ml7F+1ms2N4Dpv2xUYu1J2YV+GBeAu6EP2B6kQswYq2v9v RKtjrk7+AXi0guW08K7dkoVovOx+StvLHxHFI1xvxnXrERWots7yppu+fFFrYEjfzzkgU2mZ5 fRMxS54kSJbrh1TCrfeLkqEh41BOnDkEnp02zkkzB3QqtaeBCdT8XghrKCzIfLG1rui/pe6Xl udgUNhzDK2mNYTjeShL5HtugWT3mTIlVmF6ElMGd6/+7HANhICE9NnjJo1vnnYiddaL+xRPny JxJSEMUm7eUD/v4X1ArLI8ICpfHTGGaJeoyO56hRnC7g3UQ7/3Q6rpYJfIaf91iQApDXfCigg 8+S9B8svRMZ1uDchr5AQVLrInAU3al8HTyemU9EPj/mh2/QM9Z2yYposnGG5JeuIRyLmGn7Z2 pa0oOSVzx6qWhfQDxY1oJ9fUpfemogg16ufkbglXKbKp9vBuVkW3u37ZqAqmJxd4Ipba559iI 5Z/9TIxyhzEPff5Pzj5WrWwvU+lo7kihf3SCfU0vM9gjo= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240611_221621_394201_A93DDABC X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am 11.06.24 um 23:23 schrieb Laurent Pinchart: > On Tue, Jun 11, 2024 at 09:04:28AM +0300, Dan Carpenter wrote: >> On Mon, Jun 10, 2024 at 11:02:17PM +0200, Stefan Wahren wrote: >>> The service_callback has 5 levels of indentation, which makes it >>> hard to read. Reduce this by splitting the code in a new function >>> service_single_message() as suggested by Laurent Pinchart. >>> >>> Signed-off-by: Stefan Wahren >> To be honest, I liked the version of this patch which Laurent didn't >> like. Even after pulling this code into a separate function, I'd still >> support flipping the conditions around and adding the goto... >> >> Laurent, you really didn't like the goto? > I won't nack it, but I really think gotos seriously hinder readability, > with the exception of error paths. > so at least you both are fine with the split approach here (assuming the Dan's comment will be fixed in V3)?