From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87704C6FD19 for ; Fri, 10 Mar 2023 10:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: CC:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MJ3IxWqvaXELXg4h0gG2GS+IivBbUA/xoLZc/7B/J4Q=; b=bgmpo4gqUe7GFZ geAMnJzW46+tCyszKfVfQEPcWQUg61LlUkeW5XEiAyqQVgN9Ba8xX82IWt7JMoKrcq9Nkp1vEcEHk YMCTbyiYAo0eNumxPJBpifM1KimsRosiBW36Is61VPCtSXIbYmbQKamzF7sMLbuzdPhNaOwAkLfza 02N08RuyyRQJKk0OaOmNt4Ry0927MQpOhM2Dp3qVXGS4n+35vkfkYcqn57uAMHUSVl8ipOPj4cUAe 1/+Ue13WPj68OKDxiQBP6HkzWda3SFH3SRMs091OXoYB7oCChZ/rLa0/5dPiBByYj2dFqCQPne5k+ +YmHdkyE2T0qne/Po+4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paZqP-00E8jR-Qs; Fri, 10 Mar 2023 10:19:26 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paZqL-00E8i4-Jt for linux-arm-kernel@lists.infradead.org; Fri, 10 Mar 2023 10:19:23 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32AAJI6e109458; Fri, 10 Mar 2023 04:19:18 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678443558; bh=pVNanGnzeyfpN747FmkvYRwS210SW/78Jb2JiH9pMHI=; h=Date:CC:Subject:To:References:From:In-Reply-To; b=EPY8bd22ocZmqUH81dPBxnLpwxLT++DZlhSYuqjcqdsmwFL27vJgsF/W4pwuxMXbW 4W3gGyk2WrR1Rdcn6t2fPAcpeVb+pzwVlfTUF0kn4+KgSmMTUiDRNk8mQRZsHwU7e5 ZZwEEqoquAf3skUgAPBTva7iM0YnsaLSwtYZAWLI= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32AAJIiN066579 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Mar 2023 04:19:18 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 10 Mar 2023 04:19:18 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 10 Mar 2023 04:19:18 -0600 Received: from [172.24.145.61] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32AAJETI028433; Fri, 10 Mar 2023 04:19:15 -0600 Message-ID: Date: Fri, 10 Mar 2023 15:49:13 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 CC: , , , , , , , , Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j721e: Add overlay to enable CPSW9G ports in QSGMII mode To: Krzysztof Kozlowski , References: <20230310092804.692303-1-s-vadapalli@ti.com> <20230310092804.692303-3-s-vadapalli@ti.com> Content-Language: en-US From: Siddharth Vadapalli In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230310_021921_779617_5130305F X-CRM114-Status: GOOD ( 11.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Krzysztof, On 10/03/23 14:59, Krzysztof Kozlowski wrote: > On 10/03/2023 10:28, Siddharth Vadapalli wrote: >> The J7 Quad Port Add-On Ethernet Card for J721E Common-Proc-Board supports >> QSGMII mode. Use the overlay to configure CPSW9G ports in QSGMII mode. >> >> Add support to reset the PHY from kernel by using gpio-hog and gpio-reset. >> >> Add aliases for CPSW9G ports to enable kernel to fetch MAC addresses >> directly from U-Boot. >> > > >> +&exp2 { >> + qsgmii-line-hog { >> + gpio-hog; >> + gpios = <16 GPIO_ACTIVE_HIGH>; >> + output-low; >> + line-name = "qsgmii-pwrdn-line"; >> + }; >> +}; >> + >> +&main_pmx0 { >> + mdio_pins_default: mdio_pins_default { > > No underscores in node names. Didn't you already get such comments? Sorry, I overlooked this. I am aware that underscores shouldn't be used. I will post the v2 series fixing this. Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel