From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: LPAE: initialize cachepolicy correctly
Date: Sun, 04 Sep 2016 16:31:40 -0700 [thread overview]
Message-ID: <eb470e86a233b7bc8328c820527f53c1@agner.ch> (raw)
In-Reply-To: <20160904220903.GN1041@n2100.armlinux.org.uk>
On 2016-09-04 15:09, Russell King - ARM Linux wrote:
> On Sat, Sep 03, 2016 at 10:33:31PM -0700, Stefan Agner wrote:
>> The cachepolicy variable gets initialized using a masked pmd
>> So far, the pmd has been masked with flags valid for the 2-page
>> table format. In the LPAE case, this lead to a wrong assumption
>> of what the initial cachepolicy has been used. Later a check
>> forces the cache policy to writealloc and prints the following
>> warning:
>> Forcing write-allocate cache policy for SMP
>>
>> This patch uses PMD_SECT_WBWA to mask all cache setting flags.
>> The define represents the complete mask of the cache relevant
>> flags for both page table formats.
>
> PMD_SECT_WBWA is just one possible combination, it's not a bit-mask.
> We need a new definition.
Agreed, it just happens to be the same as the bit-mask in both
page-table layouts.
Does PMD_SECT_CACHE_MASK sounds like a reasonable identifier for it?
--
Stefan
next prev parent reply other threads:[~2016-09-04 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 5:33 [PATCH] ARM: LPAE: initialize cachepolicy correctly Stefan Agner
2016-09-04 22:09 ` Russell King - ARM Linux
2016-09-04 23:31 ` Stefan Agner [this message]
2016-09-05 16:22 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb470e86a233b7bc8328c820527f53c1@agner.ch \
--to=stefan@agner.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).