From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90467C3271E for ; Thu, 11 Jul 2024 06:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bF2078izMbbcohLBn0uuA92HeAQkoiYk23DhFuyr80Q=; b=vCms5P+NXvaqL7MmcvPUBfiTj6 sBjB4x5Mlav8fZcmGEShwGAXT29EJIOa+StH0U9tPwFKyD+P1o55imAkriN3XRiPehS/Y6lED/o0D 9wCTtaNJukePK+DH1lomN6ND2qGc4pvRlGOPQFlzfLAS1tHd906e/JWfYkmEwhMbjYzUIw0oKSaMn yORSwbAdYdtAVJ9Z+GxFhJM9HxYbJnMSEVB6cS9Pq0Ucs0gh8UQDCBRCWzOeNJSprqLqojY6aqmfD Z2f3br/g+1ZTDluIOtqopQN99h9NuLdKndJiDD6cjr1LXcQB/T1URi1e5Fwu3HTbk6sINkmdzsFVJ M5EhrHnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRnKF-0000000CuGa-2ATT; Thu, 11 Jul 2024 06:30:43 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRnJx-0000000CuCC-2vF6; Thu, 11 Jul 2024 06:30:27 +0000 Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4WKPr91XfwzQl1c; Thu, 11 Jul 2024 14:26:17 +0800 (CST) Received: from kwepemi100008.china.huawei.com (unknown [7.221.188.57]) by mail.maildlp.com (Postfix) with ESMTPS id E3EE8140416; Thu, 11 Jul 2024 14:30:13 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi100008.china.huawei.com (7.221.188.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 11 Jul 2024 14:30:12 +0800 Message-ID: Date: Thu, 11 Jul 2024 14:30:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 0/3] ARM: Use generic interface to simplify crashkernel reservation Content-Language: en-US To: Baoquan He CC: , , , , , , , , , , , , , , , , , , , , References: <20240708133348.3592667-1-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi100008.china.huawei.com (7.221.188.57) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240710_233025_956760_F511E2A8 X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/7/9 17:29, Baoquan He wrote: > On 07/08/24 at 09:33pm, Jinjie Ruan wrote: >> Currently, x86, arm64, riscv and loongarch has been switched to generic >> crashkernel reservation. Also use generic interface to simplify crashkernel >> reservation for arm32, and fix two bugs by the way. > > I am not sure if this is a good idea. I added the generic reservation > itnerfaces for ARCH which support crashkernel=,high|low and normal > crashkernel reservation, with this, the code can be simplified a lot. > However, arm32 doesn't support crashkernel=,high, I am not sure if it's > worth taking the change, most importantly, if it will cause > misunderstanding or misoperation. It seems that x86_32 doesn't support crashkernel=,high and use the generic interface，and also have the first patch bug. I’ll resend the first patch and explain it. > > Thanks > Baoquan > >