From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D59C5C61DA4 for ; Mon, 13 Mar 2023 15:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zly8ZcuBeVE3MAPvLTMUjwdYvOA2ZYcXA+Vb/2e84mY=; b=aIL2iGImYksaOw wquGo69h6zvyRd4oQFsslXRW5jUuS3QTYxwjIXMTg/x5dCVG/2YSrgdgEEZ2KTbrxSF1W5u79VfVu 1dskmnktRmZtJwRMdBfciGVImCSPZET8Y3IyCrO4ecXdFbLZvz/uts1bnDc0Hf8amw5je6fb0EmpU JQJoBrD1THL60TiTMe1ZaosLNMeCFuua0W0IPZWJ0JuSb7uwyjaTW7KiQLaCbisq+lDiCB+2pZn8t q3wmHfB4kxKmQ4DANmGyrDNFhcKogSYl3jmkrHHLGiwdXALLyImhz7/fd92CbZ5rxL0TydQ9PJgvE bjgX4ZELb1a3R1E77Bdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbkB2-006Qto-6j; Mon, 13 Mar 2023 15:33:32 +0000 Received: from out-4.mta1.migadu.com ([2001:41d0:203:375::4]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbkAv-006Qsg-J7 for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 15:33:30 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1678721597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eu0UkR8sQte9C6pbwO79Nt2+mjEe13eli9HbMHrf494=; b=IHbgveoWRSXodRYSckjnvjKVZpI56kJGIClK/PuEb63HSzJ7bjn1oj/Ac56kWRMJZ54qgI nZVXIiR3/bJHnqd+9hS7BCPlLcAFvEDsfc52n+32TEVQN9tCKyhzhhU4RGVG9+pqO8Z2/Q nfy07Lx1aKYaP8Uz6/OCDxe85TJuNWE= Date: Mon, 13 Mar 2023 15:33:13 +0000 MIME-Version: 1.0 Subject: Re: [PATCH RFC v6 0/6] Create common DPLL/clock configuration API Content-Language: en-US To: Jiri Pirko , Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org References: <20230312022807.278528-1-vadfed@meta.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_083326_475134_563EEFFB X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/03/2023 12:20, Jiri Pirko wrote: > Sun, Mar 12, 2023 at 03:28:01AM CET, vadfed@meta.com wrote: >> Implement common API for clock/DPLL configuration and status reporting. >> The API utilises netlink interface as transport for commands and event >> notifications. This API aim to extend current pin configuration and >> make it flexible and easy to cover special configurations. > > Could you please put here some command line examples to work with this? We don't have open-source tools ready right now for specific hardware, but with YAML spec published you can use in-kernel tool to manipulate the values, i.e.: ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --dump device-get ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do device-get --json '{"id": 0}' ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --dump pin-get ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0, "pin-idx":1}' ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-set --json '{"id":0, "pin-idx":1, "pin-frequency":1}' > >> >> v5 -> v6: >> * rework pin part to better fit shared pins use cases >> * add YAML spec to easy generate user-space apps >> * simple implementation in ptp_ocp is back again >> v4 -> v5: >> * fix code issues found during last reviews: >> - replace cookie with clock id >> - follow one naming schema in dpll subsys >> - move function comments to dpll_core.c, fix exports >> - remove single-use helper functions >> - merge device register with alloc >> - lock and unlock mutex on dpll device release >> - move dpll_type to uapi header >> - rename DPLLA_DUMP_FILTER to DPLLA_FILTER >> - rename dpll_pin_state to dpll_pin_mode >> - rename DPLL_MODE_FORCED to DPLL_MODE_MANUAL >> - remove DPLL_CHANGE_PIN_TYPE enum value >> * rewrite framework once again (Arkadiusz) >> - add clock class: >> Provide userspace with clock class value of DPLL with dpll device dump >> netlink request. Clock class is assigned by driver allocating a dpll >> device. Clock class values are defined as specified in: >> ITU-T G.8273.2/Y.1368.2 recommendation. >> - dpll device naming schema use new pattern: >> "dpll_%s_%d_%d", where: >> - %s - dev_name(parent) of parent device, >> - %d (1) - enum value of dpll type, >> - %d (2) - device index provided by parent device. >> - new muxed/shared pin registration: >> Let the kernel module to register a shared or muxed pin without finding >> it or its parent. Instead use a parent/shared pin description to find >> correct pin internally in dpll_core, simplifing a dpll API >> * Implement complex DPLL design in ice driver (Arkadiusz) >> * Remove ptp_ocp driver from the series for now >> v3 -> v4: >> * redesign framework to make pins dynamically allocated (Arkadiusz) >> * implement shared pins (Arkadiusz) >> v2 -> v3: >> * implement source select mode (Arkadiusz) >> * add documentation >> * implementation improvements (Jakub) >> v1 -> v2: >> * implement returning supported input/output types >> * ptp_ocp: follow suggestions from Jonathan >> * add linux-clk mailing list >> v0 -> v1: >> * fix code style and errors >> * add linux-arm mailing list >> >> Arkadiusz Kubalewski (3): >> dpll: spec: Add Netlink spec in YAML >> ice: add admin commands to access cgu configuration >> ice: implement dpll interface to control cgu >> >> Vadim Fedorenko (3): >> dpll: Add DPLL framework base functions >> dpll: documentation on DPLL subsystem interface >> ptp_ocp: implement DPLL ops >> >> Documentation/netlink/specs/dpll.yaml | 514 +++++ >> Documentation/networking/dpll.rst | 347 ++++ >> Documentation/networking/index.rst | 1 + >> MAINTAINERS | 9 + >> drivers/Kconfig | 2 + >> drivers/Makefile | 1 + >> drivers/dpll/Kconfig | 7 + >> drivers/dpll/Makefile | 10 + >> drivers/dpll/dpll_core.c | 835 ++++++++ >> drivers/dpll/dpll_core.h | 99 + >> drivers/dpll/dpll_netlink.c | 1065 ++++++++++ >> drivers/dpll/dpll_netlink.h | 30 + >> drivers/dpll/dpll_nl.c | 126 ++ >> drivers/dpll/dpll_nl.h | 42 + >> drivers/net/ethernet/intel/Kconfig | 1 + >> drivers/net/ethernet/intel/ice/Makefile | 3 +- >> drivers/net/ethernet/intel/ice/ice.h | 5 + >> .../net/ethernet/intel/ice/ice_adminq_cmd.h | 240 ++- >> drivers/net/ethernet/intel/ice/ice_common.c | 467 +++++ >> drivers/net/ethernet/intel/ice/ice_common.h | 43 + >> drivers/net/ethernet/intel/ice/ice_dpll.c | 1845 +++++++++++++++++ >> drivers/net/ethernet/intel/ice/ice_dpll.h | 96 + >> drivers/net/ethernet/intel/ice/ice_lib.c | 17 +- >> drivers/net/ethernet/intel/ice/ice_main.c | 7 + >> drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 411 ++++ >> drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 240 +++ >> drivers/net/ethernet/intel/ice/ice_type.h | 1 + >> drivers/ptp/Kconfig | 1 + >> drivers/ptp/ptp_ocp.c | 206 +- >> include/linux/dpll.h | 284 +++ >> include/uapi/linux/dpll.h | 196 ++ >> 31 files changed, 7135 insertions(+), 16 deletions(-) >> create mode 100644 Documentation/netlink/specs/dpll.yaml >> create mode 100644 Documentation/networking/dpll.rst >> create mode 100644 drivers/dpll/Kconfig >> create mode 100644 drivers/dpll/Makefile >> create mode 100644 drivers/dpll/dpll_core.c >> create mode 100644 drivers/dpll/dpll_core.h >> create mode 100644 drivers/dpll/dpll_netlink.c >> create mode 100644 drivers/dpll/dpll_netlink.h >> create mode 100644 drivers/dpll/dpll_nl.c >> create mode 100644 drivers/dpll/dpll_nl.h >> create mode 100644 drivers/net/ethernet/intel/ice/ice_dpll.c >> create mode 100644 drivers/net/ethernet/intel/ice/ice_dpll.h >> create mode 100644 include/linux/dpll.h >> create mode 100644 include/uapi/linux/dpll.h >> >> -- >> 2.34.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel