From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9B60E8FDB8 for ; Fri, 26 Dec 2025 20:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:MIME-Version:Date: Message-ID:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RM8xUWiPB1W0MgA0qXcU7NgXtzuyc/5Zx2MgNVttglw=; b=c9IR0P0VBTLdTxI5f/YAUVjnbq nvYWYPWSd7bPVmmXv0AkLtjY+6fp1YCKERWdZJ0pZhbj3CSgnK2KASSor6oVymbxt8gS/k8zrOOA6 +IFG2f+Nq7OGqNYA/X5nhxtYnBciYBu1IhLGOyV5HhvBF0SSejyUM3Mvn/kmy83AbEQU/Cb7RU+i9 5KdSbGa0DJ5l6O1klH76F4WexK+bF6C20nHWmfKjbY32VKcomzHIWzVXoZ5EumnpIcqKs6A/zymbo JsWtdT5t/R6jU6r7ZopSGCdzp5d8zgKZQ7iFwNxhcCd1jD97RmCA0WgsNMNCXIXR+jVlY0SuW3utP efXHVpmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vZEjT-00000001SUc-3QRP; Fri, 26 Dec 2025 20:48:19 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vZEjP-00000001SUD-48I1 for linux-arm-kernel@lists.infradead.org; Fri, 26 Dec 2025 20:48:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766782095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RM8xUWiPB1W0MgA0qXcU7NgXtzuyc/5Zx2MgNVttglw=; b=DLnarn3BH+CkNjBqtnA4PlfQa2pRx452LmsR2yKVfImPgEWqREbr90ajKcY+7/81nTjaDA uL+/JfbW+rt0XYmrcJynRB2/Mok5Kw55llN1KMU6PBvuigJAdO2QqZLNDCI87cp1gBSFka eHeFdnrh48aRDOfXAN2vcOgsNle5H8A= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-kyH67bfCP8ybzGZGAayovA-1; Fri, 26 Dec 2025 15:48:13 -0500 X-MC-Unique: kyH67bfCP8ybzGZGAayovA-1 X-Mimecast-MFC-AGG-ID: kyH67bfCP8ybzGZGAayovA_1766782093 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b8738fb141so2085293085a.0 for ; Fri, 26 Dec 2025 12:48:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766782093; x=1767386893; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RM8xUWiPB1W0MgA0qXcU7NgXtzuyc/5Zx2MgNVttglw=; b=UadDvaYiTlsgDhPJrsdDozmPTa/5UKs19zddyG8eyRSziPoVwKvpcjbYaOpan1mlaC PThkoJyjEI4DvCEShFucABK13wP7CwMPyfZqwC1E/W2Q+qNJQ4J7HCJbRY92CA3ijFuU sET04BpQyibP5QDrJt7467dwT/kqUYrz5MreAOZNOcSN+7bau4bSWVLgb1IBqEb45xZ7 YIEj83JBtEb6N73YV1CO2UstPM1lOHPYSsExqMhl80f7abrV/Q/UTCeCS2QqBnMut6gU wcBncl6Smqj3rBW3qm8xQb4mCJ6w0M/P+IlI603pw+NF5WVCOUFj1ioUNb3Qng4WE+sB dTBA== X-Forwarded-Encrypted: i=1; AJvYcCUOjlfAAnqk4QnM4fuqESsYLomuY3c4vhnCH0z4KuJONitxTzyjAj8BcERRVcbeX6MFRrsAcBtbQYIYkCDTjwE/@lists.infradead.org X-Gm-Message-State: AOJu0YzoSso4YpKAGqetncD6uU9PXVwAF+fO1QslvCoFQqdSf6v4ocbf 9XjYinySHgJiU46cXVpVlefIMxky52QPYLR0k6/TGgisIjUuw0gZtsN5rtVumuXU3Z3B3Zl2Z45 Wf/HqOb9K4FCxcmJuen8wJzp2Oto+BnX6W2p+LoEoVHHI1srIksi9xL0/AkxKnbSfc1DnFqmMB2 dD X-Gm-Gg: AY/fxX49ZAbOe4YCTLR8e5Chgre31OVSVUOmCT2yvhT2FuAG2hpbNlwjB/+hkF/CN5J 8NF+DTQZPp+ALWA22ZxzkE/BT1BoRqiiX6sHe7AiLBVBy/VJjRfCal2nFxnV2qT60HUnMGRybrX qAjPkLAIRaWbjTS6njDrnEOKDKxg7Mxs/Lbc5jVyFw3pv10IZSj2fzVegvqqkDkx6oyy9G3hCAG bIV+rHkuc0I+8WFQXhLO9cEW/n0vjbuowcgiHzSxZPi+aKwYwrLuGAjNwkKqjzlWLxensXzVpjG uhLKI75wsdiDNug/0Dn/9Q8Su1MBmmwfrohLsy1MpjcJYHn3F+HtE0183rqZuwi86QGEYgNx9Yw vgGC3OtFHluievTl33UafLAvtVwhBJhzW+wl7TCl1SJXMPRzl9VAAscnh X-Received: by 2002:a05:620a:4450:b0:8b2:f5b5:c9bf with SMTP id af79cd13be357-8bee76c8ecdmr4098092585a.22.1766782093308; Fri, 26 Dec 2025 12:48:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5vt35jXazmAlmHnLRQK7CDf0928bdO3E07iE5exs1VnuKt+dhmYfT9Sq8ULHkPw+Z5ZFmhA== X-Received: by 2002:a05:620a:4450:b0:8b2:f5b5:c9bf with SMTP id af79cd13be357-8bee76c8ecdmr4098087085a.22.1766782092880; Fri, 26 Dec 2025 12:48:12 -0800 (PST) Received: from ?IPV6:2601:600:947f:f020:85dc:d2b2:c5ee:e3c4? ([2601:600:947f:f020:85dc:d2b2:c5ee:e3c4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d96ce4e23sm205030136d6.19.2025.12.26.12.48.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Dec 2025 12:48:12 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Fri, 26 Dec 2025 15:48:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21/33] cpuset: Remove cpuset_cpu_is_isolated() To: Frederic Weisbecker , LKML Cc: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Chen Ridong , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Michal Hocko , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org References: <20251224134520.33231-1-frederic@kernel.org> <20251224134520.33231-22-frederic@kernel.org> In-Reply-To: <20251224134520.33231-22-frederic@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HPqM6tFlmi3XjvQ-9VMANRbNYFyfFCC1L71VLOM9J2M_1766782093 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251226_124816_275218_D91FAC65 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/24/25 8:45 AM, Frederic Weisbecker wrote: > The set of cpuset isolated CPUs is now included in HK_TYPE_DOMAIN > housekeeping cpumask. There is no usecase left interested in just > checking what is isolated by cpuset and not by the isolcpus= kernel > boot parameter. > > Signed-off-by: Frederic Weisbecker > --- > include/linux/cpuset.h | 6 ------ > include/linux/sched/isolation.h | 4 +--- > kernel/cgroup/cpuset.c | 12 ------------ > 3 files changed, 1 insertion(+), 21 deletions(-) > > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > index 1c49ffd2ca9b..a4aa2f1767d0 100644 > --- a/include/linux/cpuset.h > +++ b/include/linux/cpuset.h > @@ -79,7 +79,6 @@ extern void cpuset_unlock(void); > extern void cpuset_cpus_allowed_locked(struct task_struct *p, struct cpumask *mask); > extern void cpuset_cpus_allowed(struct task_struct *p, struct cpumask *mask); > extern bool cpuset_cpus_allowed_fallback(struct task_struct *p); > -extern bool cpuset_cpu_is_isolated(int cpu); > extern nodemask_t cpuset_mems_allowed(struct task_struct *p); > #define cpuset_current_mems_allowed (current->mems_allowed) > void cpuset_init_current_mems_allowed(void); > @@ -215,11 +214,6 @@ static inline bool cpuset_cpus_allowed_fallback(struct task_struct *p) > return false; > } > > -static inline bool cpuset_cpu_is_isolated(int cpu) > -{ > - return false; > -} > - > static inline nodemask_t cpuset_mems_allowed(struct task_struct *p) > { > return node_possible_map; > diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h > index 6842a1ba4d13..19905adbb705 100644 > --- a/include/linux/sched/isolation.h > +++ b/include/linux/sched/isolation.h > @@ -2,7 +2,6 @@ > #define _LINUX_SCHED_ISOLATION_H > > #include > -#include > #include > #include > > @@ -84,8 +83,7 @@ static inline bool housekeeping_cpu(int cpu, enum hk_type type) > static inline bool cpu_is_isolated(int cpu) > { > return !housekeeping_test_cpu(cpu, HK_TYPE_DOMAIN) || > - !housekeeping_test_cpu(cpu, HK_TYPE_TICK) || > - cpuset_cpu_is_isolated(cpu); > + !housekeeping_test_cpu(cpu, HK_TYPE_TICK); > } > > #endif /* _LINUX_SCHED_ISOLATION_H */ > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 25ac6c98113c..cd6119c02beb 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -29,7 +29,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -1490,17 +1489,6 @@ static void update_isolation_cpumasks(void) > isolated_cpus_updating = false; > } > > -/** > - * cpuset_cpu_is_isolated - Check if the given CPU is isolated > - * @cpu: the CPU number to be checked > - * Return: true if CPU is used in an isolated partition, false otherwise > - */ > -bool cpuset_cpu_is_isolated(int cpu) > -{ > - return cpumask_test_cpu(cpu, isolated_cpus); > -} > -EXPORT_SYMBOL_GPL(cpuset_cpu_is_isolated); > - > /** > * rm_siblings_excl_cpus - Remove exclusive CPUs that are used by sibling cpusets > * @parent: Parent cpuset containing all siblings Reviewed-by: Waiman Long