From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57FD6C2BD09 for ; Sat, 6 Jul 2024 09:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-ID:Content-Type: MIME-Version:References:Message-ID:In-Reply-To:Subject:cc:To:Date:From: Reply-To:Content-Transfer-Encoding:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/LDWl54KJOoWcutAfEX6OnhiV1p6R3JNndGHzxe1ie8=; b=uOQtUwMwUp8hFHE6liowNEV/DY taF5PGHtyUuFCn1hWgVwvCZbzGxe2mtwT7qwCDS1n1P5DVYIZqh2XvUWjokHThfzqbKMmCzRQdkt8 lONJNyq4JYKCd7a3zjOS/q4n48TT7WMpIR+2UcRj+xXLicUNvnJbpJ5OX22//zhNSWBK91fpakC2z 26tgmdl5BEcQJxbJxqXOsCQshOkHl9OZS7CRX4IBtMjwJV1TNCU8wyyOH6cbyxGKubYYtyf5m/9R9 kzTws11l4lHhtPn8Znl9BvV3AzylOJl7VHjt4/vhFg3Fcq5GVUhl2YUZkCPxl8AiWIMnxlaxUHMzN RHksKRDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQ1vu-0000000014q-1LCd; Sat, 06 Jul 2024 09:42:18 +0000 Received: from mgamail.intel.com ([192.198.163.11]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQ1vf-00000000146-1euB for linux-arm-kernel@lists.infradead.org; Sat, 06 Jul 2024 09:42:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720258923; x=1751794923; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version:content-id; bh=E/LxFJ7v0Plzz7ofym5GKf8A03ELDgngtiHzfGcNTlg=; b=k44+k7KbRH5TlW5H3H8FC3iZIo2F6s/QjXOoAf8iHpfe03tOQG8o0VAV XSOnZUTEe9b2tOHjogQWAshwY099x/wch5kJWbu6xA7fCrkb/MAhRDhD6 FP+YPiGZC2sCiOB0+OotXQpMmLO/OqNcOk3cufTROSC9qBBcm7eaDkTwr zCBINCKUekOc7Hd1a52aebXlSB4VolEn53cy6DaNl3MCP2KN0sqE6kkt5 vaVRmHpH/7l0uwl+HY+tE1pihqjnLyn9wyp+rwWc10l08yGf7EstYNA6t e71XxxnGLZua4zfs2WBTrxS5VXJ6tZHk2cKqY2ffKyjumL4hiZOIUNxFf Q==; X-CSE-ConnectionGUID: l1erE57ASgWJHfHDH4Ss+A== X-CSE-MsgGUID: IDUiTT6kTfSlwiVrPPOAoQ== X-IronPort-AV: E=McAfee;i="6700,10204,11123"; a="28141203" X-IronPort-AV: E=Sophos;i="6.09,187,1716274800"; d="scan'208";a="28141203" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2024 02:41:59 -0700 X-CSE-ConnectionGUID: oe2KF22YStCqL2tn4iPFMA== X-CSE-MsgGUID: g3jZbJWWQkOJibtXAEes4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,187,1716274800"; d="scan'208";a="46941840" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.245.247.111]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2024 02:41:56 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Sat, 6 Jul 2024 12:41:51 +0300 (EEST) To: =?ISO-8859-15?Q?Marek_Beh=FAn?= cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede Subject: Re: [PATCH v2 05/30] irqchip/armada-370-xp: Cosmetic fix parentheses in register constant definitions In-Reply-To: <20240702114302.22475-6-kabel@kernel.org> Message-ID: References: <20240702114302.22475-1-kabel@kernel.org> <20240702114302.22475-6-kabel@kernel.org> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323328-1906580219-1720258685=:1194" Content-ID: <35fa549c-7851-870a-3881-f74d0aae5cb6@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240706_024203_501211_5337DD6C X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1906580219-1720258685=:1194 Content-Type: text/plain; CHARSET=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: <434d5bd0-00e4-f5cc-df52-285b767f0aab@linux.intel.com> On Tue, 2 Jul 2024, Marek Beh=FAn wrote: > Drop parentheses where not needed and add where makes sense in register > constant definitions. >=20 > Signed-off-by: Marek Beh=FAn > Reviewed-by: Andrew Lunn > --- > drivers/irqchip/irq-armada-370-xp.c | 38 ++++++++++++++--------------- > 1 file changed, 19 insertions(+), 19 deletions(-) >=20 > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-ar= mada-370-xp.c > index 18aca9b5d3b3..14d213e9b0d2 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -116,33 +116,33 @@ > */ > =20 > /* Registers relative to main_int_base */ > -#define ARMADA_370_XP_INT_CONTROL=09=09(0x00) > -#define ARMADA_370_XP_SW_TRIG_INT=09=09(0x04) > -#define ARMADA_370_XP_INT_SET_ENABLE=09=09(0x30) > -#define ARMADA_370_XP_INT_CLEAR_ENABLE=09=09(0x34) > -#define ARMADA_370_XP_INT_SOURCE_CTL(irq)=09(0x100 + irq*4) > +#define ARMADA_370_XP_INT_CONTROL=09=090x00 > +#define ARMADA_370_XP_SW_TRIG_INT=09=090x04 > +#define ARMADA_370_XP_INT_SET_ENABLE=09=090x30 > +#define ARMADA_370_XP_INT_CLEAR_ENABLE=09=090x34 > +#define ARMADA_370_XP_INT_SOURCE_CTL(irq)=09(0x100 + (irq) * 4) > #define ARMADA_370_XP_INT_SOURCE_CPU_MASK=09GENMASK(3, 0) > -#define ARMADA_370_XP_INT_IRQ_FIQ_MASK(cpuid)=09((BIT(0) | BIT(8)) << cp= uid) > +#define ARMADA_370_XP_INT_IRQ_FIQ_MASK(cpuid)=09((BIT(0) | BIT(8)) << (c= puid)) > =20 > /* Registers relative to per_cpu_int_base */ > -#define ARMADA_370_XP_IN_DRBEL_CAUSE=09=09(0x08) > -#define ARMADA_370_XP_IN_DRBEL_MASK=09=09(0x0c) > -#define ARMADA_375_PPI_CAUSE=09=09=09(0x10) > -#define ARMADA_370_XP_CPU_INTACK=09=09(0x44) > -#define ARMADA_370_XP_INT_SET_MASK=09=09(0x48) > -#define ARMADA_370_XP_INT_CLEAR_MASK=09=09(0x4C) > -#define ARMADA_370_XP_INT_FABRIC_MASK=09=09(0x54) > +#define ARMADA_370_XP_IN_DRBEL_CAUSE=09=090x08 > +#define ARMADA_370_XP_IN_DRBEL_MASK=09=090x0c > +#define ARMADA_375_PPI_CAUSE=09=09=090x10 > +#define ARMADA_370_XP_CPU_INTACK=09=090x44 > +#define ARMADA_370_XP_INT_SET_MASK=09=090x48 > +#define ARMADA_370_XP_INT_CLEAR_MASK=09=090x4C Reviewed-by: Ilpo J=E4rvinen Although, it would be nice to have consistent hex form too as now there's= =20 0x0c and 0x4C. --=20 i. --8323328-1906580219-1720258685=:1194--