* [PATCH 1/2] dt-bindings: net: fec: Add imx8dxl description @ 2023-09-09 12:31 Fabio Estevam 2023-09-09 12:31 ` [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles Fabio Estevam 2023-09-10 9:39 ` [PATCH 1/2] dt-bindings: net: fec: Add imx8dxl description Conor Dooley 0 siblings, 2 replies; 7+ messages in thread From: Fabio Estevam @ 2023-09-09 12:31 UTC (permalink / raw) To: shawnguo Cc: wei.fang, shenwei.wang, xiaoning.wang, kuba, robh+dt, krzysztof.kozlowski+dt, conor+dt, netdev, devicetree, linux-arm-kernel, Fabio Estevam From: Fabio Estevam <festevam@denx.de> The imx8dl FEC has the same programming model as the one on the imx8qxp. Add the imx8dl compatible string. Signed-off-by: Fabio Estevam <festevam@denx.de> --- Documentation/devicetree/bindings/net/fsl,fec.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml index b494e009326e..8948a11c994e 100644 --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml @@ -59,6 +59,7 @@ properties: - const: fsl,imx6sx-fec - items: - enum: + - fsl,imx8dxl-fec - fsl,imx8qxp-fec - const: fsl,imx8qm-fec - const: fsl,imx6sx-fec -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles 2023-09-09 12:31 [PATCH 1/2] dt-bindings: net: fec: Add imx8dxl description Fabio Estevam @ 2023-09-09 12:31 ` Fabio Estevam 2023-09-12 8:09 ` Paolo Abeni 2023-09-25 2:02 ` Shawn Guo 2023-09-10 9:39 ` [PATCH 1/2] dt-bindings: net: fec: Add imx8dxl description Conor Dooley 1 sibling, 2 replies; 7+ messages in thread From: Fabio Estevam @ 2023-09-09 12:31 UTC (permalink / raw) To: shawnguo Cc: wei.fang, shenwei.wang, xiaoning.wang, kuba, robh+dt, krzysztof.kozlowski+dt, conor+dt, netdev, devicetree, linux-arm-kernel, Fabio Estevam From: Fabio Estevam <festevam@denx.de> Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. This fixes the following schema warning: imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed: ['fsl,imx8qm-fec'] is too short 'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec'] 'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec'] 'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec'] 'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec'] 'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec'] 'fsl,imx8mq-fec' was expected 'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec'] 'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec'] 'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec'] from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml# Signed-off-by: Fabio Estevam <festevam@denx.de> --- arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi index b47752a878c9..a414df645351 100644 --- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi @@ -118,7 +118,7 @@ &enet0_lpcg { }; &fec1 { - compatible = "fsl,imx8qm-fec"; + compatible = "fsl,imx8dxl-fec", "fsl,imx8qm-fec", "fsl,imx6sx-fec"; interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>, -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles 2023-09-09 12:31 ` [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles Fabio Estevam @ 2023-09-12 8:09 ` Paolo Abeni 2023-09-14 6:16 ` Paolo Abeni 2023-09-25 2:02 ` Shawn Guo 1 sibling, 1 reply; 7+ messages in thread From: Paolo Abeni @ 2023-09-12 8:09 UTC (permalink / raw) To: Fabio Estevam, shawnguo Cc: wei.fang, shenwei.wang, xiaoning.wang, kuba, robh+dt, krzysztof.kozlowski+dt, conor+dt, netdev, devicetree, linux-arm-kernel, Fabio Estevam Hi, On Sat, 2023-09-09 at 09:31 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. > > This fixes the following schema warning: > > imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed: > ['fsl,imx8qm-fec'] is too short > 'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec'] > 'fsl,imx8mq-fec' was expected > 'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec'] > from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> It looks like this series is targeting the net-next tree, am I misreading this? I guess we could have small conflicts whatever target tree we will use, so I *think* the above should be ok. @Shawn Guo: do you prefer otherwise? Thanks, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles 2023-09-12 8:09 ` Paolo Abeni @ 2023-09-14 6:16 ` Paolo Abeni 2023-09-14 10:27 ` Fabio Estevam 0 siblings, 1 reply; 7+ messages in thread From: Paolo Abeni @ 2023-09-14 6:16 UTC (permalink / raw) To: Fabio Estevam, shawnguo Cc: wei.fang, shenwei.wang, xiaoning.wang, kuba, robh+dt, krzysztof.kozlowski+dt, conor+dt, netdev, devicetree, linux-arm-kernel, Fabio Estevam On Tue, 2023-09-12 at 10:09 +0200, Paolo Abeni wrote: > Hi, > > On Sat, 2023-09-09 at 09:31 -0300, Fabio Estevam wrote: > > From: Fabio Estevam <festevam@denx.de> > > > > Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. > > > > This fixes the following schema warning: > > > > imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed: > > ['fsl,imx8qm-fec'] is too short > > 'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec'] > > 'fsl,imx8mq-fec' was expected > > 'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec'] > > from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml# > > > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > It looks like this series is targeting the net-next tree, am I > misreading this? > > I guess we could have small conflicts whatever target tree we will use, > so I *think* the above should be ok. @Shawn Guo: do you prefer > otherwise? Thinking again about it, I assume this should go via the devicetree git tree, so I'm dropping it from the netdev pw. Please correct me otherwise, thanks! Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles 2023-09-14 6:16 ` Paolo Abeni @ 2023-09-14 10:27 ` Fabio Estevam 0 siblings, 0 replies; 7+ messages in thread From: Fabio Estevam @ 2023-09-14 10:27 UTC (permalink / raw) To: Paolo Abeni Cc: Fabio Estevam, shawnguo, wei.fang, shenwei.wang, xiaoning.wang, kuba, robh+dt, krzysztof.kozlowski+dt, conor+dt, netdev, devicetree, linux-arm-kernel Hi Paolo, On 14/09/2023 03:16, Paolo Abeni wrote: > Thinking again about it, I assume this should go via the devicetree git > tree, so I'm dropping it from the netdev pw. You're right. This one should go via Shawn's tree. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles 2023-09-09 12:31 ` [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles Fabio Estevam 2023-09-12 8:09 ` Paolo Abeni @ 2023-09-25 2:02 ` Shawn Guo 1 sibling, 0 replies; 7+ messages in thread From: Shawn Guo @ 2023-09-25 2:02 UTC (permalink / raw) To: Fabio Estevam Cc: wei.fang, shenwei.wang, xiaoning.wang, kuba, robh+dt, krzysztof.kozlowski+dt, conor+dt, netdev, devicetree, linux-arm-kernel, Fabio Estevam On Sat, Sep 09, 2023 at 09:31:07AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. > > This fixes the following schema warning: > > imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed: > ['fsl,imx8qm-fec'] is too short > 'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec'] > 'fsl,imx8mq-fec' was expected > 'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec'] > from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: fec: Add imx8dxl description 2023-09-09 12:31 [PATCH 1/2] dt-bindings: net: fec: Add imx8dxl description Fabio Estevam 2023-09-09 12:31 ` [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles Fabio Estevam @ 2023-09-10 9:39 ` Conor Dooley 1 sibling, 0 replies; 7+ messages in thread From: Conor Dooley @ 2023-09-10 9:39 UTC (permalink / raw) To: Fabio Estevam Cc: shawnguo, wei.fang, shenwei.wang, xiaoning.wang, kuba, robh+dt, krzysztof.kozlowski+dt, conor+dt, netdev, devicetree, linux-arm-kernel, Fabio Estevam [-- Attachment #1.1: Type: text/plain, Size: 1027 bytes --] On Sat, Sep 09, 2023 at 09:31:06AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The imx8dl FEC has the same programming model as the one on the imx8qxp. > > Add the imx8dl compatible string. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/net/fsl,fec.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml > index b494e009326e..8948a11c994e 100644 > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml > @@ -59,6 +59,7 @@ properties: > - const: fsl,imx6sx-fec > - items: > - enum: > + - fsl,imx8dxl-fec > - fsl,imx8qxp-fec > - const: fsl,imx8qm-fec > - const: fsl,imx6sx-fec > -- > 2.34.1 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-09-25 2:02 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-09 12:31 [PATCH 1/2] dt-bindings: net: fec: Add imx8dxl description Fabio Estevam 2023-09-09 12:31 ` [PATCH 2/2] arm64: dts: imx8dxl-ss-conn: Complete the FEC compatibles Fabio Estevam 2023-09-12 8:09 ` Paolo Abeni 2023-09-14 6:16 ` Paolo Abeni 2023-09-14 10:27 ` Fabio Estevam 2023-09-25 2:02 ` Shawn Guo 2023-09-10 9:39 ` [PATCH 1/2] dt-bindings: net: fec: Add imx8dxl description Conor Dooley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).