Re: [PATCH v6 1/2] dt-bindings: arm: aspeed: add IBM SBP1 board

Andrew Jeffery
2024-11-05T00:11:50Z

Hi Conor,

On Mon, 2024-11-04 at 18:49 +0000, Conor Dooley wrote:
> On Mon, Nov 04, 2024 at 08:39:21AM -0600, Rob Herring (Arm) wrote:
> >
> > On Mon, 04 Nov 2024 14:52:14 +0530, Naresh Solanki wrote:
> > > Document the new compatibles used on IBM SBP1.
> > >
> > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > > ---
> > > Changes in V4:
> > > - Retain Acked-by from v2.
> > > - Fix alphabetic order
> > > ---
> > >  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> >
> >
> > My bot found new DTB warnings on the .dts files added or changed in
> > this
> > series.
> >
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the
> > warnings
> > are fixed by another series. Ultimately, it is up to the platform
> > maintainer whether these warnings are acceptable or not. No need to
> > reply
> > unless the platform maintainer has comments.
> >
> > If you already ran DT checks and didn't see these error(s), then
> > make sure dt-schema is up to date:
> >
> >   pip3 install dtschema --upgrade
> >
> >
> > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-
> > sbp1.dtb' for
> > 20241104092220.2268805-1-naresh.solanki@9elements.com:
>
> Really? This many warnings on a v6?
>

I understand that it's surprising and disappointing, however these
warnings are from the Aspeed DTSIs and not directly from the proposed
DTS. Many are an artefact of history, and I'm (slowly) working to clean
them up. Recently I haven't had any time to dedicate to that effort,
and as I'm somewhat responsible for the state of things, I'm not
prepared to block other people's patches and push my own
responsibilities onto them.

I've been replying to those proposing new Aspeed-based devicetrees to
separate the warnings they're introducing from the warnings that
already exist, and requiring them to fix the issues they're responsible
for. I hope that I'll have time to continue to improve the situation,
as this is obviously a tedious task for me too.

Andrew

> >
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: timer: 'clocks'
> > does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/timer/arm,arch_timer.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /sdram@1e6e0000:
> > failed to match any schema with compatible: ['aspeed,ast2600-sdram-
> > edac', 'syscon']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: bus@1e600000:
> > compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long
> >         from schema $id:
> > http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: syscon@1e6e2000:
> > 'smp-memram@180' does not match any of the regexes: '^interrupt-
> > controller@[0-9a-f]+$', '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0-
> > 9a-f]+)?$', '^silicon-id@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/mfd/aspeed,ast2x00-scu.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e6e0000/syscon@1e6e2000/smp-memram@180: failed to match
> > any schema with compatible: ['aspeed,ast2600-smpmem']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e6e0000/syscon@1e6e2000/interrupt-controller@560: failed
> > to match any schema with compatible: ['aspeed,ast2600-scu-ic0']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e6e0000/syscon@1e6e2000/interrupt-controller@570: failed
> > to match any schema with compatible: ['aspeed,ast2600-scu-ic1']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e6e0000/display@1e6e6000: failed to match any schema with
> > compatible: ['aspeed,ast2600-gfx', 'syscon']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: adc@1e6e9000:
> > 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: adc@1e6e9100:
> > 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: crypto@1e6fa000:
> > 'aspeed,ahbc' does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/crypto/aspeed,ast2600-acry.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/video@1e700000: failed to match any schema with compatible:
> > ['aspeed,ast2600-video-engine']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: sdc@1e740000:
> > sdhci@1e740100:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too
> > long
> >         from schema $id:
> > http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: sdc@1e740000:
> > sdhci@1e740200:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too
> > long
> >         from schema $id:
> > http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/sdc@1e740000/sdhci@1e740100: failed to match any schema with
> > compatible: ['aspeed,ast2600-sdhci', 'sdhci']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/sdc@1e740000/sdhci@1e740200: failed to match any schema with
> > compatible: ['aspeed,ast2600-sdhci', 'sdhci']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e780000/timer@1e782000: failed to match any schema with
> > compatible: ['aspeed,ast2600-timer']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc@1e789000:
> > lpc-snoop@80: 'clocks' does not match any of the regexes: 'pinctrl-
> > [0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc@1e789000:
> > reg-io-width: 4 is not of type 'object'
> >         from schema $id:
> > http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@24: 'clocks'
> > does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@28: 'clocks'
> > does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@2c: 'clocks'
> > does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@114: 'clocks'
> > does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id:
> > http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e780000/lpc@1e789000/lhc@a0: failed to match any schema
> > with compatible: ['aspeed,ast2600-lhc']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e780000/lpc@1e789000/ibt@140: failed to match any schema
> > with compatible: ['aspeed,ast2600-ibt-bmc']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e780000/bus@1e78a000/i2c@280/bmc-slave@10: failed to
> > match any schema with compatible: ['ipmb-dev']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: fsi@1e79b000:
> > compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long
> >         from schema $id:
> > http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e790000/fsi@1e79b000: failed to match any schema with
> > compatible: ['aspeed,ast2600-fsi-master', 'fsi-master']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: fsi@1e79b100:
> > compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long
> >         from schema $id:
> > http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml#
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e790000/fsi@1e79b100: failed to match any schema with
> > compatible: ['aspeed,ast2600-fsi-master', 'fsi-master']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb:
> > /ahb/apb@1e790000/dma-controller@1e79e000: failed to match any
> > schema with compatible: ['aspeed,ast2600-udma']
> >
> >
> >
> >
> >