From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55D20C48BF6 for ; Sun, 3 Mar 2024 12:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F08S93Fs/HEhBnOC6+aj5ortTDj7dTEU41KcfzHD0DY=; b=tL+DX6bUtO9F3z KcHA8W1nsyWrgJ8gcGnmM9rZTrfQW/jhRqfMSgvElwWGXCoOpzkVOF8f2S0c10gvcevj3xRO3INad egqNkLFmv1+HZPO3mrQxFn0EpVA38mZhdFtm0sI4bHnaiCjdfEC7FH/Pt1GTdP1UfXMgKW6Szd7Pn R/uHgQtgtwiHBGHIjT3sBRD4Ew9JQZYuHvXWDqpbfysovHXRLPeNrm1frMhzOgZk/cD6zH8V3n4ol ijbR8a5gR1BkiTlhpy1oRxjpYr6Y7NdWvT5+ktAu5MyEvj7ynbEbMJorxZA60lkfHQdt7LL9P7rLW hGQwbt1axfifrtkZpeEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgkqE-00000005rA0-3ozd; Sun, 03 Mar 2024 12:21:18 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgkqB-00000005r8g-2e4z for linux-arm-kernel@lists.infradead.org; Sun, 03 Mar 2024 12:21:18 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-33d7b8f563eso2350899f8f.0 for ; Sun, 03 Mar 2024 04:21:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1709468473; x=1710073273; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NDnEAy0pAbQJrgpo4wTbJR5x2HUNb3fFgJPTxRDHJ8w=; b=hzipybicJiyToJNQjkyxrWfzgFhZDBC+Rwpj4LUL9fGeLaK98MPkhptvwq6yTxX43v EYzMqYVRCr6jJKOlhzYQCSvWEkmBRdt5soTD4xYw4eR589/Y4IckoNoCB8hvHRe9l4af 08/NVpQQKQdX24oUbGrUYpH7P8xSpkTHD1oeaAcDpyhq0EVZcuD6ArIdVhAnoW/cq7im UGPrYiSwpJ7L5YL6pS0xOOMPenOUTRPhIbqGogdhnLsfZB9larORFeyZc5K0dvRsI9Vt X062RX2KAX8w4T8S0ptQZmafUWfVKIy4uCg2ZctPxYkR6OGaANiluVpGi2B46TAWP5lR +rwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709468473; x=1710073273; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NDnEAy0pAbQJrgpo4wTbJR5x2HUNb3fFgJPTxRDHJ8w=; b=S3tyGEJf8oAdhEe9P+Geef4cNZvRAL5L0o3/lIHCpHeV+kgjJOT9AxmyrFfsY2CtR2 AGGitr+OXbpkRcIDD4q3kQ9SgoKYNmTcMiUxetvPdSmEWJxoq/Du/IFwLUFgSkQBT0y6 Spf1OxG7M/f4uUxOD7J+529yIn4QdTsGxiFy4J06gWqONibf3j2bJTWvkLzcPz1zFW67 Qc4WzNaDHaLYQ6aafxs14ija9b7VpnSzAb0JXk4xOb+Oizt2cEHgDDRScyPPGT1RQDOD odfAWBZbdS9UyxQxPYcgDVnf0VcCAJz4hna2nel+YXaKLhRrkWXRO8RZHVmFyt+L3nad VaZg== X-Forwarded-Encrypted: i=1; AJvYcCX+zxQVqAHQTvvVYBgUHNE8l51ywlNyZR09mFFyQrpiITOOTx+wDSiaBEzBZsbHO7HPR562z53RYgfrPoVJXeRFCO0PpfccAGP2lCH7iNUNcJyUjMQ= X-Gm-Message-State: AOJu0Yw2SquBQ8ZU12VbqTTZzCrmPHvN4HxiynWnB370oM87bnzD+DHj vjqaP6lXikRE3mr+ZqfuVkdwA3BnRMOY7rXUqwnlVU7lTyBoK0Dv0HgPUW1qf2s= X-Google-Smtp-Source: AGHT+IGKoczi43rEP+/na2g7kDMMbjQH9azs0dGCmXX9wN3QD0VbMk1T6oRuaWKht+wVBisq27bEDg== X-Received: by 2002:a5d:6283:0:b0:33d:1153:f41a with SMTP id k3-20020a5d6283000000b0033d1153f41amr3810677wru.20.1709468473077; Sun, 03 Mar 2024 04:21:13 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.38]) by smtp.gmail.com with ESMTPSA id dw2-20020a0560000dc200b0033ddfba0c67sm9477927wrb.41.2024.03.03.04.21.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Mar 2024 04:21:12 -0800 (PST) Message-ID: Date: Sun, 3 Mar 2024 14:21:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 20/39] ARM: at91: add support in SoC driver for new sam9x7 Content-Language: en-US To: Varshini Rajendran , nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Claudiu Beznea References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223172722.672592-1-varshini.rajendran@microchip.com> From: claudiu beznea In-Reply-To: <20240223172722.672592-1-varshini.rajendran@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240303_042115_723888_C28EF4B9 X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23.02.2024 19:27, Varshini Rajendran wrote: > Add support for SAM9X7 SoC in the SoC driver. > > Signed-off-by: Varshini Rajendran > Reviewed-by: Claudiu Beznea > --- > Changes in v4: > - Sorted the entries alphabetically as per comment from Claudiu > - Updated EXID > Note: Did not remove the Reviewed-by tag since the changes were only > cosmetic and did not affect functionality > --- > drivers/soc/atmel/soc.c | 23 +++++++++++++++++++++++ > drivers/soc/atmel/soc.h | 9 +++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c > index cc9a3e107479..cae3452cbc60 100644 > --- a/drivers/soc/atmel/soc.c > +++ b/drivers/soc/atmel/soc.c > @@ -101,6 +101,29 @@ static const struct at91_soc socs[] __initconst = { > AT91_CIDR_VERSION_MASK, SAM9X60_D6K_EXID_MATCH, > "sam9x60 8MiB SDRAM SiP", "sam9x60"), > #endif > +#ifdef CONFIG_SOC_SAM9X7 > + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK, > + AT91_CIDR_VERSION_MASK, SAM9X72_EXID_MATCH, > + "sam9x72", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK, > + AT91_CIDR_VERSION_MASK, SAM9X70_EXID_MATCH, > + "sam9x70", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1G_EXID_MATCH, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75 1Gb DDR3L SiP ", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D5M_EXID_MATCH, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75 512Mb DDR2 SiP", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1M_EXID_MATCH, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75 128Mb DDR2 SiP", "sam9x7"), > + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D2G_EXID_MATCH, > + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH, > + "sam9x75 2Gb DDR3L SiP", "sam9x7"), Could you keep these sorted after SoC name and memory size? E.g. see sama7g5 entries, sama5dX entries. > +#endif > #ifdef CONFIG_SOC_SAMA5 > AT91_SOC(SAMA5D2_CIDR_MATCH, AT91_CIDR_MATCH_MASK, > AT91_CIDR_VERSION_MASK, SAMA5D21CU_EXID_MATCH, > diff --git a/drivers/soc/atmel/soc.h b/drivers/soc/atmel/soc.h > index 7a9f47ce85fb..fc4157c5f6e3 100644 > --- a/drivers/soc/atmel/soc.h > +++ b/drivers/soc/atmel/soc.h > @@ -44,6 +44,7 @@ at91_soc_init(const struct at91_soc *socs); > #define AT91SAM9X5_CIDR_MATCH 0x019a05a0 > #define AT91SAM9N12_CIDR_MATCH 0x019a07a0 > #define SAM9X60_CIDR_MATCH 0x019b35a0 > +#define SAM9X7_CIDR_MATCH 0x09750020 > #define SAMA7G5_CIDR_MATCH 0x00162100 > > #define AT91SAM9M11_EXID_MATCH 0x00000001 > @@ -74,6 +75,14 @@ at91_soc_init(const struct at91_soc *socs); > #define SAMA7G54_D2G_EXID_MATCH 0x00000020 > #define SAMA7G54_D4G_EXID_MATCH 0x00000028 > > +#define SAM9X70_EXID_MATCH 0x00000005 > +#define SAM9X72_EXID_MATCH 0x00000004 > +#define SAM9X75_D1G_EXID_MATCH 0x00000018 > +#define SAM9X75_D2G_EXID_MATCH 0x00000020 > +#define SAM9X75_D1M_EXID_MATCH 0x00000003 > +#define SAM9X75_D5M_EXID_MATCH 0x00000010 > +#define SAM9X75_EXID_MATCH 0x00000000 Could you keep this chunk after SAM9X60_* one to have some kind of alphanumerical sort? > + > #define AT91SAM9XE128_CIDR_MATCH 0x329973a0 > #define AT91SAM9XE256_CIDR_MATCH 0x329a93a0 > #define AT91SAM9XE512_CIDR_MATCH 0x329aa3a0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel