From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1726C433EF for ; Mon, 27 Sep 2021 19:51:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 818C060184 for ; Mon, 27 Sep 2021 19:51:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 818C060184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=WtoBZr3C8kCvT8MPrHOJQJQ2rsIYgl7w+BO4ik8PTRw=; b=J60rSYG87BGitvSYukm2mG6N1N nA6BRf6PJIN5bnJdD5+RlggoHSMiWn11VNeYiz2ipmHFve1m3aWgH9/3B6v1f9KmcaSWOD8JpOrtx jRAANHuTjw8kEL4HizbhGhs9Wl66lZszJPDm2QDfUGbGxwALLA0AvHuTQ0SaGcNBdpkg1TBIJu7iD cOBOURYW6Zz9qOd4tfncJbubVVwAEDuEJ4vUzEB2YSfKQlt7F5VaCVrz0X7qiyWu7k8EUagcw9z0a 37XouoGDrvQTat2Bv7HlupCyZDOq7H+0eZVU1+LhR8/fFEpbL0HtAt7+cNbbws+oxISPSDxqLTHrC n+TnUYMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUwdV-0042Yh-FV; Mon, 27 Sep 2021 19:50:01 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUwdS-0042Xm-7b for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 19:49:59 +0000 Received: by mail-pj1-x102a.google.com with SMTP id bj3-20020a17090b088300b0019e6603fe89so12620483pjb.4 for ; Mon, 27 Sep 2021 12:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5QSzm8utmTgnrRlFRq4Amj6RmlERizp4a7MuqMMUEss=; b=WLGGXOxdA4lWf0nCQqxxlhFu9itBPN1mM9F8gOE3H4uazgHy0IiPUEYVOCXwiPMMAC QNZPyUlMnh+lkxV/kQPkCQT0l5pzE2XyPdiHNWOGt3zDjwKEcRFede8oKVO4CDglxGIL pXuStMVzlrJP6nIoissW6XdGV6mDvM2g878a96Xta6fMi8xXMgGoL9B8qhtBEZmKZIda Mo9mLF7XU22ot59x6W/C7tUcXOY9Kw5lqvAMHU+86030uVFC+2WozKbr1yY8J/ggQUTB mr8NHiPsS2daFe5e6EMpI4wxsEawSSPFQllfUavEyARbrFSuX5v5SJHku5D5woaUA0CR 564Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5QSzm8utmTgnrRlFRq4Amj6RmlERizp4a7MuqMMUEss=; b=St9+Pbz/I6IXXUFj2QnAPX9d2dkhOw/XvTUZKfhsIdl3fPMobKMsbA3bxmg9dk1lpx noUTeOypvq8nrbM3kfU8FR8h5i74E0aEo+3CRrWAxH18+Url/7O7UHedCDkJifPirhQf 1jWJzywQPDk6dQt4r5wo4V7hDtyMbdy36NWRugvyhYtBSQEFe34G6hLXsJlKnn7fODhp N0TR1rjtlVEqdfQsiK70p4PUdOMcigm8be49iwvGj+fx6cEf63IOPIEoCufJtSyEWCqX ou2dktzJcEdM4t+bCvPMPOnwXzwar/+6uGs28bBVdIATmE3gRDwOLg1FWuBJK/ytNY1r CT9w== X-Gm-Message-State: AOAM530NSMhFowTUmQ7SO6Ykqm0cdJ7+6WvtiI3t3Ib/mq4Wco+8prhZ U7F4ryE+WMotxU0pLiAM240= X-Google-Smtp-Source: ABdhPJwM0+P0GuD9fDjPpiJXXlQj4ejazYKLGuqaLQsLFCbmRRyPYDMEh2girVfPPPRJIZYaOR2UMQ== X-Received: by 2002:a17:902:7e84:b0:13a:3396:1c04 with SMTP id z4-20020a1709027e8400b0013a33961c04mr1210771pla.84.1632772194407; Mon, 27 Sep 2021 12:49:54 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id q12sm20109950pgv.26.2021.09.27.12.49.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 12:49:53 -0700 (PDT) Subject: Re: [PATCH 07/11] of/irq: Export of_irq_count to drivers To: Rob Herring , Florian Fainelli Cc: "linux-kernel@vger.kernel.org" , Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Thomas Gleixner , Marc Zyngier , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-8-f.fainelli@gmail.com> From: Florian Fainelli Message-ID: Date: Mon, 27 Sep 2021 12:49:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_124958_310448_9EDE4BE8 X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/27/21 12:43 PM, Rob Herring wrote: > On Mon, Sep 27, 2021 at 2:28 PM Florian Fainelli wrote: >> >> On 9/27/21 12:08 PM, Rob Herring wrote: >>> On Fri, Sep 24, 2021 at 12:07 PM Florian Fainelli wrote: >>>> >>>> In order to build drivers/irqchip/irq-bcm7120-l2.c as a module, we will >>>> need to have of_irq_count() exported to modules. >>>> >>>> Signed-off-by: Florian Fainelli >>>> --- >>>> drivers/of/irq.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/of/irq.c b/drivers/of/irq.c >>>> index 352e14b007e7..949b9d1f8729 100644 >>>> --- a/drivers/of/irq.c >>>> +++ b/drivers/of/irq.c >>>> @@ -440,6 +440,7 @@ int of_irq_count(struct device_node *dev) >>>> >>>> return nr; >>>> } >>>> +EXPORT_SYMBOL_GPL(of_irq_count); >>> >>> Please convert to use platform_irq_count() instead. >> >> That requires a platform_device to be passed to platform_irq_count(), >> will that work even when the drivers remain built into the kernel and >> get initialized early on? > > No, does your irqchip using this do both? Looks to me like it is > always a platform_device. On ARM/ARM64 not using GKI as well as MIPS, we would want the module to be built into the kernel image, however when using GKI that driver would become a module. How do you suggest reconciling both usages? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel