From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCAC5C433F5 for ; Sun, 1 May 2022 08:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=theHwf71Uej7ozmMllme6aIGkHk9DPTucmushyrzYeo=; b=Ypm2HoE8CbJxOf Frmon64VgdNIXqIwwSaoXNIDw62rEC/oi5K1oJpNwyY8ovhn6SUNqbK/n5veR7+9ySuiMiSBM3jfO dQcuv8Cf6kwB+JLWWBO12zMoAxRsEfDI+ik9b0sPgITr0U3BZwu8K9X4ABTFvwDJxTIqCSrNHH/59 zV3QOTdnMOzEDX259ukLr6ldfYGol7KgMvFvHlGc+SywhbXQ6H0w7TmeX2iFE5BZTOscmfso7DktI VJ5bzZngUQyHToBKR6l1QmI58/Dy9sYB+PXuoTEJmR5Bs3mJIKgLy5SUxgSFoxyFE6CkXOlal+RSu cA/MNfYz9RKfAsfIDp7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nl57V-00Fvdn-Dg; Sun, 01 May 2022 08:39:57 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nl57S-00FvcS-JJ for linux-arm-kernel@lists.infradead.org; Sun, 01 May 2022 08:39:56 +0000 Received: by mail-ej1-x635.google.com with SMTP id g6so22850645ejw.1 for ; Sun, 01 May 2022 01:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=9WVzij1T8iCMekan0Ad5/KsKpQIIUWQ6B5EMe3d2lrs=; b=mROR3otRplC07o1VILVg/gxS1mFRixD2TxOi5OqbbxVM8XZNnOv0hIHidqUUQIbpSI xbIyoUrjYdvXKlAVk8j8F7eowgb7y3rZNC3lVTcgsBfxxWMEEqZTr6GUzJAu0CQI+LDF FzoPuSFw5yU6Kw8NYH4Oy9oEgvf1nV8vbjsonJYwytOtaGjhY/lWmINanDMK8664ea3I UOO7ZdRQYyB0Wi/NdV2SgrFSvWbiMcRV2yoVk4zaqk2BJozbzhniZZLURoAJFmsKPzwQ VPvpptkjPqULmqY7ZamztTW4t6t7+LkfI/giQJIuqbQN2Ar/gifMbZmUW3rHskp2k1wY XgUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9WVzij1T8iCMekan0Ad5/KsKpQIIUWQ6B5EMe3d2lrs=; b=4F6yzdMcgt+qmlEc8po6pVfacH4dv1L0Tc6Q2foRxmnr8fUh74SsmBzp6ZX7S/JT87 wXbQgRohinp5i7FTGyrPsP/Yl6DYnhtotCYIIpa0fPknIkXyEQdtyfG5vaS4FjGzrh3p K4rTCVt851xxLv3oFIm3tCn1rLRPKWVWijZg6yrHUVUEhGGDdOCFg3g6S9xOMSMYtH9g 19lD771hR7f9UOKPqm3SL3qV8QIe00Hc09yshJJrJygG/uwZOUJzULzurTVA8HpXUmU3 oqPZVyaglUwX5mSr6spPb9nOhbHImrWCgTCJGcGq1cwLVjXtwWYd0kcHhAxjEC4NKedC 3MtA== X-Gm-Message-State: AOAM5303vw/uoNoE80SVfuJz+SzfOb4d5NgKZdyztkE/qjPb7eXRA8bh UeESF4sEidgwpTOpE3YrYIFr6A== X-Google-Smtp-Source: ABdhPJxSZX/QiQu3+AxPRtWO5Bwf8OHfZj8Hk0L0xj2XTUlRIcS57LBeqeX+kbSIvh5SbCQrJkPHBw== X-Received: by 2002:a17:906:5d0c:b0:6f3:dce6:a69a with SMTP id g12-20020a1709065d0c00b006f3dce6a69amr6963489ejt.23.1651394392331; Sun, 01 May 2022 01:39:52 -0700 (PDT) Received: from [192.168.0.182] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id hy25-20020a1709068a7900b006f3ef214db5sm2380978ejc.27.2022.05.01.01.39.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 May 2022 01:39:51 -0700 (PDT) Message-ID: Date: Sun, 1 May 2022 10:39:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] dt-bindings: arm: mediatek: mmsys: refine power and gce properties Content-Language: en-US To: Jason-JH Lin , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno Cc: Fabien Parent , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, CK Hu , Rex-BC Chen , Nancy Lin , Singo Chang , Project_Global_Chrome_Upstream_Group@mediatek.com, Cellopoint References: <20220429083051.11260-1-jason-jh.lin@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220501_013954_702835_B7D68D16 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/05/2022 10:26, Jason-JH Lin wrote: > Hi Krzysztof, > > Thanks for the reviews. > > On Fri, 2022-04-29 at 22:58 +0200, Krzysztof Kozlowski wrote: >> On 29/04/2022 10:30, Jason-JH.Lin wrote: >>> Power: >>> Refine description and add item number for power-domains >>> property. >>> >>> GCE: >>> Refine description and add item number for mboxes property and >>> mediatek,gce-client-reg property. >>> >>> Fixes: 1da90b8a7bae ("dt-bindings: arm: mediatek: mmsys: add power >>> and gce properties") >>> Signed-off-by: Jason-JH.Lin > > [snip] > >>> mboxes: >>> + minItems: 1 >>> + maxItems: 24 >> >> Wait, no, I wrote it should be 16 for one device and 24 for other, >> not >> 24 for all... >> > > Ok, I thought maxItems: 24 contained 16, but it's not clear enough. > > > I'm not sure how to describe different maxItems for different > platforms. Does it come like this? > > 1. Remove the maxItems in mboxes property. mboxes: maxItems: 24 > 2. Add the allOf condition before the line "additionalProperties: > false". E.g. > > allOf: > - if: > properties: > compatible: > contains: > const: mediatek,mt8173-mmsys > then: > properties: > mboxes: > maxItems: 16 > else: > properties: > mboxes: > maxItems: 24 and you can skip the "else". In general looks fine. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel