From: Matheus Castello <matheus@castello.eng.br>
To: "Cristian Ciocaltea" <cristian.ciocaltea@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Andreas Färber" <afaerber@suse.de>
Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 02/13] arm: dts: owl-s500: Set CMU clocks for UARTs
Date: Sat, 9 Jan 2021 00:39:45 -0300 [thread overview]
Message-ID: <ec2e5c68-fecd-ce2a-dc24-1a00085c6f73@castello.eng.br> (raw)
In-Reply-To: <fefb1ed01dacbc79811038d2c871b6528011b63f.1609263738.git.cristian.ciocaltea@gmail.com>
Em 12/29/2020 6:17 PM, Cristian Ciocaltea escreveu:
> Set Clock Management Unit clocks for the UART nodes of Actions Semi
> S500 SoCs and remove the dummy "uart2_clk" and "uart3_clk" fixed clocks.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Changes in v3:
> - Added Reviewed-by from Mani
> - Removed the dummy 'uart2_clk' and 'uart3_clk' nodes from all owl-s500 DTS,
> per Mani's review
>
> arch/arm/boot/dts/owl-s500-cubieboard6.dts | 7 -------
> arch/arm/boot/dts/owl-s500-guitar-bb-rev-b.dts | 7 -------
> arch/arm/boot/dts/owl-s500-labrador-base-m.dts | 7 -------
> arch/arm/boot/dts/owl-s500-roseapplepi.dts | 7 -------
> arch/arm/boot/dts/owl-s500-sparky.dts | 7 -------
> arch/arm/boot/dts/owl-s500.dtsi | 7 +++++++
> 6 files changed, 7 insertions(+), 35 deletions(-)
>
> diff --git a/arch/arm/boot/dts/owl-s500-cubieboard6.dts b/arch/arm/boot/dts/owl-s500-cubieboard6.dts
> index 7c96c59b610d..c2b02895910c 100644
> --- a/arch/arm/boot/dts/owl-s500-cubieboard6.dts
> +++ b/arch/arm/boot/dts/owl-s500-cubieboard6.dts
> @@ -25,12 +25,6 @@ memory@0 {
> device_type = "memory";
> reg = <0x0 0x80000000>;
> };
> -
> - uart3_clk: uart3-clk {
> - compatible = "fixed-clock";
> - clock-frequency = <921600>;
> - #clock-cells = <0>;
> - };
> };
>
> &timer {
> @@ -39,5 +33,4 @@ &timer {
>
> &uart3 {
> status = "okay";
> - clocks = <&uart3_clk>;
> };
> diff --git a/arch/arm/boot/dts/owl-s500-guitar-bb-rev-b.dts b/arch/arm/boot/dts/owl-s500-guitar-bb-rev-b.dts
> index e610d49395d2..7ae34a23e320 100644
> --- a/arch/arm/boot/dts/owl-s500-guitar-bb-rev-b.dts
> +++ b/arch/arm/boot/dts/owl-s500-guitar-bb-rev-b.dts
> @@ -18,15 +18,8 @@ aliases {
> chosen {
> stdout-path = "serial3:115200n8";
> };
> -
> - uart3_clk: uart3-clk {
> - compatible = "fixed-clock";
> - clock-frequency = <921600>;
> - #clock-cells = <0>;
> - };
> };
>
> &uart3 {
> status = "okay";
> - clocks = <&uart3_clk>;
> };
> diff --git a/arch/arm/boot/dts/owl-s500-labrador-base-m.dts b/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
> index c92f8bdcb331..1585e33f703b 100644
> --- a/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
> +++ b/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
> @@ -21,15 +21,8 @@ aliases {
> chosen {
> stdout-path = "serial3:115200n8";
> };
> -
> - uart3_clk: uart3-clk {
> - compatible = "fixed-clock";
> - clock-frequency = <921600>;
> - #clock-cells = <0>;
> - };
> };
>
> &uart3 {
> status = "okay";
> - clocks = <&uart3_clk>;
> };
> diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts
> index a2087e617cb2..800edf5d2d12 100644
> --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts
> +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts
> @@ -25,12 +25,6 @@ memory@0 {
> device_type = "memory";
> reg = <0x0 0x80000000>; /* 2GB */
> };
> -
> - uart2_clk: uart2-clk {
> - compatible = "fixed-clock";
> - clock-frequency = <921600>;
> - #clock-cells = <0>;
> - };
> };
>
> &twd_timer {
> @@ -43,5 +37,4 @@ &timer {
>
> &uart2 {
> status = "okay";
> - clocks = <&uart2_clk>;
> };
> diff --git a/arch/arm/boot/dts/owl-s500-sparky.dts b/arch/arm/boot/dts/owl-s500-sparky.dts
> index c665ce8b88b4..9d8f7336bec0 100644
> --- a/arch/arm/boot/dts/owl-s500-sparky.dts
> +++ b/arch/arm/boot/dts/owl-s500-sparky.dts
> @@ -25,12 +25,6 @@ memory@0 {
> device_type = "memory";
> reg = <0x0 0x40000000>; /* 1 or 2 GiB */
> };
> -
> - uart3_clk: uart3-clk {
> - compatible = "fixed-clock";
> - clock-frequency = <921600>;
> - #clock-cells = <0>;
> - };
> };
>
> &timer {
> @@ -39,5 +33,4 @@ &timer {
>
> &uart3 {
> status = "okay";
> - clocks = <&uart3_clk>;
> };
> diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi
> index 5d5ad9db549b..ac3d04c75dd5 100644
> --- a/arch/arm/boot/dts/owl-s500.dtsi
> +++ b/arch/arm/boot/dts/owl-s500.dtsi
> @@ -131,6 +131,7 @@ uart0: serial@b0120000 {
> compatible = "actions,s500-uart", "actions,owl-uart";
> reg = <0xb0120000 0x2000>;
> interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu CLK_UART0>;
> status = "disabled";
> };
>
> @@ -138,6 +139,7 @@ uart1: serial@b0122000 {
> compatible = "actions,s500-uart", "actions,owl-uart";
> reg = <0xb0122000 0x2000>;
> interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu CLK_UART1>;
> status = "disabled";
> };
>
> @@ -145,6 +147,7 @@ uart2: serial@b0124000 {
> compatible = "actions,s500-uart", "actions,owl-uart";
> reg = <0xb0124000 0x2000>;
> interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu CLK_UART2>;
> status = "disabled";
> };
>
> @@ -152,6 +155,7 @@ uart3: serial@b0126000 {
> compatible = "actions,s500-uart", "actions,owl-uart";
> reg = <0xb0126000 0x2000>;
> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu CLK_UART3>;
> status = "disabled";
> };
>
> @@ -159,6 +163,7 @@ uart4: serial@b0128000 {
> compatible = "actions,s500-uart", "actions,owl-uart";
> reg = <0xb0128000 0x2000>;
> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu CLK_UART4>;
> status = "disabled";
> };
>
> @@ -166,6 +171,7 @@ uart5: serial@b012a000 {
> compatible = "actions,s500-uart", "actions,owl-uart";
> reg = <0xb012a000 0x2000>;
> interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu CLK_UART5>;
> status = "disabled";
> };
>
> @@ -173,6 +179,7 @@ uart6: serial@b012c000 {
> compatible = "actions,s500-uart", "actions,owl-uart";
> reg = <0xb012c000 0x2000>;
> interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu CLK_UART6>;
> status = "disabled";
> };
>
>
Tested-by: Matheus Castello <matheus@castello.eng.br>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-09 3:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 21:17 [PATCH v3 00/13] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi Cristian Ciocaltea
2020-12-29 21:17 ` [PATCH v3 01/13] arm: dts: owl-s500: Add Clock Management Unit Cristian Ciocaltea
2021-01-09 3:38 ` Matheus Castello
2021-01-09 16:32 ` Cristian Ciocaltea
2020-12-29 21:17 ` [PATCH v3 02/13] arm: dts: owl-s500: Set CMU clocks for UARTs Cristian Ciocaltea
2021-01-09 3:39 ` Matheus Castello [this message]
2020-12-29 21:17 ` [PATCH v3 03/13] arm: dts: owl-s500: Add Reset controller Cristian Ciocaltea
2021-01-09 3:40 ` Matheus Castello
2020-12-29 21:17 ` [PATCH v3 04/13] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC Cristian Ciocaltea
2021-01-06 6:22 ` Vinod Koul
2020-12-29 21:17 ` [PATCH v3 05/13] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller Cristian Ciocaltea
2021-01-06 6:22 ` Vinod Koul
2020-12-29 21:17 ` [PATCH v3 06/13] arm: dts: owl-s500: Add " Cristian Ciocaltea
2021-01-09 3:40 ` Matheus Castello
2020-12-29 21:17 ` [PATCH v3 07/13] arm: dts: owl-s500: Add pinctrl & GPIO support Cristian Ciocaltea
2021-01-09 3:40 ` Matheus Castello
2020-12-29 21:17 ` [PATCH v3 08/13] arm: dts: owl-s500: Add MMC support Cristian Ciocaltea
2021-01-09 3:41 ` Matheus Castello
2020-12-29 21:17 ` [PATCH v3 09/13] arm: dts: owl-s500: Add I2C support Cristian Ciocaltea
2020-12-29 21:17 ` [PATCH v3 10/13] arm: dts: owl-s500: Add SIRQ controller Cristian Ciocaltea
2021-01-09 3:41 ` Matheus Castello
2020-12-29 21:17 ` [PATCH v3 11/13] arm: dts: owl-s500-roseapplepi: Add uSD support Cristian Ciocaltea
2020-12-31 7:27 ` Manivannan Sadhasivam
2020-12-31 9:05 ` Cristian Ciocaltea
2020-12-29 21:17 ` [PATCH v3 12/13] arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration Cristian Ciocaltea
2020-12-31 7:54 ` [PATCH v3 00/13] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi Manivannan Sadhasivam
2020-12-31 9:12 ` Cristian Ciocaltea
2020-12-31 17:12 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec2e5c68-fecd-ce2a-dc24-1a00085c6f73@castello.eng.br \
--to=matheus@castello.eng.br \
--cc=afaerber@suse.de \
--cc=cristian.ciocaltea@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).