From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCDFEC00140 for ; Tue, 2 Aug 2022 09:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3TygZnGd7CyyUjCAGJXUk+aKXQ9llLMXSXy3jTgwskk=; b=mgQE5tNXscfz8b I4+UYsT+rrG7NltA8w+FnHbNKSSXOQQMNu9l0Nwbxtjgzg8yFqYmgaDiAvq64XKhvq4WN/nK+J0AR xFMSgZ4BpirU29G0WW5q5l7AktveR7hULMcDa/S8e4G+tZW27i36qTzNHKB7Qg2Mo3ZEFnMAC/jqY zBYKgHQzD46Zktk0vfTJpJojdeqVXFDff5f0tehnVyZB4kJAMePvrWcfc0DJ+kFwmv6eieklpj7D+ 99enCzLE9DtDRwGIRxJ94rIiw4aQmChtoAnYnIDVtcEEAR7XVdUo3r7ekwMS4ICnOZOSlysxv3ViC UoLvqM2rQL1vBeB59ELQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oInnz-00C9L8-CM; Tue, 02 Aug 2022 09:03:11 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oInnw-00C9HQ-6S for linux-arm-kernel@lists.infradead.org; Tue, 02 Aug 2022 09:03:09 +0000 Received: by mail-lj1-x230.google.com with SMTP id s9so8955053ljs.6 for ; Tue, 02 Aug 2022 02:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zhuL9i9TDotSF+bYGEKALdF6iapdw0N+X68W860otKY=; b=OtFEcrvRm+vgI4ZkufiqiWnFlo6Oxs8kf1KZKPok63gKbrJrpSxzI+OzL5Hwb5louN FfW8ajOxcSSBVrxw3mF7Ihsi/8YK0HavLwyZ20zRyhpjtBCpwe8eqCQVenrQoajJqnjG 6eVF+rMJunBzJDdihBe/uIQ8PhRaYPVAmFpbw/XU+sS8/vyI4Fg9+7dqZFlXj4WBJULI gur7x4m9gecmh4tFCEKyHKHj56s5wSCwYVxVQfXvzIkSU9FmnU7raRRE7sbgSjqh4JZv 8ENKXuverbEFp6l4A0zsPhEkGb8OzRt9FhRmE4sblsY4ONPEUwL1z1g74TG52fJQy/77 /2Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zhuL9i9TDotSF+bYGEKALdF6iapdw0N+X68W860otKY=; b=OtkKMQqYZE8pscbNvNtAYL3OyEv3lodxJ3fS5I+te/WY8avlcRd+fg/ctqqiKCwBJR UhmvrKmNYkG7uyE7L9FlqJoGikVzdEWYGrttDeW/gwZVYR9LH4sLDKPDtC8XCpgfwUqN zPtY0rxfhlWx6bT2TvzKXtxdwkSaltKr3j7uHb9ESebWjJsgCGzJYm4/789uluQuCc2Y b1hBxtx9A9bS7aLZGF9Y0Bg06R7MHeJe4s+BmlLgSaG5m/dy03WojuUzT+SuuusXBJtH 6sF0LRz8vuH6KKEx+8kXHkBmoQGNRb+V6vPlVQTne7gcqvKRaqySuIu6scyz5GJYxPnF o7/g== X-Gm-Message-State: AJIora/GTVQ7Tlr395OZmkTpDY3HFIxpyxVTqhympcZLMJv4vQkC70Gf LZF55jph0+ejlBAbSnwLMeh95g== X-Google-Smtp-Source: AGRyM1siLBI+/dKc8L+pZh7GSlKLEDSw9zaPcBpli8DOQcLzlQt+ViI/atXXJs5olL7tsXdZHr56qQ== X-Received: by 2002:a05:651c:1542:b0:249:5d86:3164 with SMTP id y2-20020a05651c154200b002495d863164mr6169530ljp.500.1659430983581; Tue, 02 Aug 2022 02:03:03 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id u13-20020ac248ad000000b0048af7e1b268sm778067lfg.210.2022.08.02.02.03.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 02:03:03 -0700 (PDT) Message-ID: Date: Tue, 2 Aug 2022 11:03:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/9] dt-bindings: sram: sunxi-sram: Add D1 compatible string Content-Language: en-US To: Samuel Holland , Chen-Yu Tsai , Jernej Skrabec Cc: Arnd Bergmann , Hans de Goede , Icenowy Zheng , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20220801030509.21966-1-samuel@sholland.org> <20220801030509.21966-2-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20220801030509.21966-2-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_020308_393382_D3EB807F X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/08/2022 05:05, Samuel Holland wrote: > D1 needs to export a register for managing some LDO regulators, so it > needs a unique compatible. > > Signed-off-by: Samuel Holland > --- > > .../bindings/sram/allwinner,sun4i-a10-system-control.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > index 1c426c211e36..ab6e95a97c9f 100644 > --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml > @@ -39,6 +39,7 @@ properties: > - items: > - const: allwinner,sun8i-r40-system-control > - const: allwinner,sun4i-a10-system-control > + - const: allwinner,sun20i-d1-system-control > - const: allwinner,sun50i-a64-sram-controller > deprecated: true > - const: allwinner,sun50i-a64-system-control Please first clean up the compatible list. All these should be one enum. You have duplicated entries for two-compatible cases. Also enum. Don't grow this pattern... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel