From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7400FC433F5 for ; Mon, 3 Oct 2022 04:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jV+6dXy0uXVXtGstJJqgAvFXXygjwue93fzc+FvEeE8=; b=Ex9M7mDGQvBobk A42o5F2siRPPkhnFI5+tBkIin/UTiWi5avjZtPawSua7pms/koTmXU9wk/RkOAxIX6ecwnfa8A4Vl qArk0a4JXk4IF/mGR2JLFoUoVAMOccTap0+k5Sil76/pPMchNWHA4deOF82hoLkXVtMg/OC9WNGFJ S0KKDImC+N8pcdJBSS9twsXlu1tZAfuzASBXM2yuhSD4NDdvZ/miYEGdVHqRQCF7IT03GQ0kpx7Fw H5ZU9rKzZvqNJnSE2Frt7AgjOKtkJddI5ltYG4KIm2JJL6N/efDn5V4NNLXdlnKYZZDRPukUo5Gwy cNJ7T7QgA1c4XkaewsDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofCdj-003kOC-Ao; Mon, 03 Oct 2022 04:01:11 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofCdf-003kMX-GA; Mon, 03 Oct 2022 04:01:09 +0000 X-UUID: 5047e8cd07d0493ca7c4b7486285a285-20221002 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=zYZ4sRLSTPUaC9kC7FhZUcqk3IruZkgDgFqV4Pw+1+c=; b=CBSRmJM30fz6Qqz4oqZ11EbthSkPlZTAWYHsqXSaLFMvtnSEJDQ7Pzxbmc9KewTdM1/4aHaybHflZpvG2InwOjx0wvSvlA3Kg3K4HhUj0C82q/9l+iJoZJC7yDkdzi40flz7jCjzqhiQUqGpLZwKi17Fun+J4Q0TVQuaHP43htg=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:7f73adfb-9b6e-43c6-8ee5-078df99eaa38,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:39a5ff1,CLOUDID:f0d5c207-1cee-4c38-b21b-a45f9682fdc0,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 5047e8cd07d0493ca7c4b7486285a285-20221002 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1718510391; Sun, 02 Oct 2022 21:00:56 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Mon, 3 Oct 2022 12:00:24 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n1.mediatek.com (172.21.101.34) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 3 Oct 2022 12:00:24 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZiccoOAkpGmrcNX5q3jgD4IyDOyAZtf6HQpVE5HSztSeGFwnnVRYUher371Gpb3wKZJWO+vZR1uoaHJ7oAdML7Dxe71TUTUYTnlxVSlqwgNFUVNkjGFNRseLlAAitBW/RELYrwTLvAAG7jd3BRdFvEjjfMAVaPfqjcS+jKJpI7psrWNKQn4iXHctNToFQVIQGFde/QIFKeiVEeoxMylDbiCv5iOgCHwJEmyErSmcVcySTSLTnLq9DQGQiKzeit9y2QYYXWno8AaPi/lV4MUdo2HUAYzf/+d4MVNm/+ur4y/PRyjUVhx0husJxbkfaA7NwaM4ZwSije16h7kmP9vi+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYZ4sRLSTPUaC9kC7FhZUcqk3IruZkgDgFqV4Pw+1+c=; b=Nqtrj9cbRAHt1EGSsdWKzRoI83iP97IItluIet332H8vbWifZrjhZySO58CLHmgSpi8MewULB/dwqnTgdTTbjeN/zGHapx8mS2wYD+t3ZCjQB1XtAFRUwwlOggPz09Krgunfllhl7+QE/ghICXfVWvlSbHlNvLZX0adKSxUdBbaiHPVo932CZioqTRlACjXuMR2tRMWCUipKbt8GuX9mzKTirly6VssGcEo19INNOxqKBUCEo1SeGebzvh6JXm3T8ndPrltn/FjNjn5WhZUROsfXen42R9qFR9XFdFJ2m8zOjjdku0AFYGQKriTPXctNu00E54gBfpvpLzQCiJ2DxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYZ4sRLSTPUaC9kC7FhZUcqk3IruZkgDgFqV4Pw+1+c=; b=XkkPQnXwEpiYO87P0y4zeWkpm3rOilgRzt/fC1yUs2Ar9LKzKLguXI34m7zPLQLaDLE1PM695yQR0B6DEK2RpHAFDriscSa7xUWwp4I6c3IVmBDYnMtFHXJISuFzBTNSO0gn6xUehy+/TtWV1vX0QYcin/8s6cPDaWK1+KLqucQ= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by PSAPR03MB6379.apcprd03.prod.outlook.com (2603:1096:301:af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.8; Mon, 3 Oct 2022 04:00:23 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::b958:c9e0:9f6d:9ed]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::b958:c9e0:9f6d:9ed%8]) with mapi id 15.20.5676.028; Mon, 3 Oct 2022 04:00:23 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: =?utf-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , "chunkuang.hu@kernel.org" CC: "jassisinghbrar@gmail.com" , "matthias.bgg@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group , "hsinyi@chromium.org" Subject: Re: [PATCH v8, 1/4] mailbox: mtk-cmdq: add gce software ddr enable private data Thread-Topic: [PATCH v8, 1/4] mailbox: mtk-cmdq: add gce software ddr enable private data Thread-Index: AQHY1ObPx+txU1VQPkeXIrGkp8wdoa38D4MA Date: Mon, 3 Oct 2022 04:00:23 +0000 Message-ID: References: <20220930160638.7588-1-yongqiang.niu@mediatek.com> <20220930160638.7588-2-yongqiang.niu@mediatek.com> In-Reply-To: <20220930160638.7588-2-yongqiang.niu@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|PSAPR03MB6379:EE_ x-ms-office365-filtering-correlation-id: f5e3840b-204b-4066-8a08-08daa4f3cbf4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /C0sKKlhhwHMpa1zp1dFVq3Q3nFDcRLlScwCC/H/hCta8hH8BUPTpPXiS3tdvH+Q0GhiAWQx3E0CqVLW1W9mTeDZlSZiuTHqc8St5qEpnBLGWG6KgJBnGER0/V8nfFK66thEhpHGzkoXEhu87Y3eLkBW+BM5mCXrGCOO2mdfIgbFd/8Cdsk33iCPoA4T2zc4ZAPaMaQVcF2gtkK97AipsRGOmwId47tfZfal/+NPy7ZD4nnsUL3AMBF9l0q+cDYkfuPSj2Rgs6pYDlFIGWqQ7OJw1xDgqAbER58PB9EZHk2HfLG9Os2GhUSCP0K7hq2J96gwyarBy2rzn1K+2Z7UD2ZWo98a/5UeSvIQjU5IvHj0+/UXtQIpWKw1NIPlKtqwJ3sOePmRoS9uUfGOkSEW+OrWynF+qUilg0e1GZ00bz4J4gxFe9nm66CtmIVuFPJEP9+etgVB1nt0ODTsoNK9rTX/jT4sQYFJdcwJQipFw9xCLvaKjeW+k26c3nbPZinlg810m87FXkXP7faBvkrDl8XQXlmuHphNM/CTS5f3OHinpUqNnj3rz/Bybvy5Vyz130vORaLNlQwao8veI/AdvJN5CWQz3g2sn45ihp/momM290Ny0BFnrzm86OKmIaAHN+HY3HU0AHSXC8TmSlst/07wwVoWBXhdoYXDY8jTZXLjiq/vZeQ5Xysl6uaoOp/93Tifx8xToH8+/AbNH29n7LjyTjAWPTwQPcqSw3IZnFsSoBD/pduiJ2svqGUqAgvzlANKT3kBBTN+hkczCxfkWA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(396003)(136003)(376002)(366004)(39850400004)(451199015)(66476007)(86362001)(478600001)(71200400001)(4326008)(66946007)(6486002)(85182001)(15650500001)(76116006)(8936002)(41300700001)(8676002)(64756008)(316002)(54906003)(36756003)(5660300002)(66556008)(66446008)(110136005)(38100700002)(186003)(122000001)(6506007)(26005)(2616005)(6512007)(83380400001)(38070700005)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YlFLTnphVkF6REdtcVJlU0w2WEdZMTA0a0JwNXR5Tk5sUUdZVitOQlVucCt2?= =?utf-8?B?VG9PcGlVMjZGWHRkU1pydkE0bThuKzMyR2ZDaDlYblFpUjc2cWgwRDQxNG1t?= =?utf-8?B?Ly94dGVlNTlRb0o1ZnQrTGxCUmtzOGMzWG1XejFjOWpkWFlnYTQybTF4c2hm?= =?utf-8?B?ODZKdkhsNnNjZ0JTdTJ0aisrV2ZURWtuMUh4Q0tLZnlWaG4yTTZxWERySi92?= =?utf-8?B?c3hvU1BySVlUUFl0akZ0WWZyUDdLejVGYnlmaWZHV29pQkFmcndXMmRNQnpX?= =?utf-8?B?L28wQ2pteE15dXg0YS9KVHY3aG5jTFozMFMrc1NjRVh6cnpiN2pudWdxclFB?= =?utf-8?B?V1NHTzZFKzk1OFFER3V2SDhxSnl3RzVBbWprL1hzYjlxbVV5d3RHNVB3cHJk?= =?utf-8?B?RU4vTjgrby9jQlBWUUlzcGZSRWUxL3cyZ1JmZi9COG1TMnpUWmxLR2dtVkZq?= =?utf-8?B?Q1RCbTVjUXJSUm8wTmFQa1lxcVFiUG9HV2dPVkNzVmN1TG1MTVBZSXZ5bGEv?= =?utf-8?B?SXVkMFVlWGE2c1Bja00rcEhJWkN1SXVCUHhDZFp1N1Z3UDU0anFEYnlvOWtq?= =?utf-8?B?c3FxaUt0bjZ1Y0FYRmtmMWt3WE1vUWllQlB2OVMvaVUvaEdJNWRxcnpRZ2Z0?= =?utf-8?B?RTBacTBEdVBLY09jK1pleFVMU2VvYUlWeEJHUTJCaWt6MUJ3MXFEWFU1TlF4?= =?utf-8?B?a2hmbjJiYTBtTHU4Nm9aSlp1K2k1WDIzYXY0TnRqb1QzSmJsTVBOU2VJN2F4?= =?utf-8?B?ZGJuSVhibzhEazVqSU9kOUkyTEI1ZStyRlVJU1F1aE1tWHhVOFdRWDZldDlX?= =?utf-8?B?cEkrKzhYN0RnS2xNYkVhOHVYaS9yejIwK2x6ZVlVb2N0RVYrR1crTXRHNW9O?= =?utf-8?B?WDU1enEvcVJGeWhkVTViM2FkS2NMUFBzNk0zOUJ3ZjF5QmR1Vi9BTkdIeDhp?= =?utf-8?B?VjhvUmM0cE9SSkdYaVNRY3VNOWlsNHdZWkt0WjdWRGh2UEw2RDB0NDdTTGlm?= =?utf-8?B?VVI3d3NLc3ZHbVQyRXdGWEZHQnV3Y2pKS081c1J4TkRtMjhvK21JbkFjZVli?= =?utf-8?B?UjkzNi9MM1A5dDJUY2hUNm9ZZmhrOXVBd3NIZlNUdUVMenJseVhaRVdGWXhN?= =?utf-8?B?VkdmMFRiSGlnOWluSEZEWVRWaDh6cXhJVnNjZjdLVmJHdEpwRnpZM3g1UUMv?= =?utf-8?B?SW5QMGNtVDZlQjFBYjJGdkV4NnVSZ1crWm1HNkh5blVmcDNUUXNtMVpMbGRV?= =?utf-8?B?RFhnU210WElOaTRYZGRrVlFTcDd3KzZOQURHUjRmM2NMei80Q2hHaVpOdzdy?= =?utf-8?B?TGRDaVBKZEtVVXRsdFdHTW9wM3ZIUFNvZ2w4NG9Qb08xN2U5N1h1K3J1UHlw?= =?utf-8?B?dXp0ZE4yTGRlUzA4b0pucmZjNnplVWZieWN3TUIzQTY1ZEhSbnVjVkRIa2xy?= =?utf-8?B?SEp4U2RtNWNUQkU5Qnl1dmZqRUY3OE96eW5VbGphUXdKTlNTTjdKdlJuRnN5?= =?utf-8?B?NnFVNHliWkFRVGRBK0ZGRmZRaWpOUkZ3dVhqRmwvNSsxMTBIS013cWhkaTJ3?= =?utf-8?B?OTBkZU5UL0QydmgxcUJUc0pDRS81Vm9kZHlmbTB2enRnY2xjOUcwQ25kT1Vk?= =?utf-8?B?NDh2elU3MEhVVDNUZjhINFJBSlM1d3g3SE41TTA5NFFEeHkybDlDOWRXbnRw?= =?utf-8?B?Z0dweFNZOExlSHlrMlJPQU9JT1dkcktWbUVHZzJUanQwMFU5SjA0MDVoU1d6?= =?utf-8?B?QkRwNUM4T0tCMnRVQ3VuV1RURDhNWFBZdmZKaUJtcnhIZUFRSTZhYy9oOEpN?= =?utf-8?B?RTI1K2t5cVErOExzVENUdG5Kejh4VkszMFN3UENVbVBkTXJsZEhZRXdyVHli?= =?utf-8?B?bmx1OUJqU2RWRkhWS0lJVTNlSTJLeFpEL21FdzNiaEZtYTh5NDUwZUJJaTRw?= =?utf-8?B?bHpIWGQ0WUFaQW1FVU1VdnVia0dheTRDeGtkQVRIN1JyZjBuWm1ESDJoVzc4?= =?utf-8?B?a1UvTVpyLzVsbUsxbnVucDl4ZkFjWGEwTFFzVHA3TXc2d1czNmt6NlBMVnlZ?= =?utf-8?B?QXFnS1BJSXEvUnBaWjlhWVVQeTIwc1BZTWRYREFtVW1GVzh1M0ZWVTh1RzFq?= =?utf-8?B?c0lMVjVwWUhqdHlYcTZiNlJPMExJMGtFS01LTGs2UFhnQjd3cnFsUUFHQUNw?= =?utf-8?B?VUE9PQ==?= Content-ID: <509BCABDF921E846879C39723415C62C@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5e3840b-204b-4066-8a08-08daa4f3cbf4 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2022 04:00:23.1530 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NL7as25L11+j8nfcYV8kDi+DdEdOeo5XdgawBjOrwrTze6OPZnwpaja4Pg8YCNWBHYsiddwrWOdn0gA4BYoKbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR03MB6379 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221002_210107_743699_C2D54065 X-CRM114-Status: GOOD ( 20.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Yongqiang: On Sat, 2022-10-01 at 00:06 +0800, Yongqiang Niu wrote: > if gce work control by software, we need set software enable > for MT8186 Soc > > there is a handshake flow between gce and ddr hardware, > if not set ddr enable flag of gce, ddr will fall into idle > mode, then gce instructions will not process done. > we need set this flag of gce to tell ddr when gce is idle or busy > controlled by software flow. > > Signed-off-by: Yongqiang Niu > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > b/drivers/mailbox/mtk-cmdq-mailbox.c > index 9465f9081515..88db6b4642db 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -38,6 +38,8 @@ > #define CMDQ_THR_PRIORITY 0x40 > > #define GCE_GCTL_VALUE 0x48 > +#define GCE_CTRL_BY_SW GENMASK(2, 0) > +#define GCE_DDR_EN GENMASK(18, 16) > > #define CMDQ_THR_ACTIVE_SLOT_CYCLES 0x3200 > #define CMDQ_THR_ENABLED 0x1 > @@ -80,6 +82,7 @@ struct cmdq { > bool suspended; > u8 shift_pa; > bool control_by_sw; > + bool sw_ddr_en; > u32 gce_num; > }; > > @@ -87,6 +90,7 @@ struct gce_plat { > u32 thread_nr; > u8 shift; > bool control_by_sw; > + bool sw_ddr_en; > u32 gce_num; > }; > > @@ -130,6 +134,10 @@ static void cmdq_init(struct cmdq *cmdq) > WARN_ON(clk_bulk_enable(cmdq->gce_num, cmdq->clocks)); > if (cmdq->control_by_sw) > writel(0x7, cmdq->base + GCE_GCTL_VALUE); > + > + if (cmdq->sw_ddr_en) > + writel(GCE_DDR_EN | GCE_CTRL_BY_SW, cmdq->base + > GCE_GCTL_VALUE); I think 0x48[18:16] and 0x48[2:0] control different things and fix different problem. So for this patch, you should just control 0x48[18:16] and the code would be: if (cmdq->sw_ddr_en) { reg = readl(cmdq->base + GCE_GCTL_VALUE); reg |= GCE_DDR_EN; writel(reg, cmdq->base + GCE_GCTL_VALUE); } Regards, CK > + > writel(CMDQ_THR_ACTIVE_SLOT_CYCLES, cmdq->base + > CMDQ_THR_SLOT_CYCLES); > for (i = 0; i <= CMDQ_MAX_EVENT; i++) > writel(i, cmdq->base + CMDQ_SYNC_TOKEN_UPDATE); > @@ -543,6 +551,7 @@ static int cmdq_probe(struct platform_device > *pdev) > cmdq->thread_nr = plat_data->thread_nr; > cmdq->shift_pa = plat_data->shift; > cmdq->control_by_sw = plat_data->control_by_sw; > + cmdq->sw_ddr_en = plat_data->sw_ddr_en; > cmdq->gce_num = plat_data->gce_num; > cmdq->irq_mask = GENMASK(cmdq->thread_nr - 1, 0); > err = devm_request_irq(dev, cmdq->irq, cmdq_irq_handler, > IRQF_SHARED, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel