From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 629C3C433EF for ; Fri, 1 Oct 2021 16:50:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 273F761A7A for ; Fri, 1 Oct 2021 16:50:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 273F761A7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t824/WvY3YWinxjNWULXhTlenljoWnMxiyttvBCQLyA=; b=HCh2yyD1mV01Ex nyVoCYcsezkiblUn9jPM2rt+hNVhgUzz1PC0XnnuW32/lyxLBIrSv9LDaIREJUYUQTSvwq9DtwS2F hUk6IEsV1md0pINY3AZ6P0Xxo1SBHF+qUILUA58L9P7yO+cJ4ghLMTHgxvFP2PEle1qM4DfFCOLvk QEMOdKOU9kvshrgP3rg4tLqgLD5Dbq+uXk1Z9Eg1kNgK0zRWqVArbu+b4Cphl6GA9ecHJB49qNvVn b2CttFyMvc40essAvHpbXUIOOM41/w2aGw3NiQcwUSeq0URkm+z6JhypymxxNLrcLJ5KrQepb7Efg I4CkZayoIDp2OBJ4r4uQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWLhn-000uaA-UX; Fri, 01 Oct 2021 16:48:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWLhk-000uZb-OD for linux-arm-kernel@lists.infradead.org; Fri, 01 Oct 2021 16:48:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633106891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+wXL4FLopuVdUPifEc7KhUXBKpFTStH9lCl7cgYkOQ=; b=PJFNWAkMMyjE+kDwVkWtIBIBfBUWeWbAOn0q+Q+owLB3taQagOn3IQ2xSfSC/lV1C6FpMW 5PGJI3Mi+WOX7sgEyPZTV375jjky8q41M6bQ3Re1OxfEnOI0gAed062C3kk+9L53cxKbg5 Ev21MdihJbwUBGuqhQq32tAeYaCbFpI= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-395-aLC0Pq2fPiKU83Nun9DLzQ-1; Fri, 01 Oct 2021 12:48:08 -0400 X-MC-Unique: aLC0Pq2fPiKU83Nun9DLzQ-1 Received: by mail-ed1-f69.google.com with SMTP id ec14-20020a0564020d4e00b003cf5630c190so11048342edb.3 for ; Fri, 01 Oct 2021 09:48:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=E+wXL4FLopuVdUPifEc7KhUXBKpFTStH9lCl7cgYkOQ=; b=yj3QRFyyG+2+g69lXTxmphEr66WH83syTi5D4tiunERXlQs/LVCztW2/Jqc5b6NHnF X64apd3FEnUQ/EtzfnGWT2+eOVHwLSLi1ZkSt2sDVOfBxkUdHp6zQTgJAedyssFGpQjp NNR9Qknbp9HH/jnUx4yZ8MnE9cyR6nkNNI3QD/XKsI0EdGQyJL9nE7DCO/UW35+6IhSp xB2nEI+xfclfTiskQ+WfPD9aFENYQxHjb+IqrB7J+VU+2pcAm/SHWtf3E7nylZw3CIrW XVJr0uNkzCwwE+VdamCS73kTMeWMcTa6THA+Tq9RmHFnUNmXW1ErLJ1Xx3iXg53LlZ0c C1Yw== X-Gm-Message-State: AOAM531ygr4SKHvk4CUn/xFmlO47KgiTP4f3Iy1iVBtPfWaDrWIIvNdx yAg3kGwoOf0qCuQAdB1bI8606HdU5R8d8A89my6GBL2uzlwu0fvChiDuzEe2de9h8ZJM0O/JKsQ F8xp6xxsl4knRhLh2m2gEMl363i1PcfnfMHw= X-Received: by 2002:a50:becf:: with SMTP id e15mr15556190edk.114.1633106887591; Fri, 01 Oct 2021 09:48:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY/s9Eboq39fJzh2TN3pYZqcwpynGpENIpX504ZIFL6jL/Hkr+B3PpnPZt2v05b/8B27zGqA== X-Received: by 2002:a50:becf:: with SMTP id e15mr15556157edk.114.1633106887363; Fri, 01 Oct 2021 09:48:07 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id kw10sm3170950ejc.71.2021.10.01.09.48.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 09:48:06 -0700 (PDT) Message-ID: Date: Fri, 1 Oct 2021 18:48:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v8 5/7] kvm: x86: protect masterclock with a seqcount To: Oliver Upton , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu Cc: Sean Christopherson , Marc Zyngier , Peter Shier , Jim Mattson , David Matlack , Ricardo Koller , Jing Zhang , Raghavendra Rao Anata , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, Andrew Jones , Will Deacon , Catalin Marinas References: <20210916181538.968978-1-oupton@google.com> <20210916181538.968978-6-oupton@google.com> From: Paolo Bonzini In-Reply-To: <20210916181538.968978-6-oupton@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211001_094812_896390_B09B3C7D X-CRM114-Status: UNSURE ( 7.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/09/21 20:15, Oliver Upton wrote: > + seq = read_seqcount_begin(&ka->pvclock_sc); > + do { > + use_master_clock = ka->use_master_clock; Oops, the "seq" assignment should be inside the "do". With that fixed, my tests seem to work. I will shortly push the result to kvm/queue. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel