From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04451C47422 for ; Sun, 21 Jan 2024 17:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F071Rp5gA3NOhuXRVCgyY9Yf9qhrzXsTFndDyFg62hE=; b=NSDSaCh6emvskibLlx4OrMLMN4 HI8Hlsde/nyImEcBsh/ML4eEWaAR4XvfnA9NiMYqobEjgwm3kYzppO6+UI/0DSMAF1kj8x0P+eYsi 67aLsXWdRC2r5GQtYcIwlkeBF1i5+eMzBrPXLnMZ46OSWZ5c5dRC/dldcx+pp51cvSpO+O1EqbJid XbYMAs5jugd8QRNGW7oLBjEBIf6Lzr9Bi7GMy8IGR87HIDMqWr8OYogzNhutRNW+i7UALo4Ous/V4 EDHfEx4WbUV2DlQZ0IeriTsd9qti37sI/+R1dprQBUnj2B81kX67v2ffHaju+77WKaz4X0bx/1ThN wm3ZJfAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRbAf-009m4j-1o; Sun, 21 Jan 2024 16:59:45 +0000 Received: from mail-ot1-f44.google.com ([209.85.210.44]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRbAc-009m3J-0s; Sun, 21 Jan 2024 16:59:44 +0000 Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6ddf26eba3cso1596201a34.0; Sun, 21 Jan 2024 08:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705856320; x=1706461120; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=UTin+pUtKKFwXKEjsKCtXLOTNCLrJJcqZ1pcaGmtLvE=; b=VhmxrpwfPuowx/bbk0wCWigx6naprLji1feUb2eMnoUXUf61m4XV1fNo8UwZlmvE2i UDTxkSX/VM69+Xt7YdjqBVuohqF0w905o2lVxZlOskTv8UDVe9LyfG/yzVQeSAGempQ4 eg56DYYUOXArev45xN0QV7KvFHSHbqJ/RT55osY0XlbV/Vnue2uzaCHQmAuT3G8XjqDl HTUZKitAwJNJd6HlVATBV5tJjyqGl+aVFZYsocyHEl9vSOIHTIlW+rPerf60qvVJFo+N FgrTVr/ilPw9dam+oxbefcaEoRtsCZXq/W2qlh2W2I+D5mUsKJi0bKpxWzdqzNcMzvE8 rtJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705856320; x=1706461120; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UTin+pUtKKFwXKEjsKCtXLOTNCLrJJcqZ1pcaGmtLvE=; b=mcwW2O9G7xYjGiH79kv1uyK8SSuA8Rq0dT1R6gvc05IXECT+0OPQ4lt1cav98ipfc0 YRCxr+hLFUex2ttPfcV6tdASFmoB3sKz7ENRohK6yxeTm76Hyo/BMowapkUMaV0jnbzx 6k7OgdbuBRHCh/mzMD2IlB1EEmvs6EYw49QTaX7Op2CM3ezdtaa3PLPTh0AwlpzG9Pwn 7979ZOb/KgsfmJtDEy1+kQkGy294rT8gk3tWlWcQU9Rhgj5hhPu8C13xb5Aa2XcuQO3/ +3nuq39fUMvy7CN8uD2AegMwmcgix6uoZ9TQHwkXAfZvu/4c/bBneeYdrt2xgko0eUmX rQag== X-Gm-Message-State: AOJu0YwX21hf/VczTFKYU6Y86lsZEnr8WbOS2ADWBCSAPD0Wsve1EYXB O9fNfTDdutsCNHSb+v8JLeKWbt7uJ1/FwBZfWeTYKBfGMR8/V8S+ X-Google-Smtp-Source: AGHT+IE6/IIMGPrM1Pn/AcOYfyt0ZVyudQ6g+shGqX1BDyHmA9qG0H50bS5cQRnoANoGmRhP4CEWkg== X-Received: by 2002:a05:6830:12c1:b0:6e0:c060:66f6 with SMTP id a1-20020a05683012c100b006e0c06066f6mr3248433otq.32.1705856320418; Sun, 21 Jan 2024 08:58:40 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id kq13-20020a056a004b0d00b006daf6892afesm8476843pfb.144.2024.01.21.08.58.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jan 2024 08:58:39 -0800 (PST) Message-ID: Date: Sun, 21 Jan 2024 08:58:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 03/10] spi: Add multi-cs memories support in SPI core Content-Language: en-US To: Mark Brown References: <20231125092137.2948-1-amit.kumar-mahapatra@amd.com> <20231125092137.2948-4-amit.kumar-mahapatra@amd.com> <3d3a11b1-8396-4d8e-9bb3-61ecb67e7efa@roeck-us.net> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240121_085942_309792_BABCC477 X-CRM114-Status: GOOD ( 13.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, vigneshr@ti.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, git@amd.com, sbinding@opensource.cirrus.com, richard@nod.at, lee@kernel.org, tudor.ambarus@linaro.org, amitrkcian2002@gmail.com, Amit Kumar Mahapatra , linux-sound@vger.kernel.org, james.schulman@cirrus.com, rf@opensource.cirrus.com, tiwai@suse.com, perex@perex.cz, michal.simek@amd.com, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, claudiu.beznea@tuxon.dev, linux-spi@vger.kernel.org, michael@walle.cc, david.rhodes@cirrus.com, pratyush@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/20/24 17:04, Mark Brown wrote: > On Sat, Jan 20, 2024 at 09:05:43AM -0800, Guenter Roeck wrote: > >> FWIW, the problem is due to > >> +#define SPI_CS_CNT_MAX 4 > >> in the offending patch, but apeed2400 FMC supports up to 5 SPI chip selects. >> >> static const struct aspeed_spi_data ast2400_fmc_data = { >> .max_cs = 5, >> ^^^^^^^^^^^^^^^^^^^ >> .hastype = true, > >> Limiting .max_cs to 4 or increasing SPI_CS_CNT_MAX to 5 fixes the problem, >> though of course I don't know if increasing SPI_CS_CNT_MAX has other side >> effects. > > Yeah, I was coming to a similar conclusion myself - the limit is just > too low. I can't see any problem with increasing it. It would cost a bit of memory and somewhat affect performance sine many of the newly introduced loops are bound by SPI_CS_CNT_MAX and not by num_chipselect. It also might make sense to document the new limit somewhere. Prior to this commit it was not limited at all. Documentation/devicetree/bindings/spi/spi-davinci.txt lists 5 chip selects in its example for the use of cs-gpios. Documentation/devicetree/bindings/spi/spi-controller.yaml also does not list a limit. Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel