From: "Trevor Wu (吳文良)" <Trevor.Wu@mediatek.com>
To: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"perex@perex.cz" <perex@perex.cz>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: mediatek: add missing initialization
Date: Wed, 1 Mar 2023 10:37:12 +0000 [thread overview]
Message-ID: <eca88f53e1f767eb7c2e6e45b0e335accf18023b.camel@mediatek.com> (raw)
In-Reply-To: <3d2f385e-dc85-8033-cf77-e5f0634c5be0@collabora.com>
On Wed, 2023-03-01 at 11:00 +0100, AngeloGioacchino Del Regno wrote:
> Il 01/03/23 05:08, Trevor Wu ha scritto:
> > In etdm dai driver, dai_etdm_parse_of() function is used to parse
> > dts
> > properties to get parameters. There are two for-loops which are
> > sepearately for all etdm and etdm input only cases. In etdm in only
> > loop, dai_id is not initialized, so it keeps the value intiliazed
> > in
> > another loop.
> >
> > In the patch, add the missing initialization to fix the unexpected
> > parsing problem.
> >
> > Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
>
> I agree about this fix, but this commit is not fine as it is:
> Please split it in two commits and add the appropriate Fixes tag to
> each
> for backports.
>
> Regards,
> Angelo
>
Got it.
I will split it into two commits in V2.
Thanks,
Trevor
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-03-01 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 4:08 [PATCH] ASoC: mediatek: add missing initialization Trevor Wu
2023-03-01 10:00 ` AngeloGioacchino Del Regno
2023-03-01 10:37 ` Trevor Wu (吳文良) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eca88f53e1f767eb7c2e6e45b0e335accf18023b.camel@mediatek.com \
--to=trevor.wu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox