From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE505C77B7C for ; Wed, 31 May 2023 07:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PSbTiirWbtYrkLRXulBdycnZWXNoSc0FiNLcNC8YkjA=; b=PoABaEiAEoNO51 +7dWHejeCZshF7f1rQenyET1a3nWYn/9Vf6aicWzCTHCPX4zubpwNWZr45GivQm4OpG5pz+YbLEU2 bKw48U8CepFmfLwnh+JiN1JpK3gsoRk+BiobKc6PqkUHIXIQq7JdrGFtyM9L1STeAIP39Jn5/1aiE PV2X9az1hV0w+2qmoXHpoNi4FkpvWO/eBNRfJVgtaOMJRsbmuLlslD93sPAelHLA4J/8G0/ZZOGx1 Z/qG6sjaPoCnlX3sRLUbzrhY2efQk6JAnwCZvGNyU3hQQAZuKERHCHDFhlY1LLrM0Ysi+F9z4vZD+ zTtCvZWQG0FjDMVC306w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4Gen-00GWno-2W; Wed, 31 May 2023 07:54:09 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4Gej-00GWlB-2L for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 07:54:08 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-97392066d04so816678766b.3 for ; Wed, 31 May 2023 00:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685519640; x=1688111640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=suMN4n1BQ2Z7VU4EicsbwuyOBR1pEV+6Sounu4iuM0U=; b=A+dncCJbXSV6kSVPSolkbyxdvYQgh78/2P6Mxm5SwqhtgIwtPGJcWPOCn2HHPS8CZU 5Wm6uBWJvU48wgmG5ogwKoX1rNY5Z4RvNjhYSfdKVup3NWmYut1ny6EzBC/0KBEdFYZG xojVvnM2ROqLlEAcS9yaN4/6x6eWoBszGXQOpJIHAvRGhkMWrxnPPLFGhWYVSsSGeEN9 2H039xpBhxvO9MhPMs3niA9LdSl3yS9GN3cvnO02PehmLZyf7Z3iF22kZ2fJ0LQ6a+6r o7q7EgJVKnuR6VScDRFC0YASfU8S/WZdZZm5f5DystD06dKFWoX6h19/bkbktB7qdXFQ NluA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519640; x=1688111640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suMN4n1BQ2Z7VU4EicsbwuyOBR1pEV+6Sounu4iuM0U=; b=R2MTbyQlZRk/G6SD2+a/3KdVzbsUAaUC6zlZKPNwDgQw97RSaj2/SgS2+srRabNsUH F9JqKC0DXDTx8V2GkF5p4MzD80Fwp8dMOL5VJv0vrJMhgU86QKUShuH2e3lovcyeu3Xe +THC5qJipUE2U92ESlnYL7SY5wZYc0EB9xs4HQwdrsFku1isTJyev6JxwONZUZIL4c42 MSviWD7PGJVrExlgAjfkaxWGG8SNoT0pePpdTvyAO33XAaJ2sYPN+Wyyf8/IJkEltSGU jOjlYn0vLpu5y4ymc9dykLwsu8XU7QzUXqcUNSbJOVYkFTOM381VblnmccHk+v9pwN/D nZLg== X-Gm-Message-State: AC+VfDzyM0jJZyo+UBZjJSYCXsI0QHx9oPsLftl+KaTiqpTSaPV/RP8C nar+NH3RuYz70AoZhjp5t5OBYw== X-Google-Smtp-Source: ACHHUZ7i7M8zh8gh6sQ1ZK5S6VAQvpJeaDVE/ihPO9ya44BVZ1jGFqvdF+9ycji5LoT7N7p0i74PDw== X-Received: by 2002:a17:907:d8a:b0:973:d1ce:dbe8 with SMTP id go10-20020a1709070d8a00b00973d1cedbe8mr5163876ejc.46.1685519640052; Wed, 31 May 2023 00:54:00 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id ce23-20020a170906b25700b0096f8bb60c96sm8511314ejb.100.2023.05.31.00.53.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:53:59 -0700 (PDT) Message-ID: Date: Wed, 31 May 2023 09:53:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml To: Conor Dooley , matthias.bgg@kernel.org Cc: rafael@kernel.org, Daniel Lezcano , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, Amit Kucheria , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Zhang Rui , linux-arm-kernel@lists.infradead.org, Matthias Brugger References: <20230530150413.12918-1-matthias.bgg@kernel.org> <20230530-thaw-unpaved-a1708d46eb5a@spud> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230530-thaw-unpaved-a1708d46eb5a@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_005405_763446_6D65FDD4 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/05/2023 00:02, Conor Dooley wrote: > Hey Matthias, > > On Tue, May 30, 2023 at 05:04:12PM +0200, matthias.bgg@kernel.org wrote: > >> + The MediaTek thermal controller measures the on-SoC temperatures. >> + This device does not have its own ADC, instead it directly controls >> + the AUXADC via AHB bus accesses. For this reason this device needs >> + phandles to the AUXADC. Also it controls a mux in the apmixedsys >> + register space via AHB bus accesses, so a phandle to the APMIXEDSYS >> + is also needed. > > That double "also" bothers my OCD greatly, but it is a faithful > conversion. > >> + "#thermal-sensor-cells": >> + const: 1 > >> -- #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description. > > How come this has changed? I didn't see an explanation for it in either > of the patches. Yep. Please mention the deviations from pure conversion and if not obvious - justify them. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel