From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45494C04A68 for ; Wed, 27 Jul 2022 06:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=LDbpuhOVcWjrKKl4Ww4R40gMYM4kaxGWO96eQp685iA=; b=NAu5j2sfMzdirMxgk+4NzCJHdJ F9Rb2q7zWxR231B8tZUEZ0nSIy+dP5XiMlnZvdEgLcwuGOQiBoALZXOnXgprfBgboaKP6r0YRG1AP lerInrEEpViBQqu9yh21Ci2CpEqY6MYmfo15PedKG7VzJ7khmmxsjRh5Ef+X2m/6W18OZESiKZOHq O6OrOj7lWTefmNKkiB/bgiXLP7Z20wpiQ9poKzyK9ey4Iz8wGyshCwCwc7fdoCAOg/DvjGrchIaiD R4seKioKHx0BJPPesoVlxnhVj3ISJWTMrSl0TRSaQYSanV07n+NMBauKP3NhqE+6pJJvcskH5KYJ/ JSIaThAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGaY7-009yYx-AE; Wed, 27 Jul 2022 06:29:39 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGaY3-009yVR-9q for linux-arm-kernel@lists.infradead.org; Wed, 27 Jul 2022 06:29:37 +0000 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Lt3kX65Ygz9sxl; Wed, 27 Jul 2022 14:28:20 +0800 (CST) Received: from kwepemm600010.china.huawei.com (7.193.23.86) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 14:29:31 +0800 Received: from [10.67.110.237] (10.67.110.237) by kwepemm600010.china.huawei.com (7.193.23.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 14:29:29 +0800 Subject: Re: [PATCH 5/5] ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK To: Linus Walleij CC: , , , , , , , , , , , , , , , , , , , , , , References: <20220712021527.109921-1-lihuafei1@huawei.com> <20220712021527.109921-6-lihuafei1@huawei.com> From: Li Huafei Message-ID: Date: Wed, 27 Jul 2022 14:29:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.67.110.237] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600010.china.huawei.com (7.193.23.86) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_232935_621621_09DD49A5 X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus, On 2022/7/18 17:12, Linus Walleij wrote: > On Tue, Jul 12, 2022 at 4:19 AM Li Huafei wrote: > >> This patch converts ARM stacktrace to the generic ARCH_STACKWALK >> implemented by commit 214d8ca6ee85 ("stacktrace: Provide common >> infrastructure"). >> >> Signed-off-by: Li Huafei > > Looks good to me: > Reviewed-by: Linus Walleij > > What I want to know is if this commit will avoid the problem mentioned > in review of commit 3? I.e. the generic stackwalk code will make sure we are > not running the task on another CPU, so that is why we could remove > that check? > In v3, I removed patch 3 of v1 and kept that check, see https://lore.kernel.org/lkml/20220727040022.139387-1-lihuafei1@huawei.com/ Given this change, I did not add your reviewed-by to patch 4 of v3. If you think patch 4 of v3 is still ok, please do let me know. Thank you very much! Thanks, Huafei > Yours, > Linus Walleij > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel